Change in ovirt-engine[ovirt-engine-4.0.5]: aaa: Assign unique id to each logged in user
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: Assign unique id to each logged in user
......................................................................
aaa: Assign unique id to each logged in user
On user login if the user is not found in
the database a default user id was assigned
to the all users (all zeros). Now when two
users logged in to the system they got the
union of permissions for each user.
This can be resolved by assigning a unique id
to each logged in user if the user is not
found in the database
Change-Id: Ie79a1d0b9b5da4fa338e166510b678212e8e137f
Bug-Url: https://bugzilla.redhat.com/1380780
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65460
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie79a1d0b9b5da4fa338e166510b678212e8e137f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.5
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-ruby[sdk_4.0]: Accept 200 code for 'Add' methods
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Accept 200 code for 'Add' methods
......................................................................
Accept 200 code for 'Add' methods
Currently the SDK doesn't accept the HTTP 200 code as a valid result of
'Add' methods, but some methods in the server return this code, for
example the method that adds a cluster quota limit. This patch changes
the SDK so that accepts it.
Change-Id: I88cb176b0ec53c77aac3edb11cecd24b2b93f9e8
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 50a6347547f1c557caabe5c692a93fd6fce7e24d)
---
M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java
M sdk/spec/vms_service_spec.rb
2 files changed, 31 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65353
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88cb176b0ec53c77aac3edb11cecd24b2b93f9e8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in jenkins[master]: opstools-ansible: added to master nightly publisher
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: opstools-ansible: added to master nightly publisher
......................................................................
opstools-ansible: added to master nightly publisher
Change-Id: I5355a1feb8b1b62b34f1a51483f8aa52d2f9fcda
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65467
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5355a1feb8b1b62b34f1a51483f8aa52d2f9fcda
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in jenkins[master]: opstools-ansible: fix extra-build-packages
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: opstools-ansible: fix extra-build-packages
......................................................................
opstools-ansible: fix extra-build-packages
Change-Id: I3526b300cf549dea73574e9da1d66738f263edb2
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/opstools-ansible/opstools-ansible_create-rpms.yaml
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/65461
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3526b300cf549dea73574e9da1d66738f263edb2
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in jenkins[master]: opstools-ansible: provide spectool
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: opstools-ansible: provide spectool
......................................................................
opstools-ansible: provide spectool
Change-Id: I729e20d9553f896692c667c94f598fe706c62419
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/opstools-ansible/opstools-ansible_create-rpms.yaml
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65459
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I729e20d9553f896692c667c94f598fe706c62419
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in jenkins[master]: opstools-ansible: new job
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: opstools-ansible: new job
......................................................................
opstools-ansible: new job
Change-Id: Ie9223a4fb6e679564b4ce734a62c5dac05c532af
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A jobs/confs/projects/opstools-ansible/opstools-ansible_create-rpms.yaml
1 file changed, 22 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65458
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9223a4fb6e679564b4ce734a62c5dac05c532af
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: engine: Eliminate fallback logic when installing a host
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Eliminate fallback logic when installing a host
......................................................................
engine: Eliminate fallback logic when installing a host
In ovirt-engine 4.0 the supported host protocol is JSON-RPC.
Therefore there is no longer a need for the fallback logic to
attempt re-connect with XML-RPC protocol.
Change-Id: I84dfba8cbe9d4cc41b22cf5e5acc73ebdcab41ac
Bug-Url: https://bugzilla.redhat.com/1373847
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
A packaging/dbscripts/upgrade/04_01_0330_set_host_protocol_to_jsonrpc.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
5 files changed, 10 insertions(+), 179 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, approved
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/65272
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84dfba8cbe9d4cc41b22cf5e5acc73ebdcab41ac
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: aaa: Assign unique id to each logged in user
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: Assign unique id to each logged in user
......................................................................
aaa: Assign unique id to each logged in user
On user login if the user is not found in
the database a default user id was assigned
to the all users (all zeros). Now when two
users logged in to the system they got the
union of permissions for each user.
This can be resolved by assigning a unique id
to each logged in user if the user is not
found in the database
Change-Id: Ie79a1d0b9b5da4fa338e166510b678212e8e137f
Bug-Url: https://bugzilla.redhat.com/1380780
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65429
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie79a1d0b9b5da4fa338e166510b678212e8e137f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: UpdateWatchdogCommandTest spying
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: UpdateWatchdogCommandTest spying
......................................................................
core: UpdateWatchdogCommandTest spying
Spy the command under test instead of anonymously overriding it.
Change-Id: I7bc1216e06e88db9d37c535ff51883ef8139a37a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateWatchdogCommandTest.java
1 file changed, 6 insertions(+), 19 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64640
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bc1216e06e88db9d37c535ff51883ef8139a37a
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: UpdateWatchdogCommandTest @Spy
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: UpdateWatchdogCommandTest @Spy
......................................................................
core: UpdateWatchdogCommandTest @Spy
Use the @Spy annotation to spy the command being tested in
order to allow injecting mocks in subsequent patches.
Change-Id: I1d5b3260e58c2cb037c08dfcb74218591c85e111
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateWatchdogCommandTest.java
1 file changed, 37 insertions(+), 25 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/64641
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d5b3260e58c2cb037c08dfcb74218591c85e111
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months