October 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: Add a nicer message on too old DC/cluster
by sbonazzo＠redhat.com 06 Oct '16

06 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Add a nicer message on too old DC/cluster ...................................................................... packaging: setup: Add a nicer message on too old DC/cluster Change-Id: I8c6492b896951c9673c4f25878e11f40fa2c6a4e Bug-Url: https://bugzilla.redhat.com/1371366 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py 1 file changed, 27 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/65134 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c6492b896951c9673c4f25878e11f40fa2c6a4e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: boot: remove all bootstrap flows other than appliance
by sbonazzo＠redhat.com 06 Oct '16

06 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: boot: remove all bootstrap flows other than appliance ...................................................................... boot: remove all bootstrap flows other than appliance Change-Id: Iffb0f25e332d1e85906568a5869df838bc51bc73 Bug-Url: https://bugzilla.redhat.com/1366183 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M po/POTFILES.in M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/mixins.py M src/plugins/gr-he-common/core/remote_answerfile.py M src/plugins/gr-he-common/vm/boot_disk.py M src/plugins/gr-he-common/vm/cloud_init.py M src/plugins/gr-he-setup/engine/os_install.py M src/plugins/gr-he-setup/vm/Makefile.am M src/plugins/gr-he-setup/vm/__init__.py R src/plugins/gr-he-setup/vm/cdrom.py M src/plugins/gr-he-setup/vm/configurevm.py M src/plugins/gr-he-setup/vm/runvm.py M src/plugins/gr-he-upgradeappliance/vm/configurevm.py M templates/vm.conf.in 14 files changed, 29 insertions(+), 188 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65087 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffb0f25e332d1e85906568a5869df838bc51bc73 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Update to model 4.0.36
by tnisan＠redhat.com 05 Oct '16

05 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update to model 4.0.36 ...................................................................... restapi: Update to model 4.0.36 The more relevant changes in the new version of the model are the following: * Add `gluster` value to the `NetworkUsage` enum. * Add `force` parameter to the operation that updates a storage server connection. * Move the `quota` link from the `Vm` type to the `VmBase` type. Change-Id: Icaeaf32c29cb972f87ab3613b5b9d0e12c3cf58e Related-To: https://bugzilla.redhat.com/1379802 Related-To: https://bugzilla.redhat.com/1379771 Related-To: https://bugzilla.redhat.com/1379225 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65124 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaeaf32c29cb972f87ab3613b5b9d0e12c3cf58e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix NPE when adding a VIRTIO-ISCSI disk to a VM
by tnisan＠redhat.com 05 Oct '16

05 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix NPE when adding a VIRTIO-ISCSI disk to a VM ...................................................................... core: Fix NPE when adding a VIRTIO-ISCSI disk to a VM Change-Id: I58894f313578da4fc5d4ff2f0b81e2fff3d915db Bug-Url: https://bugzilla.redhat.com/1381807 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskVmElementValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/65120 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58894f313578da4fc5d4ff2f0b81e2fff3d915db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddDiskCommandTest storageId params
by amureini＠redhat.com 05 Oct '16

05 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddDiskCommandTest storageId params ...................................................................... core: AddDiskCommandTest storageId params Remove setting the storageId in initializeCommand(Guid, VolumeType) as it delegated to initializeCommand(Guid, AddDiskParameters) which handles it anyway. Change-Id: Icf4723efa1cda539e23ac7eb2b4706951ea81bf0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf4723efa1cda539e23ac7eb2b4706951ea81bf0 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddDiskCommandTest#createISCSILunDisk
by amureini＠redhat.com 05 Oct '16

05 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddDiskCommandTest#createISCSILunDisk ...................................................................... core: AddDiskCommandTest#createISCSILunDisk Removed redundant interface parameter from the method's signature. Change-Id: I5d7486448ba52c8d67a4f5c69b86175b8f3c53d2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64713 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d7486448ba52c8d67a4f5c69b86175b8f3c53d2 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddDiskCommandTest: local variables
by amureini＠redhat.com 05 Oct '16

05 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddDiskCommandTest: local variables ...................................................................... core: AddDiskCommandTest: local variables Removed redundant local variables. Change-Id: I477dc2e1eafee8665b06b699ccbfc359058e457a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I477dc2e1eafee8665b06b699ccbfc359058e457a Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddDiskCommandTest @Spy annotation
by amureini＠redhat.com 05 Oct '16

05 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddDiskCommandTest @Spy annotation ...................................................................... core: AddDiskCommandTest @Spy annotation Spy the command with the @Spy annotation instead of explicitly calling Mockito.spy in order to set the ground for using injected mocks in these tests in the future. Change-Id: Ic9443fe686c9943a5cb0210b2054b3ea289c2ebd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java 1 file changed, 74 insertions(+), 104 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9443fe686c9943a5cb0210b2054b3ea289c2ebd Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddDiskCommandTest: rm redundant VM mocking
by amureini＠redhat.com 05 Oct '16

05 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddDiskCommandTest: rm redundant VM mocking ...................................................................... core: AddDiskCommandTest: rm redundant VM mocking AddDisk deals primarily with adding disks (unsurprisingly), although it has a small overlap with VMs as it allows to add and attach a disk in a single action. Most of the test cases, though, do not relate to VMs, and mocking a VM into them just bloats the code and confuses the reader. This patch reduces the VM mocking to where its actually needed in order to make the test more concise and easier to read. Change-Id: I0984bd695054dd5143cfa3bd7458a3fb26a8ac78 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java 1 file changed, 7 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0984bd695054dd5143cfa3bd7458a3fb26a8ac78 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[cli_3.6]: cli: Prepare for next release
by juan.hernandez＠redhat.com 05 Oct '16

05 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Prepare for next release ...................................................................... cli: Prepare for next release In preparation for the next release this patch increases the version number and sets the RPM release number to 0.1. Change-Id: If3b359ecc36c96f09692fd85ef77882e7cdd578c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65111 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3b359ecc36c96f09692fd85ef77882e7cdd578c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0