October 2016 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: AddVdsCommandTest mocks

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVdsCommandTest mocks ...................................................................... core: AddVdsCommandTest mocks Remove redundant mocks. Change-Id: I5e8fa2d530ae9f6000b11edbed02f3f602312e98 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommandTest.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64633 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e8fa2d530ae9f6000b11edbed02f3f602312e98 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: AddVdsCommandTest un-@Ignore test

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVdsCommandTest un-@Ignore test ...................................................................... core: AddVdsCommandTest un-@Ignore test The message in the @Ignore annotation is unclear, and seems outdated as the test clearly runs and passes. This patch removes the redundant annotation and allows another test to run. Change-Id: I33ff10328b30b1806c53065753fcf5501a1da6c5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommandTest.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33ff10328b30b1806c53065753fcf5501a1da6c5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: AddExternalStepCommandTest mock logger

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddExternalStepCommandTest mock logger ...................................................................... core: AddExternalStepCommandTest mock logger Remove the unused mocked logger. Change-Id: I62cce256881a5c6c16112ec589092d3b85e1c561 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddExternalStepCommandTest.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64638 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62cce256881a5c6c16112ec589092d3b85e1c561 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: RemoveVdsComamndTest#mockHasVolumeOnServer javadoc

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveVdsComamndTest#mockHasVolumeOnServer javadoc ...................................................................... core: RemoveVdsComamndTest#mockHasVolumeOnServer javadoc Remove a wrong parameter from the javadoc. Change-Id: Idaab19bc2f132924ade97c23a701129ec5c876b8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64626 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaab19bc2f132924ade97c23a701129ec5c876b8 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: RemoveVdsCommandTest @Spy

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveVdsCommandTest @Spy ...................................................................... core: RemoveVdsCommandTest @Spy Use the @Spy annotation to spy the command being tested in order to allow injecting mocks in subsequent patches. This patch includes: - Changing the command being tested to be initialized once and annotated with @Spy and @InjectMocks. - Thus, there is only only command object per test, so all the methods receiving commands as parameters were redone to use the member. - Removed redundant mocking. - Wherever possible, these now argument-less methods were annotated with @Before to avoid having to call them explicitly in each test. - Setters were added to the parameter class to allow changing its properties after the command has been created. Change-Id: If956ce1c275bb2daa83e49aba7a347d83f52f81f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVdsParameters.java 2 files changed, 12 insertions(+), 27 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64625 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If956ce1c275bb2daa83e49aba7a347d83f52f81f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: UpdateCluserCommandTest single StoragePoolDao

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateCluserCommandTest single StoragePoolDao ...................................................................... core: UpdateCluserCommandTest single StoragePoolDao The test, like the production code, should have a single instance of a StoragePoolDao. Change-Id: I9d1b52f4e39eb24f414a0c3954edb86fe489a2e9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java 1 file changed, 2 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64622 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d1b52f4e39eb24f414a0c3954edb86fe489a2e9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: UpdateClusterCommandTest collections

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateClusterCommandTest collections ...................................................................... core: UpdateClusterCommandTest collections Use basic collections instead of anonymously extending HashSet and HashMap. Change-Id: I9edc1d8c6b2f276daa500c0b51a225a94a49cfab Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java 1 file changed, 7 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64618 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9edc1d8c6b2f276daa500c0b51a225a94a49cfab Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: UpdateClusterCommandTest initUser

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateClusterCommandTest initUser ...................................................................... core: UpdateClusterCommandTest initUser Stop unnecessarily stubbing initUser(). Change-Id: I8e825ae0907b385c7fca591355fdc0fc4e26df47 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e825ae0907b385c7fca591355fdc0fc4e26df47 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: UpdateClusterCommandTest params ctor

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateClusterCommandTest params ctor ...................................................................... core: UpdateClusterCommandTest params ctor Stop explicitly checking if the managementNetworkId variable is null - the two argument constructor already takes care of it. Change-Id: I1850724cc055b4c079a2589df8b86de04ec6ca87 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1850724cc055b4c079a2589df8b86de04ec6ca87 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: UpdateClusterCommandTest#createCommandWithOlderVersion

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateClusterCommandTest#createCommandWithOlderVersion ...................................................................... core: UpdateClusterCommandTest#createCommandWithOlderVersion Remove unused parameters. Change-Id: Ieb823923011b81561cba66eab45073d1a3b83b4d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb823923011b81561cba66eab45073d1a3b83b4d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits October 2016