November 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: @Inject GetVmsByInstanceTypeIdQuery Daos
by Code Review 16 Nov '16

16 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetVmsByInstanceTypeIdQuery Daos ...................................................................... core: @Inject GetVmsByInstanceTypeIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I14741c6a40d5f9b4fcbc4dd4f8b4563cda6463bc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsByInstanceTypeIdQuery.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/66878 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14741c6a40d5f9b4fcbc4dd4f8b4563cda6463bc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: network: remove vdsm-no-mac-spoofing filter
by Code Review 16 Nov '16

16 Nov '16

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: network: remove vdsm-no-mac-spoofing filter ...................................................................... network: remove vdsm-no-mac-spoofing filter Setting vdsm-no-mac-spoofing filter on the engine VM interface requires an ebtables rules set that seams problematic on RHEL 7.3. Change-Id: I622f2866f9be4ecb0852e23f02b5f7bc9d42f06d Bug-Url: https://bugzilla.redhat.com/1386293 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/mixins.py M templates/vm.conf.in 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66891 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I622f2866f9be4ecb0852e23f02b5f7bc9d42f06d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Move initialization in LiveMigrateDiskCommand to init ...
by Code Review 16 Nov '16

16 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Move initialization in LiveMigrateDiskCommand to init block ...................................................................... core: Move initialization in LiveMigrateDiskCommand to init block LiveMigrateDiskCommand CTOR is calling getVm() which triggers a DAO call, those calls in the command classes are now using the DAOs by injection and since injection is performed after the CTOR is invoked the DAOs will be null. Moved the initialization part from the CTOR to the init block where it belonds to avoid the NPE caused. Change-Id: Idbc71d59f8c2f47e320bed2b98056fa102fa84db Bug-Url: https://bugzilla.redhat.com/1395746 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/66890 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbc71d59f8c2f47e320bed2b98056fa102fa84db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: adding generation to Image
by Code Review 16 Nov '16

16 Nov '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: adding generation to Image ...................................................................... core: adding generation to Image This patch adds the generation field to Image, in order to be used by GetVolumeInfo to report the current image generation. Change-Id: I26a86704b8c4d68bd5174357d359ab8f204ae6dc Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Image.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66840 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26a86704b8c4d68bd5174357d359ab8f204ae6dc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: network: remove vdsm-no-mac-spoofing filter
by Code Review 16 Nov '16

16 Nov '16

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: network: remove vdsm-no-mac-spoofing filter ...................................................................... network: remove vdsm-no-mac-spoofing filter Setting vdsm-no-mac-spoofing filter on the engine VM interface requires an ebtables rules set that seams problematic on RHEL 7.3. Change-Id: I622f2866f9be4ecb0852e23f02b5f7bc9d42f06d Bug-Url: https://bugzilla.redhat.com/1386293 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/mixins.py M templates/vm.conf.in 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/66853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I622f2866f9be4ecb0852e23f02b5f7bc9d42f06d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Remove unneeded jobs
by Code Review 16 Nov '16

16 Nov '16

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Remove unneeded jobs ...................................................................... Remove unneeded jobs There are some products that still have jobs with create rpms and std-ci build artifacts. I remove the unneeded old create RPMs and also removes the calls to deploy experimental from those which are check patch oriented Change-Id: I8e632244c9c6998b17657269bbab8b502f5297c3 Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- M jobs/confs/projects/ioprocess/ioprocess.yaml M jobs/confs/projects/otopi/otopi_create-rpms.yaml M jobs/confs/projects/ovirt-host-deploy/ovirt-host-deploy_create-rpms.yaml M jobs/confs/projects/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_create-rpms.yaml M jobs/confs/projects/ovirt-iso-uploader/ovirt-iso-uploader_create-rpms.yaml M jobs/confs/projects/ovirt-vmconsole/ovirt-vmconsole_create-rpms.yaml 6 files changed, 179 insertions(+), 56 deletions(-) Approvals: Eyal Edri: Looks good to me; Ready for merge Gil Shinar: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e632244c9c6998b17657269bbab8b502f5297c3 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetVdsStaticByNameQuery Daos
by Code Review 16 Nov '16

16 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetVdsStaticByNameQuery Daos ...................................................................... core: @Inject GetVdsStaticByNameQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I1675a708d887b756206ca709d236139f80a1e874 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsStaticByNameQuery.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1675a708d887b756206ca709d236139f80a1e874 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetVdsHooksByIdQuery Daos
by Code Review 16 Nov '16

16 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetVdsHooksByIdQuery Daos ...................................................................... core: @Inject GetVdsHooksByIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I158f5f2b3f7bb9ebf734b90d4a3dcf7c56e88197 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsHooksByIdQuery.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I158f5f2b3f7bb9ebf734b90d4a3dcf7c56e88197 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetVdsFenceStatusQuery Daos
by Code Review 16 Nov '16

16 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetVdsFenceStatusQuery Daos ...................................................................... core: @Inject GetVdsFenceStatusQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I5c13aa7758f58e6a844053f09b14827dc4b4ee42 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsFenceStatusQuery.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c13aa7758f58e6a844053f09b14827dc4b4ee42 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetVdsCertificateSubjectByVmIdQuery Daos
by Code Review 16 Nov '16

16 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetVdsCertificateSubjectByVmIdQuery Daos ...................................................................... core: @Inject GetVdsCertificateSubjectByVmIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I62b71cc008cb09e7f2392d06569969e6f452cc42 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsCertificateSubjectByVmIdQuery.java 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62b71cc008cb09e7f2392d06569969e6f452cc42 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0