Change in ovirt-engine[ovirt-engine-4.0.5]: webadmin: Improve column control menu
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Improve column control menu
......................................................................
webadmin: Improve column control menu
1. replaced JavaScript/jQuery JSNI code with proper Java/GWT
code to avoid performance issues & leaks
2. replaced up/down arrow icons on menu items with drag'n'drop
Side note: HTML5 DnD spec is a _total_ mess.
Change-Id: I14b47620db16b25657e4a7197a84db38fe956420
Bug-Url: https://bugzilla.redhat.com/1285499
Bug-Url: https://bugzilla.redhat.com/1368101
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
Signed-off-by: Alexander Wels <awels(a)redhat.com>
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnContextMenu.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnContextMenu.ui.xml
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnContextMenuItem.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnContextMenuItem.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnController.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnResizeCellTable.java
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/ColumnContextMenu.css
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/checkbox_no.png
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/checkbox_yes.png
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/move_down.png
D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/move_up.png
11 files changed, 328 insertions(+), 375 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/65919
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14b47620db16b25657e4a7197a84db38fe956420
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.5
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0.5]: webadmin, userportal: Clean up Editor fields before Model obj...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin,userportal: Clean up Editor fields before Model objects
......................................................................
webadmin,userportal: Clean up Editor fields before Model objects
This ensures that GWT widgets hooked to UiCommon models have
a chance to do their cleanup *before* we destroy the models.
This fixes NPEs where a model is already destroyed but a GWT
widget attempts to access its properties such as the property
change event, see AbstractUiCommandButton#cleanup for example.
Change-Id: I3dd8e320a774c35db8262e9a297557243a99ef5a
Bug-Url: https://bugzilla.redhat.com/1389998
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/UiCommonEditorDriverGenerator.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorDriver.java
2 files changed, 20 insertions(+), 20 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/65923
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3dd8e320a774c35db8262e9a297557243a99ef5a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.5
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0.5]: webadmin: Null check before model cleanup
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Null check before model cleanup
......................................................................
webadmin: Null check before model cleanup
Patch gerrit.ovirt.org/63708 introduced improved model cleanup yet in
cases where the model is already null due to a missing null check a UI
exception will be thrown (for instance when closing a dialog with ESC)
Bug-Url: https://bugzilla.redhat.com/1379312
Bug-Url: https://bugzilla.redhat.com/1389998
Change-Id: I89b94e175352a25019bfcabf1af70ea9a615af83
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/65922
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I89b94e175352a25019bfcabf1af70ea9a615af83
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.5
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0.5]: webadmin: VM dialog mem leak
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: VM dialog mem leak
......................................................................
webadmin: VM dialog mem leak
- Fixed memory leaks in the VM dialog.
Change-Id: I53c22111275458753bdabc43f710b9e837a59a46
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1368101
Signed-off-by: Alexander Wels <awels(a)redhat.com>
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/HasDataListModelEditorAdapter.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBoxEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnResizeCellTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ManagePolicyUnitPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.java
13 files changed, 66 insertions(+), 27 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/65921
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53c22111275458753bdabc43f710b9e837a59a46
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.5
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin, userportal: Clean up Editor fields before Model obj...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin,userportal: Clean up Editor fields before Model objects
......................................................................
webadmin,userportal: Clean up Editor fields before Model objects
This ensures that GWT widgets hooked to UiCommon models have
a chance to do their cleanup *before* we destroy the models.
This fixes NPEs where a model is already destroyed but a GWT
widget attempts to access its properties such as the property
change event, see AbstractUiCommandButton#cleanup for example.
Change-Id: I3dd8e320a774c35db8262e9a297557243a99ef5a
Bug-Url: https://bugzilla.redhat.com/1389998
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/UiCommonEditorDriverGenerator.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorDriver.java
2 files changed, 20 insertions(+), 20 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/65918
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3dd8e320a774c35db8262e9a297557243a99ef5a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Null check before model cleanup
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Null check before model cleanup
......................................................................
webadmin: Null check before model cleanup
Patch gerrit.ovirt.org/63708 introduced improved model cleanup yet in
cases where the model is already null due to a missing null check a UI
exception will be thrown (for instance when closing a dialog with ESC)
Bug-Url: https://bugzilla.redhat.com/1379312
Bug-Url: https://bugzilla.redhat.com/1389998
Change-Id: I89b94e175352a25019bfcabf1af70ea9a615af83
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/65917
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I89b94e175352a25019bfcabf1af70ea9a615af83
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months