Change in ovirt-engine[ovirt-engine-4.1]: webadmin: add error indication to invalid VM name
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: add error indication to invalid VM name
......................................................................
webadmin: add error indication to invalid VM name
When importing a VM there was no indication of an invalid
VM name in the general sub tab, this patch adds a
highlight with the information in the tooltip by changing
the UI element to StringEntityModelTextBoxOnlyEditor
which has validation unlike the previous TextBoxChanger.
Change-Id: Ia6484840460ea05f8e186f410b89c58b39d0d79d
Bug-Url: https://bugzilla.redhat.com/1403578
Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmImportGeneralModelForm.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java
2 files changed, 14 insertions(+), 3 deletions(-)
Approvals:
Benny Zlotnik: Verified
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69309
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6484840460ea05f8e186f410b89c58b39d0d79d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[master]: webadmin: fix NPE when editing an unattached sd
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: fix NPE when editing an unattached sd
......................................................................
webadmin: fix NPE when editing an unattached sd
An unattached storage domain doesn't have a datacenter, and thus
checking its datacenter's version is not possible.
Change-Id: If9510a21b599cec419e1eda3e34c47bb9bcd904d
Bug-Url: https://bugzilla.redhat.com/1408727
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/69306
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9510a21b599cec419e1eda3e34c47bb9bcd904d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine-sdk[sdk_4.1]: Raise SDK error for unknown tags
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Raise SDK error for unknown tags
......................................................................
Raise SDK error for unknown tags
Currently when the SDK tries to read a document that contains an
unknonwn tag, for example, a document that is actually HTML, it
generates a 'KeyError' because it tries to access a dictionary that
doesn't contain that tag as key. In this situation the SDK should
instead generate a SDK error explaining that there is no reader for that
tag. But that doesn't happen because we are accessing the dictionary
with the '[]' operator, which generates the 'KeyError' when the key
doesn't exist. To avoid that this patch changes the SDK so that it uses
the 'get' method instead, and so that it raises an SDK error instead of
an 'Exception'.
Change-Id: Ifebb1d5d71dfdb3ccccae9ae0596d9fadc5ed1b9
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 4a7fe15baaaaa80bcc48872b040c22913202ac75)
---
M sdk/lib/ovirtsdk4/reader.py
M sdk/tests/test_reader.py
2 files changed, 17 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69265
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifebb1d5d71dfdb3ccccae9ae0596d9fadc5ed1b9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in jenkins[master]: Update system-tests.sh to accept also custom repos
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: Update system-tests.sh to accept also custom repos
......................................................................
Update system-tests.sh to accept also custom repos
system-tests.sh can get list of repos to push
to extra_sources, default is no repos
Change-Id: I64b8760f947aa98006e41e7b67f13e7bdfaa05e6
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/shell-scripts/system_tests.sh
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/69288
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64b8760f947aa98006e41e7b67f13e7bdfaa05e6
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in jenkins[master]: add new 'custom repos' parameter to standard CI
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: add new 'custom repos' parameter to standard CI
......................................................................
add new 'custom repos' parameter to standard CI
Uses the 'text' parameters and allows giving
multiple repos a job
Change-Id: Ic7d604131d47f32ee433672e865c6b83ce423a5f
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
A jobs/confs/yaml/parmeters/repos.yaml
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69275
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7d604131d47f32ee433672e865c6b83ce423a5f
Gerrit-PatchSet: 7
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in jenkins[master]: make manual trigger generic
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: make manual trigger generic
......................................................................
make manual trigger generic
We might want to use it not just for
manual build artifacts
Change-Id: I3e84f6c241d256a10c23f7aa9dd3ad98b3b12ec2
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/yaml/templates/standard-stage.yaml
M jobs/confs/yaml/triggers/standard.yaml
2 files changed, 8 insertions(+), 4 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Gil Shinar: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69279
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e84f6c241d256a10c23f7aa9dd3ad98b3b12ec2
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[master]: core: do not ignore down event on destroy vm
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: do not ignore down event on destroy vm
......................................................................
core: do not ignore down event on destroy vm
Since we introduced the separation of host and VMs monitoring plus events,
it takes too much time to power-off a VM. Power-off should be a quick
operation - similar to unplug the power cable from a physical machine.
However, it can now take up to 15 seconds in the worst case for this
operation to finish (and even 20sec considering the UI refresh rate):
1. the engine locks the VM with its monitoring lock.
2. engine sends destroy call to VDSM.
3. VDSM sends an event that the VM is destroyed.
4. the engine ignores the event since because of the VM is locked.
5. the VM remains in Powering Down status until the next polling cycle.
Sure, events should be queued and not ignored, but this is a too complex
change to do at the moment. This patch introduces an alternative approach
that eliminates the lock in destroy-VM flow.
Change-Id: I14931877309867bbbc0115e3a384e39757e3234c
Bug-Url: https://bugzilla.redhat.com/1367023
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
4 files changed, 72 insertions(+), 11 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/69030
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14931877309867bbbc0115e3a384e39757e3234c
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[master]: core: store vm manager in VmCommand
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: store vm manager in VmCommand
......................................................................
core: store vm manager in VmCommand
As it seems to be useful for more and more commands that extend VmCommand,
it only makes sense to store VmManager in VmCommand.
Change-Id: Ie2b1afde465d2211d05405c60554c37ddcae56af
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
3 files changed, 11 insertions(+), 8 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/69293
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2b1afde465d2211d05405c60554c37ddcae56af
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[master]: webadmin: add select all header for re-assign bad MACs column
by Code Review
>From Daniel Erez <derez(a)redhat.com>:
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: add select all header for re-assign bad MACs column
......................................................................
webadmin: add select all header for re-assign bad MACs column
Changes in re-assign bad MACs column:
* Add select all checkbox on the column header
* Add label for the checkbox cells
Change-Id: Ifd6817cca2a9505f357f9df294c058d6b1be6b21
Bug-Url: https://bugzilla.redhat.com/1317447
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmPopupView.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
3 files changed, 79 insertions(+), 20 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/68034
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd6817cca2a9505f357f9df294c058d6b1be6b21
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[master]: webadmin: Add re-assign bad macs column to register VM dialog
by Code Review
>From Daniel Erez <derez(a)redhat.com>:
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Add re-assign bad macs column to register VM dialog
......................................................................
webadmin: Add re-assign bad macs column to register VM dialog
Add re-assign bad macs column to register VM dialog + warning.
Change-Id: I6166d19d5b8aabeea7b282b6bd94a2ce8e0c2be5
Bug-Url: https://bugzilla.redhat.com/1317447
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/RegisterVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageRegisterVmListModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/register/RegisterVmData.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterEntityPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmInfoPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmPopupView.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
10 files changed, 328 insertions(+), 42 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/67593
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6166d19d5b8aabeea7b282b6bd94a2ce8e0c2be5
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months