Change in ovirt-engine[ovirt-engine-4.1]: rest-api: take max memory from template
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: rest-api: take max memory from template
......................................................................
rest-api: take max memory from template
When editing a pool we fill static properties of the VMs in the
pool from their template, like memory size for example. The
setting of max memory size was missing, preventing the ability
to edit a pool.
Change-Id: I45e5e0e387b3bb132a8d647d306ef18cf8c593d4
Bug-Url: https://bugzilla.redhat.com/1408577
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
(cherry picked from commit 3d914643022d88f962e1187a5eaef949a9b76f44)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69245
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45e5e0e387b3bb132a8d647d306ef18cf8c593d4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Prevent moving the hosted engine storage domain to mai...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Prevent moving the hosted engine storage domain to maintenance
......................................................................
core: Prevent moving the hosted engine storage domain to maintenance
Before moving a storage domain to maintenance validate that the hosted
engine VM disk is not running on it
Change-Id: I4aa384d0335cfff20ab323e5ab655507edd65f0f
Bug-Url: https://bugzilla.redhat.com/1402789
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommand.java
1 file changed, 26 insertions(+), 15 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69186
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4aa384d0335cfff20ab323e5ab655507edd65f0f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: Block deactivation of a storage domain with running VM...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Block deactivation of a storage domain with running VMs with leases
......................................................................
core: Block deactivation of a storage domain with running VMs with leases
Bug-Url: https://bugzilla.redhat.com/1408876
Change-Id: I2a12b7d64eaa597f1d884bba18c60ae4f24c675b
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 32 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, but someone else must approve
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69219
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a12b7d64eaa597f1d884bba18c60ae4f24c675b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: Add methods to obtain VMs and template with leases on ...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add methods to obtain VMs and template with leases on domain to DAO
......................................................................
core: Add methods to obtain VMs and template with leases on domain to DAO
Adding to the relevant DAOs methods to obtain the list of VMs and templates
with leases on a certain domain and to obtain the list of running VMs with
leases on a certain domain
Bug-Url: https://bugzilla.redhat.com/1408877
Bug-Url: https://bugzilla.redhat.com/1408876
Change-Id: I3541ebc68f14c80c524494b5c5bbe66a39fb5728
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDaoTest.java
M packaging/dbscripts/vms_sp.sql
4 files changed, 78 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69218
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3541ebc68f14c80c524494b5c5bbe66a39fb5728
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: Pull up storage domain static and dynamic in fixtures.xml
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Pull up storage domain static and dynamic in fixtures.xml
......................................................................
core: Pull up storage domain static and dynamic in fixtures.xml
Since introducing VM leases the VmStatic entity can hold a reference to a
storage domain with the column 'lease_sd_id', in fixtures.xml the
storage_domain_static table is defined after the vm_static table causing
any VM that holds a reference to a storage domain to fail the test
database creation on a foreign key constraint since the
storage_domain_static table is not created yet.
This patch moves the storage_domain_static and storage_domain_dynamic
table up, right after storage_pool to avoid this problem, this is also
more logical given the heirarchy of storage domain in the system.
Change-Id: I508876248ec5867974fe2cf3de4f6ecc17b5c42e
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/dal/src/test/resources/fixtures.xml
1 file changed, 287 insertions(+), 286 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69216
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I508876248ec5867974fe2cf3de4f6ecc17b5c42e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: Add leases to VMs and templates in fixtures.xml
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add leases to VMs and templates in fixtures.xml
......................................................................
core: Add leases to VMs and templates in fixtures.xml
A column of leases was added to vm_static and it needs to be reflected
in the test database as well
Change-Id: Ib3402dd212ccb8735edc544162ee84d0f3f7726b
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/dal/src/test/resources/fixtures.xml
1 file changed, 18 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69217
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3402dd212ccb8735edc544162ee84d0f3f7726b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: @Inject StorageConnectionHelper's DAO
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: @Inject StorageConnectionHelper's DAO
......................................................................
core: @Inject StorageConnectionHelper's DAO
Now that StorageConnectionHelper is managed by CDI, its DAO can easily
be injected instead of using DbFacade.
Change-Id: I433d53d70ba98d76e403d6ea575e935182fe36e0
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StorageConnectionHelper.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/storage/StorageConnectionHelperTest.java
2 files changed, 6 insertions(+), 15 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/69249
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I433d53d70ba98d76e403d6ea575e935182fe36e0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: @Inject StorageConnectionHelper
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: @Inject StorageConnectionHelper
......................................................................
core: @Inject StorageConnectionHelper
Use CDI to inject this helper as a @Singleton instead of all the
boilerplate code required to implement a singleton by ourselves.
Change-Id: I6f6237105bdeda8bf8d4f70ea99ef87931597d38
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StorageConnectionHelper.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/storage/StorageConnectionHelperTest.java
4 files changed, 15 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/69248
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f6237105bdeda8bf8d4f70ea99ef87931597d38
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: StorageConnectionHelperTest mocking
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: StorageConnectionHelperTest mocking
......................................................................
core: StorageConnectionHelperTest mocking
StorageConnectionHelperTest#helper is initialized by the @Mock
annotation, and then overriden in the setup() method. Since this mock is
never used, the annotation can safely be removed.
Change-Id: I84ca1ad4bde182143b58073ae28d30a80f1c8cc1
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/storage/StorageConnectionHelperTest.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/69246
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84ca1ad4bde182143b58073ae28d30a80f1c8cc1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: StorageConnectionHelperTest values
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: StorageConnectionHelperTest values
......................................................................
core: StorageConnectionHelperTest values
Inline parameters that are always called with the same arguments in
order to clean up the code.
Change-Id: I82a2fb2e4e289e72a4d9354686eedee6cbe25d80
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/storage/StorageConnectionHelperTest.java
1 file changed, 14 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/69247
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82a2fb2e4e289e72a4d9354686eedee6cbe25d80
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months