December 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Remove IE-specific code in ApplicationFocusManager
by Code Review 16 Dec '16

16 Dec '16

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Remove IE-specific code in ApplicationFocusManager ...................................................................... webadmin: Remove IE-specific code in ApplicationFocusManager IE9+ supports addEventListener() and deprecates attachEvent(). IE11+ no longer supports attachEvent(). Change-Id: I588dd8f46f8b0f583688068fcb1446feb254a309 Bug-Url: https://bugzilla.redhat.com/1378935 Bug-Url: https://bugzilla.redhat.com/1404610 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ApplicationFocusManager.java 1 file changed, 3 insertions(+), 24 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/68486 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I588dd8f46f8b0f583688068fcb1446feb254a309 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Remove IE9 hack in UI suggest box widget
by Code Review 16 Dec '16

16 Dec '16

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Remove IE9 hack in UI suggest box widget ...................................................................... webadmin: Remove IE9 hack in UI suggest box widget oVirt UI supports IE10+ so there's no need for IE9- hacks. Change-Id: I0c8f6596f55c4dfa42be674abceb374574a21cf8 Bug-Url: https://bugzilla.redhat.com/1378935 Bug-Url: https://bugzilla.redhat.com/1404610 Related-To: https://bugzilla.redhat.com/1160774 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java 1 file changed, 1 insertion(+), 51 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/68483 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c8f6596f55c4dfa42be674abceb374574a21cf8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: USB controller in osinfo
by Code Review 16 Dec '16

16 Dec '16

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: core: USB controller in osinfo ...................................................................... core: USB controller in osinfo This patch introduces new osinfo option "devices.usb.controller". It will allow to configure VM USB controller per operating system and cluster version when SPICE USB redirection is disabled (VM > Console > USB Support in Webadmin). This settings will not effect used USB controllers when SPICE USB redirection is enabled. Before this patchset engine didn't create any USB controller when SPICE USB redirection was disabled and thus no USB controller device was present in domain XML passed from VDSM to libvirt. Libvirt automatically adds defautl USB controller if domain xml doesn't specify otherwise. Motivation for this patchset is to * allow users to optionally use controllers compatible with new USB specifications (USB 3.1) * some controllers seems not to be compatible with ppc Change-Id: Idfaf61f0695a4462adc35a5d3b24b8a4f652d5b8 Bug-Url: https://bugzilla.redhat.com/1373223 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UsbControllerModel.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M backend/manager/modules/utils/src/main/javacc/org/ovirt/engine/core/utils/osinfo/osinfo.jj M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 5 files changed, 80 insertions(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/68399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfaf61f0695a4462adc35a5d3b24b8a4f652d5b8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Configurable USB controllers
by Code Review 16 Dec '16

16 Dec '16

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: core: Configurable USB controllers ...................................................................... core: Configurable USB controllers VmDeviceUtils.updateUsbSlots() refactored to allow switching between USB controllers for SPICE USB redirection (same as before) and USB controllers defined in osinfo (previously USB controllers were just removed if SPICE USB redirection was disabled). This change allows users to use new controllers compatible with USB 3 and avoid compatibility issues with ppc platform and some controllers. Change-Id: If803eef66a91b099f4b5f99a2f3d2b8b3c30ecc8 Bug-Url: https://bugzilla.redhat.com/1373223 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 118 insertions(+), 37 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/68400 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If803eef66a91b099f4b5f99a2f3d2b8b3c30ecc8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: fix nautilus-open-terminal package issue
by Code Review 16 Dec '16

16 Dec '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: fix nautilus-open-terminal package issue ...................................................................... fix nautilus-open-terminal package issue In RHEL/CentOS 7.3 the package was replaced with the package named gnome-terminal-nautilus. This patch updates the kickstart file. Change-Id: I7123a1821939a9d4f699eadc600187118d155f23 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> (cherry picked from commit 78aebcd351ad51a2f75f82d856c637758c708d83) (cherry picked from commit 041613b7377509e1765775ca12648c1e6193d737) --- M centos-7/kickstart/centos-7-livecd.cfg 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/68577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7123a1821939a9d4f699eadc600187118d155f23 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: fix nautilus-open-terminal package issue
by Code Review 16 Dec '16

16 Dec '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: fix nautilus-open-terminal package issue ...................................................................... fix nautilus-open-terminal package issue In RHEL/CentOS 7.3 the package was replaced with the package named gnome-terminal-nautilus. This patch updates the kickstart file. Change-Id: I7123a1821939a9d4f699eadc600187118d155f23 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> (cherry picked from commit 78aebcd351ad51a2f75f82d856c637758c708d83) --- M centos-7/kickstart/centos-7-livecd.cfg 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/68576 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7123a1821939a9d4f699eadc600187118d155f23 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: make ExternalVmMacsFinder use ReadMacPool
by Code Review 16 Dec '16

16 Dec '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: make ExternalVmMacsFinder use ReadMacPool ...................................................................... engine: make ExternalVmMacsFinder use ReadMacPool Change-Id: I1991853687c01a7168a06cf48535e3793971a841 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ExternalVmMacsFinder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/mac/OutOfRangeVmMacsFinder.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVMFromConfigurationCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/ExternalVmMacsFinderTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/mac/OutOfRangeVmMacsFinderTest.java 6 files changed, 16 insertions(+), 23 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/68567 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1991853687c01a7168a06cf48535e3793971a841 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: upgrade: polling with a new instance instead of update
by Code Review 16 Dec '16

16 Dec '16

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: upgrade: polling with a new instance instead of update ...................................................................... upgrade: polling with a new instance instead of update update method for untouched object got broken with oVirt 4.1 (see: https://bugzilla.redhat.com/1404360 ) Polling using a new broker instance on each round Change-Id: I2750509ed3237ebac9934644a982582c61774684 Bug-Url: https://bugzilla.redhat.com/1404360 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-upgradeappliance/engine/misc.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/68521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2750509ed3237ebac9934644a982582c61774684 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add activity validations for amend.
by Code Review 16 Dec '16

16 Dec '16

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add activity validations for amend. ...................................................................... core: Add activity validations for amend. 1. Add validation whether the storage pool is active for amend. 2. Add validation whether the storage domain is active for amend. Change-Id: I2b1db20e11f2b2517417156b504417c6d3811377 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AmendImageGroupVolumesCommand.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/68554 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b1db20e11f2b2517417156b504417c6d3811377 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add step support for amend operation.
by Code Review 16 Dec '16

16 Dec '16

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add step support for amend operation. ...................................................................... core: Add step support for amend operation. Add step support for the amend operation. Change-Id: Ib8a417695dbb2e78ff1983712baf41ad90c49838 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AmendImageGroupVolumesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AmendVolumeCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/StorageConstants.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 4 files changed, 24 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/68549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8a417695dbb2e78ff1983712baf41ad90c49838 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0