December 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Set orig cluster version on VM snapshot preview
by Code Review 06 Dec '16

06 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Set orig cluster version on VM snapshot preview ...................................................................... core: Set orig cluster version on VM snapshot preview This patch fixes setting of original cluster version by UpdateVmCommand for VM snapshots with disks. Before this patch, only VMs without disks were handled. Change-Id: Ia0d027086bbb6c865b14c1a20f47dbfa4136f20e Bug-Url: https://bugzilla.redhat.com/1364456 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java 1 file changed, 62 insertions(+), 19 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0d027086bbb6c865b14c1a20f47dbfa4136f20e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageDomain knows if it contains hosted engine disk
by Code Review 06 Dec '16

06 Dec '16

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: core: StorageDomain knows if it contains hosted engine disk ...................................................................... core: StorageDomain knows if it contains hosted engine disk Add a property to StorageDomain indicating if it contains any disk mounted to the Hosted Engine VM. Change-Id: I968b407be5fbdea9c4d563f19b79bf0ac7ae5f7f Bug-Url: https://bugzilla.redhat.com/1392412 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> Signed-off-by: Martin Sivák <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsWithAttachedStoragePoolGuidQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsWithAttachedStoragePoolGuidQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBaseTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDaoTest.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/storages_sp.sql 11 files changed, 180 insertions(+), 45 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Phillip Bailey: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/66721 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I968b407be5fbdea9c4d563f19b79bf0ac7ae5f7f Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: packaging: spec: harden permission on jar
by Code Review 06 Dec '16

06 Dec '16

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. Change subject: packaging: spec: harden permission on jar ...................................................................... packaging: spec: harden permission on jar harden permission on installed jar file from 755 to 644. It doesn't need executable bits. Change-Id: I75e4b6751b9e46d2499575aca3c348c4bed25092 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M otopi.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75e4b6751b9e46d2499575aca3c348c4bed25092 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Added POSTCOPY pause status
by Code Review 06 Dec '16

06 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Added POSTCOPY pause status ...................................................................... core: Added POSTCOPY pause status Added POSTCOPY status to VmPauseStatus. Checking this status in VmAnalyzer to distinguish post-copy migration from other cases. Change-Id: I28449729ef06ba4545e7314bf7b9847e8c546efe Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPauseStatus.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 2 files changed, 16 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67602 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28449729ef06ba4545e7314bf7b9847e8c546efe Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: spelling fix "Ovirt" -> "oVirt"
by Code Review 06 Dec '16

06 Dec '16

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. Change subject: engine: spelling fix "Ovirt" -> "oVirt" ...................................................................... engine: spelling fix "Ovirt" -> "oVirt" Change-Id: I82fb5a11e5e9c20977f0cebb5958d476dc8b23f2 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M build/validations/src/test/java/org/ovirt/engine/build/validations/OsinfoValidationsTest.java M packaging/branding/ovirt.brand/messages.properties 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified Oved Ourfali: Looks good to me, approved Scott Dickerson: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/67765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82fb5a11e5e9c20977f0cebb5958d476dc8b23f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: do not update guest agent nics in migrating-to status
by Code Review 06 Dec '16

06 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: do not update guest agent nics in migrating-to status ...................................................................... core: do not update guest agent nics in migrating-to status Update NICs according to guest-agent's report when dynamic and statistics VM information are updated. Specifically, not when the VM is in MigratingTo status. Change-Id: Ie0c703eb0bfab2363f545531ad1e5e1900970528 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/67863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0c703eb0bfab2363f545531ad1e5e1900970528 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Fix custom bond mode option input
by Code Review 06 Dec '16

06 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix custom bond mode option input ...................................................................... webadmin: Fix custom bond mode option input The label and the input for "Custom Mode" options in the SetupNetworksBondPopupView was only visible, if the bonding mode is chosen to 'Custom'. In the previous implementation the higher level container in the user interface did not provide enough space to receive user inputs for "Custom Mode" options. Without choosing the "Custom Mode", the user was not aware of the input of "Custom Mode" options. The higher level container in the user interface is increased and they layout is changed to a Container of bootstrap grid system. Additionally the "Custom Mode" options input is disabled, if the user does not choose the "Custom Mode". Change-Id: I4b7a4d251cdb50d5fa32fccb50910c9decc730d9 Bug-Url: https://bugzilla.redhat.com/1391130 Signed-off-by: Dominik Holler <dholler(a)redhat.com> (cherry picked from commit 7a38c09d9a0f1691327f6620b2e198e0cd7dd651) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.ui.xml 2 files changed, 16 insertions(+), 16 deletions(-) Approvals: Dominik Holler: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b7a4d251cdb50d5fa32fccb50910c9decc730d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: automation: moving build-artifacts to build minimal
by Code Review 06 Dec '16

06 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: automation: moving build-artifacts to build minimal ...................................................................... automation: moving build-artifacts to build minimal We don't need to run full matrix of lang + browsers on each commit in CI, it takes too long and steals valuable resources, such as BM slaves. It also delays the response / fix time of any fix merged into engine to show up on system jobs. cherry-picked from master, this already saves 40 min runtime of builds on CI in master. Another benefit is to get more info on experimental flow if we move the build to run on each commit as opposed to each 2 hours as it is now. Change-Id: I7a4c56d40a5dbf95764dff7887792a0893d54145 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M automation/build-artifacts.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/67774 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a4c56d40a5dbf95764dff7887792a0893d54145 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: Version bump to 1.0.13 for ovirt 4.1
by Code Review 06 Dec '16

06 Dec '16

>From Vinzenz Feenstra <vfeenstr(a)redhat.com>: Vinzenz Feenstra has submitted this change and it was merged. Change subject: Version bump to 1.0.13 for ovirt 4.1 ...................................................................... Version bump to 1.0.13 for ovirt 4.1 Change-Id: I053ddf7653692b2d739e56802fa2985e74081277 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ChangeLog M configure.ac M debian/changelog M debian/copyright M ovirt-guest-agent-windows.spec M ovirt-guest-agent.rhel6.spec M ovirt-guest-agent.spec 7 files changed, 253 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved Marek Libra: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/67867 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I053ddf7653692b2d739e56802fa2985e74081277 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: log vm detection on unexpected host
by Code Review 06 Dec '16

06 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: log vm detection on unexpected host ...................................................................... core: log vm detection on unexpected host Change-Id: Ie3420289fd5adc6056983d1c08c2f8576ce7c40f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 17 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/67862 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3420289fd5adc6056983d1c08c2f8576ce7c40f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0