Change in ovirt-engine[master]: core: UpdateDiskCommandTest long literals
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: UpdateDiskCommandTest long literals
......................................................................
core: UpdateDiskCommandTest long literals
Use long literals instead of implicitly promoting ints to longs to make
the test more explicit and easier to follow.
Change-Id: I32d933d7093b8eead3896e8eb1c13d8fa15dcdf0
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/67966
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32d933d7093b8eead3896e8eb1c13d8fa15dcdf0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: AddDiskCommandTest: don't mock getQuotaManager()
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: AddDiskCommandTest: don't mock getQuotaManager()
......................................................................
core: AddDiskCommandTest: don't mock getQuotaManager()
The QuotaManager is injected by the test, there's no need to explicitly
mock its getter.
Change-Id: Icb5a0ed292450c52551f2100f8ceaa0d47b7628f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/67923
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb5a0ed292450c52551f2100f8ceaa0d47b7628f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: AddDiskCommandTest create image methods
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: AddDiskCommandTest create image methods
......................................................................
core: AddDiskCommandTest create image methods
Most of the image creating methods did nothing more than call a single
setter, offering no benefit over just calling this setter.
The overloaded method that received a size even added confusion as in
most cases this size was completely arbitrary, and had no effect on the
test.
This patch cleans up the test by removing these useless methods and
calling DiskImage's setters directly.
Change-Id: I7cb3a7cb4a0202d17622698ce2d8c206b570470a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java
1 file changed, 19 insertions(+), 39 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/67922
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7cb3a7cb4a0202d17622698ce2d8c206b570470a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: AddDiskCommandTest storage domain size mocking
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: AddDiskCommandTest storage domain size mocking
......................................................................
core: AddDiskCommandTest storage domain size mocking
The AddDiskCommand does not handle the free space validations directly
(it uses a StorageDomainValidator instance instead). Thus, its test
should not care about free and used space in the mocked StorageDomain
object.
This patch removes these mockings and makes the test clearer and easier
to understand and navigate.
Change-Id: I901e3a342e252121c085d7834aed0b708fb4bace
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java
1 file changed, 1 insertion(+), 9 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/67921
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I901e3a342e252121c085d7834aed0b708fb4bace
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: AddDiskCommandTest long literals
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: AddDiskCommandTest long literals
......................................................................
core: AddDiskCommandTest long literals
Use long literals instead of implicitly promoting ints to longs to make
the test more explicit and easier to follow.
Change-Id: Ia38548138610539a3065ad2533ec576598f2ce74
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/67920
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia38548138610539a3065ad2533ec576598f2ce74
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: AddDiskCommandTest: Remove MAX_DISK_SIZE constant
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: AddDiskCommandTest: Remove MAX_DISK_SIZE constant
......................................................................
core: AddDiskCommandTest: Remove MAX_DISK_SIZE constant
This constant should mimic the value of the
MaxDiskBlockSize config value.
This patch cleans up the mocking and uses it explicitly to make the test
more straight forward.
Change-Id: I53624b0ddfffd737370fc62ea969ca03f43a82bf
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java
1 file changed, 4 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/67919
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53624b0ddfffd737370fc62ea969ca03f43a82bf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: webadmin: Autoset VM hostname in RunOnce dialog
by Code Review
>From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Autoset VM hostname in RunOnce dialog
......................................................................
webadmin: Autoset VM hostname in RunOnce dialog
VMInit hostname is automatically populated by vm_name
when CloudInit/SysPrep is enabled in the RunOnce dialog.
Change-Id: Ied32360f0665229ddd1ce5bd49a2ac3c8c089edc
Bug-Url: https://bugzilla.redhat.com/1360983
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
2 files changed, 18 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Marek Libra: Verified
--
To view, visit https://gerrit.ovirt.org/63383
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied32360f0665229ddd1ce5bd49a2ac3c8c089edc
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: webadmin: Chaning default cluster attachment for external ne...
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Chaning default cluster attachment for external networks
......................................................................
webadmin: Chaning default cluster attachment for external networks
Until now the external networks were by default not attached to any cluster
when creating, nor was it possible to attach it.
This was very confusing for users.
This patch changes this, attaching an external network to all clusters,
when an external network is created.
It is now also possible to attach/unattach the network from/to clusters.
Enabling attaching/unattaching is important as not all the clusters
could be configured for a given external network.
The 'required' attribute for a network on a cluster stays disabled for
the external network, as an external network can not be a required network.
Whenever a change to the external status changes, we need to set all the
cluster's isAttached values again, in case the user has modified any of
them.
Change-Id: Ic335c4f5bf53da5ce0c3dd48b5e807950a801c16
Bug-Url: https://bugzilla.redhat.com/1373477
Bug-Url: https://bugzilla.redhat.com/1383449
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67877
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic335c4f5bf53da5ce0c3dd48b5e807950a801c16
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: webadmin: add background cache update to dashboard data servlet
by Code Review
>From Greg Sheremeta <gshereme(a)redhat.com>:
Greg Sheremeta has submitted this change and it was merged.
Change subject: webadmin: add background cache update to dashboard data servlet
......................................................................
webadmin: add background cache update to dashboard data servlet
Using JSR-236 JavaEE 7 Concurrency APIs, setup two background
tasks that will query the engine and DWH databases as needed
to satisfy DashboardDataServlet data requirements. The tasks
are scheduled at periodic intervals based on their cache
lifespan intervals.
This will also warm up the cache at start up time so the first
user to load dashboard data does not need to incur first
query penalties.
Configuration options have been added to ovirt-engine.conf to:
- enable/disable the background cache update
- control the interval between updates for the inventory cache
- control the interval between updates for the utilization cache
Change-Id: I2bb9e41835759e4c16aec801801e7f9149977b40
Bug-Url: https://bugzilla.redhat.com/1344428
Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com>
---
M ear/src/main/application/META-INF/jboss-deployment-structure.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/DashboardDataServlet.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/fake/FakeDataGenerator.java
M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml
M packaging/services/ovirt-engine/ovirt-engine.conf.in
M packaging/services/ovirt-engine/ovirt-engine.xml.in
M pom.xml
8 files changed, 251 insertions(+), 54 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Scott Dickerson: Verified
--
To view, visit https://gerrit.ovirt.org/67709
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2bb9e41835759e4c16aec801801e7f9149977b40
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: userportal, webadmin: remove Feedback link
by Code Review
>From Greg Sheremeta <gshereme(a)redhat.com>:
Greg Sheremeta has submitted this change and it was merged.
Change subject: userportal, webadmin: remove Feedback link
......................................................................
userportal, webadmin: remove Feedback link
removed dead Feedback link from header
Change-Id: I62ed45ce6fba88b8413b6ef6757b5a908909c2fb
Bug-Url: https://bugzilla.redhat.com/1349877
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/BaseDynamicMessages.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DynamicMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationDynamicMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.ui.xml
M packaging/branding/ovirt.brand/messages.properties
7 files changed, 0 insertions(+), 93 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/67617
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62ed45ce6fba88b8413b6ef6757b5a908909c2fb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years