March 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: UpdateClusterCommandTest collections
by amureini＠redhat.com 21 Mar '16

21 Mar '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateClusterCommandTest collections ...................................................................... core: UpdateClusterCommandTest collections Use the proper unmodifiable collections from java.util.Collections to reduce boiler-plating and improve performance. Change-Id: Ib3f93387c79fd3fc34a519c353f2dfb5cf6693fa Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Shmuel Leib Melamud: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3f93387c79fd3fc34a519c353f2dfb5cf6693fa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Enabled editing HE in pre-upgrade script
by rgolan＠redhat.com 21 Mar '16

21 Mar '16

Roy Golan has submitted this change and it was merged. Change subject: engine: Enabled editing HE in pre-upgrade script ...................................................................... engine: Enabled editing HE in pre-upgrade script Set the 'AllowEditingHostedEngine' update configuration value to true, as the feature is now supported. Change-Id: I2b69fd8a29815b9e4a468440093c3c6d286258b2 Bug-Url: https://bugzilla.redhat.com/1290478 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/54844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b69fd8a29815b9e4a468440093c3c6d286258b2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: align pom and spec ovirt-host-deploy
by sbonazzo＠redhat.com 21 Mar '16

21 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: align pom and spec ovirt-host-deploy ...................................................................... packaging: align pom and spec ovirt-host-deploy Aligned ovirt-host-deploy version required within the pom.xml file with the one required by the spec file. Change-Id: I219d260423c679fd867d537aba3568822772fc76 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I219d260423c679fd867d537aba3568822772fc76 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: automation: don't require repos on el6
by vfeenstr＠redhat.com 21 Mar '16

21 Mar '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: automation: don't require repos on el6 ...................................................................... automation: don't require repos on el6 Change-Id: I8f5bfca573106aa31f30d8959d5fb61666697b38 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A automation/build-artifacts.repos.el6 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified Jenkins CI: Passed CI tests Vinzenz Feenstra: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f5bfca573106aa31f30d8959d5fb61666697b38 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Added VmActionByVmOriginTypeValidator for Allowed Cmds
by ahadas＠redhat.com 21 Mar '16

21 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: engine: Added VmActionByVmOriginTypeValidator for Allowed Cmds ...................................................................... engine: Added VmActionByVmOriginTypeValidator for Allowed Cmds Refactoring of VmHandler. The COMMANDS_ALLOWED_ON_ moved from VmHandler to new VmActionByVmOriginTypeValidator, so they can be reused in UI. Change-Id: Iaf4fc340dd3b2ffdfa243f4f98307e255dee7651 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VmActionByVmOriginTypeValidator.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 3 files changed, 42 insertions(+), 23 deletions(-) Approvals: Marek Libra: Verified Arik Hadas: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/54870 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf4fc340dd3b2ffdfa243f4f98307e255dee7651 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: graphics of template were not available in user portal
by tjelinek＠redhat.com 21 Mar '16

21 Mar '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: graphics of template were not available in user portal ...................................................................... core: graphics of template were not available in user portal The problem was that in user portal (filter: true) the GetGraphicsDevicesQuery called the getVmDeviceByVmIdTypeAndDevice which cares takes into account only the VM permissions, not the template ones. Change-Id: I197748d44f5eb50a3e81b3b5924898770fbbcb8c Bug-Url: https://bugzilla.redhat.com/1315886 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M packaging/dbscripts/vm_device_sp.sql 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I197748d44f5eb50a3e81b3b5924898770fbbcb8c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.4]: core: Avoid errors when applying NEXT_RUN snapshot
by tnisan＠redhat.com 21 Mar '16

21 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Avoid errors when applying NEXT_RUN snapshot ...................................................................... core: Avoid errors when applying NEXT_RUN snapshot * Ignore changes in clusterCompatibilityVersionOrigin. It is not stored in OVF, so will never be changed when a snapshot is applied. * Do not check CPU Profile changing permissons, if cpuProfileId is not changed. Current user is null in ProcessDownVmCommand, so this permission check will always fail. But cpuProfileId is not stored in OVF, so will never be changed when a snapshot is applied and there is no need to check permissions. Change-Id: Ia2fd9ca872ab1c438d5f02a98c55ab91991cb11a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1313369 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54965 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2fd9ca872ab1c438d5f02a98c55ab91991cb11a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.4 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: The glusterfs key was changed to rsa
by sbonazzo＠redhat.com 21 Mar '16

21 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: The glusterfs key was changed to rsa ...................................................................... The glusterfs key was changed to rsa https://download.gluster.org/pub/gluster/glusterfs/LATEST/NEW_PUBLIC_KEY.RE… Change-Id: If34c154f955dae83b16a69b1e2fedaab62f21c2f Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M ovirt-el7-deps.repo.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If34c154f955dae83b16a69b1e2fedaab62f21c2f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Avoid errors when applying NEXT_RUN snapshot
by tnisan＠redhat.com 21 Mar '16

21 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Avoid errors when applying NEXT_RUN snapshot ...................................................................... core: Avoid errors when applying NEXT_RUN snapshot * Ignore changes in clusterCompatibilityVersionOrigin. It is not stored in OVF, so will never be changed when a snapshot is applied. * Do not check CPU Profile changing permissons, if cpuProfileId is not changed. Current user is null in ProcessDownVmCommand, so this permission check will always fail. But cpuProfileId is not stored in OVF, so will never be changed when a snapshot is applied and there is no need to check permissions. Change-Id: Ia2fd9ca872ab1c438d5f02a98c55ab91991cb11a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1313369 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified -- To view, visit https://gerrit.ovirt.org/54964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2fd9ca872ab1c438d5f02a98c55ab91991cb11a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Call end action once CopyTaskHandler is finished.
by tnisan＠redhat.com 21 Mar '16

21 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Call end action once CopyTaskHandler is finished. ...................................................................... core: Call end action once CopyTaskHandler is finished. Call end successfully once glance image if finished to be imported so actual size will be updated properly. Change-Id: I44343b1f49d099fc6febd3907066a35f22ef3a4f Bug-Url: https://bugzilla.redhat.com/1291080 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/54974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44343b1f49d099fc6febd3907066a35f22ef3a4f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0