March 2016 - Engine-commits - oVirt List Archives

Change in ovirt-release[ovirt-3.6]: The glusterfs key was changed to rsa
by sbonazzo＠redhat.com 22 Mar '16

22 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: The glusterfs key was changed to rsa ...................................................................... The glusterfs key was changed to rsa Also for el6 and fc22. Change-Id: I903a6dc05232da496bfbb281d27124a862b4cfa0 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-el6-deps.repo.in M ovirt-f22-deps.repo.in 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I903a6dc05232da496bfbb281d27124a862b4cfa0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-3.6]: The glusterfs key was changed to rsa
by sbonazzo＠redhat.com 22 Mar '16

22 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: The glusterfs key was changed to rsa ...................................................................... The glusterfs key was changed to rsa https://download.gluster.org/pub/gluster/glusterfs/LATEST/NEW_PUBLIC_KEY.RE… Change-Id: If34c154f955dae83b16a69b1e2fedaab62f21c2f Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M ovirt-el7-deps.repo.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Anatoly Litovsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If34c154f955dae83b16a69b1e2fedaab62f21c2f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-guest-agent: add check patch to 3.6 branch
by sbonazzo＠redhat.com 22 Mar '16

22 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-guest-agent: add check patch to 3.6 branch ...................................................................... ovirt-guest-agent: add check patch to 3.6 branch Change-Id: I405b924c0dc9ca30539bc5e294e113459cde87b5 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-guest-agent/ovirt-guest-agent_standard.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I405b924c0dc9ca30539bc5e294e113459cde87b5 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: reuse of existingAttachments data memeber
by alkaplan＠redhat.com 22 Mar '16

22 Mar '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: reuse of existingAttachments data memeber ...................................................................... engine: reuse of existingAttachments data memeber In the begining of the 'HostSetupNetwork.validate()' there is completion of the 'existingAttachments' data member and the 'parameters' of the command. Therefore, if two attachments are the same (existing and the one in the parameters), the comparison will be able to detact it. However, if when doing the comparison new version of the existing attachments is used (fetch new version from the db), the comparison will fails, since the exisiting attachments may have missing data (that the completaion should fix). Change-Id: I33cbf93c00c0e0dd9bab9c218b6472a4a4723c11 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54838 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33cbf93c00c0e0dd9bab9c218b6472a4a4723c11 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: GetNetworkAttachmentsByHostId should return nic/netw...
by alkaplan＠redhat.com 22 Mar '16

22 Mar '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: GetNetworkAttachmentsByHostId should return nic/network names ...................................................................... engine: GetNetworkAttachmentsByHostId should return nic/network names The attachments returned from this query should contain not only nicId and networkId but nicName and networkName as well. Change-Id: I79b7a96335291606d9083b71a70d798732b02379 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetNetworkAttachmentsByHostIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/ReportedConfigurationsFiller.java 2 files changed, 54 insertions(+), 7 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79b7a96335291606d9083b71a70d798732b02379 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: move isVlan and stripVlan to NetworkCommonUtils
by alkaplan＠redhat.com 22 Mar '16

22 Mar '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: move isVlan and stripVlan to NetworkCommonUtils ...................................................................... engine: move isVlan and stripVlan to NetworkCommonUtils So ui can use it as well. Change-Id: I819c652a4f605a37fc551cbd04ccd3cbf696c269 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworksByLabelParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetInterfacesByLabelForNetworkQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllChildVlanInterfacesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllSiblingVlanInterfacesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVlanParentQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelperImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NicLabelValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RemoveBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UnmanagedNetworkValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostInterfaceValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/NetworkCommonUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CalculateBaseNic.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/HostMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/NetworkMonitoringHelper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 27 files changed, 89 insertions(+), 70 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I819c652a4f605a37fc551cbd04ccd3cbf696c269 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: move ipConfiguration utils to NetworkCommonUtils
by alkaplan＠redhat.com 22 Mar '16

22 Mar '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: move ipConfiguration utils to NetworkCommonUtils ...................................................................... engine: move ipConfiguration utils to NetworkCommonUtils So that ui can use it. Change-Id: I86353328c31688518a176e33d681a50a6fcf804b Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/HostSetupNetworksParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NicLabelsCompleter.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/NetworkCommonUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersisterTest.java 8 files changed, 55 insertions(+), 50 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86353328c31688518a176e33d681a50a6fcf804b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: NetworkInterface model should store only PF name
by alkaplan＠redhat.com 22 Mar '16

22 Mar '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: NetworkInterface model should store only PF name ...................................................................... webadmin: NetworkInterface model should store only PF name There is no need to store the whole VdsNetworkinterface of the PF. Change-Id: I8c9ca38ef461e0d3a7fd15aa98398cf9bc6ed00e Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkInterfaceModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c9ca38ef461e0d3a7fd15aa98398cf9bc6ed00e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: userportal: added data-status attr for automation
by tnisan＠redhat.com 21 Mar '16

21 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal: added data-status attr for automation ...................................................................... userportal: added data-status attr for automation Added a 'data-status' attribute to VM Status columns in userportal. This will allow automation / selenium / etc. to easily access the state of the VM. Change-Id: Ic4ab4ac7d9243414645dfb6f3ed895916b5a204b Bug-Url: https://bugzilla.redhat.com/1273970 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ImageWithDecorator.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/DecoratedImageResourceCell.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/VmStatusColumn.java 3 files changed, 25 insertions(+), 7 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/54947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4ab4ac7d9243414645dfb6f3ed895916b5a204b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: userportal, webadmin: fix vm status tooltip w/ alerts
by tnisan＠redhat.com 21 Mar '16

21 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal, webadmin: fix vm status tooltip w/ alerts ...................................................................... userportal, webadmin: fix vm status tooltip w/ alerts When an alert status icon was showing alongside the vm status icon, no indication of the alert was shown in the tooltip. Fixed. Change-Id: Ibc9d2e7a50eb938859e8eeeaaac536daacc897f7 Bug-Url: https://bugzilla.redhat.com/1304729 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VmStatusCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusColumn.java 2 files changed, 73 insertions(+), 64 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/54943 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc9d2e7a50eb938859e8eeeaaac536daacc897f7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0