March 2016 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: userportal, webadmin: fix external links

by awels＠redhat.com

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: fix external links ...................................................................... userportal,webadmin: fix external links - With the new wiki the urls of a bunch of links changed this patch fixes the links to point to valid locations again. Change-Id: I2cce161035329ea20f570fffe13f2ff9206fe976 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1312880 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M packaging/branding/ovirt.brand/external_resources.properties 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cce161035329ea20f570fffe13f2ff9206fe976 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: ObjectIdentityChecker: Exclude transient fields from...

by ahadas＠redhat.com

Arik Hadas has submitted this change and it was merged. Change subject: engine: ObjectIdentityChecker: Exclude transient fields from comparison ...................................................................... engine: ObjectIdentityChecker: Exclude transient fields from comparison Added new TransientField annotation to mark fields that are not stored in the DB so their values should be ignored when comparing objects with ObjectIdentityChecker. Change-Id: I9ac3388bd2c89c57d69d1766f9fb1c79f635452b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1238742 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TransientField.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java 4 files changed, 38 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ac3388bd2c89c57d69d1766f9fb1c79f635452b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Leave cpuProfileId untouched after reading a snapshot

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: engine: Leave cpuProfileId untouched after reading a snapshot ...................................................................... engine: Leave cpuProfileId untouched after reading a snapshot cpuProfileId is not stored in OVF, so after reading a snapshot it must be left untouched, not set to null. Change-Id: I5c2fcf0b7a5d1eeaf9bd07b99aaa748f30dc51d7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1238742 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c2fcf0b7a5d1eeaf9bd07b99aaa748f30dc51d7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Fixed missing cloud_init mapping

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fixed missing cloud_init mapping ...................................................................... restapi: Fixed missing cloud_init mapping Fixed missing mapping of the <cloud_init> element (child of the <initialization>) within "start VM" REST API action. Change-Id: I985608a21f66312864b9ccf69dc1869eaff72b5f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1305904 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/54265 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I985608a21f66312864b9ccf69dc1869eaff72b5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: Fixed missing cloud_init mapping

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fixed missing cloud_init mapping ...................................................................... restapi: Fixed missing cloud_init mapping Fixed missing mapping of the <cloud_init> element (child of the <initialization>) within "start VM" REST API action. Change-Id: I985608a21f66312864b9ccf69dc1869eaff72b5f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1305904 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/InitializationMapper.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/54258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I985608a21f66312864b9ccf69dc1869eaff72b5f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-hosted-engine-setup[master]: --vm-status: Show global maintenance also in the end

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: --vm-status: Show global maintenance also in the end ...................................................................... --vm-status: Show global maintenance also in the end So it's easier to notice even if you have many hosts. Change-Id: I3baa5fb9aebc36e876e0ddeffcd13ed00d780800 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/ovirt_hosted_engine_setup/vm_status.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/54249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3baa5fb9aebc36e876e0ddeffcd13ed00d780800 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Always persist changes to hosted-engine VM (avoid usin...

by rgolan＠redhat.com

Roy Golan has submitted this change and it was merged. Change subject: core: Always persist changes to hosted-engine VM (avoid using NEXT_RUN) ...................................................................... core: Always persist changes to hosted-engine VM (avoid using NEXT_RUN) Engine VM can't use the Next-Run configuration features using the snapshots as its config must be saved ad hoc whenever there is a change. Hot plug support remains untouched and we should benefit from it with no change. This patch also prevents editing an unmanaged hosted engine VM. Change-Id: I5fb7650b37b792c4717492e8ed08c5dd178861cd Bug-Url: https://bugzilla.redhat.com/1290478 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 22 insertions(+), 8 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51219 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fb7650b37b792c4717492e8ed08c5dd178861cd Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Remove index from curly braces

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove index from curly braces ...................................................................... core: Remove index from curly braces This patch removes the index in curley braces. Change-Id: Ic4409c84faa0c10ec60f0716063c2abc62f23e84 Bug-Url: https://bugzilla.redhat.com/1309294 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/54136 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4409c84faa0c10ec60f0716063c2abc62f23e84 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Handle exception if calling VDSM fails

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Handle exception if calling VDSM fails ...................................................................... core: Handle exception if calling VDSM fails When updating image data, we call VDSM to get image info. If this call fails, the flow breaks and potentially leaving database with incorrect data. This patch handles exception thrown when calling VDSM. Change-Id: Ia1aa477555cfb624724a5cc948120ea113f3f6ff Bug-Url: https://bugzilla.redhat.com/1309294 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommandBase.java 1 file changed, 14 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Passed CI tests Greg Padgett: Looks good to me, but someone else must approve Ala Hino: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1aa477555cfb624724a5cc948120ea113f3f6ff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Move getImageInfo call outside of transaction boundary

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Move getImageInfo call outside of transaction boundary ...................................................................... core: Move getImageInfo call outside of transaction boundary Currently, when syncing db records, we call vdsm to get volume info. This call is performed inside db transaction which could lead to failure regardless of the db performance. This could happen if storage is slow or network connection is slow. To fix this behavior, the call to vdsm moved outside of the transaction. This patch will simplify fixing the related bug. Change-Id: Ifac1ab925afd448d149fecc286d361a797c9d57b Bug-Url: https://bugzilla.redhat.com/1309294 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 3 files changed, 22 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Passed CI tests Greg Padgett: Looks good to me, but someone else must approve Ala Hino: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54134 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifac1ab925afd448d149fecc286d361a797c9d57b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 10 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits March 2016