April 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: dashboard: Code improvements
by awels＠redhat.com 29 Apr '16

29 Apr '16

Alexander Wels has submitted this change and it was merged. Change subject: dashboard: Code improvements ...................................................................... dashboard: Code improvements 1. use base class (BaseDAO) to reduce code duplication 2. use DashboardDataException to cover all dashboard data related errors (don't mix with SQLException, wrap that one instead, for consistent "throws" error signature) 3. add serialVersionUID into DashboardDataException Change-Id: I2e94adff5060189afe81c5f02de5fd4565e7941a Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/DashboardDataException.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/DashboardDataServlet.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/EventHelper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/HeatMapHelper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/HourlySummaryHelper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/InventoryHelper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/UtilizationHelper.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/BaseDao.java D frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/ClusterDwhDAO.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/ClusterDwhDao.java D frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/ClusterEngineDAO.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/ClusterEngineDao.java D frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/DataCenterDAO.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/DataCenterDao.java D frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/EventDAO.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/EventDao.java D frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/HostDwhDAO.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/HostDwhDao.java D frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/HostEngineDAO.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/HostEngineDao.java D frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/StorageDomainDwhDAO.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/StorageDomainDwhDao.java D frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/StorageDomainEngineDAO.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/StorageDomainEngineDao.java D frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/VmDwhDAO.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/VmDwhDao.java D frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/VmEngineDAO.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/dao/VmEngineDao.java 28 files changed, 863 insertions(+), 948 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/56644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e94adff5060189afe81c5f02de5fd4565e7941a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Improve the documentation of services
by juan.hernandez＠redhat.com 29 Apr '16

29 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Improve the documentation of services ...................................................................... Improve the documentation of services This patch improves the documentation of the generated services, extracting the documentation from the model when it is available. Change-Id: I42087ab69abc9a0295499ec8514c1a516cc2ac1f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/RubyBuffer.java M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java M sdk/lib/ovirtsdk4.rb M sdk/lib/ovirtsdk4/http.rb M sdk/lib/ovirtsdk4/reader.rb M sdk/lib/ovirtsdk4/service.rb M sdk/lib/ovirtsdk4/type.rb M sdk/lib/ovirtsdk4/writer.rb 9 files changed, 318 insertions(+), 160 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56827 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42087ab69abc9a0295499ec8514c1a516cc2ac1f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: pki: avoid trusting system defined CA certs
by stirabos＠redhat.com 29 Apr '16

29 Apr '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: pki: avoid trusting system defined CA certs ...................................................................... pki: avoid trusting system defined CA certs ssl.create_default_context() loads by default also the system defined CA certs and so hosted-engine-setup can securely download the internal CA cert and the pubblic SSH key from the engine also if the user replaced the internally signed apache cert with one signed by a system trusted CA. On the other side, python SDK will ignore them and so, to behave consistently, it's better to ignore also here till we get the capability to trust system trusted CA certs also in python SDK. Change-Id: I33601d66f88c9cae999341c40c460be202efa4a3 Bug-Url: https://bugzilla.redhat.com/1321381 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/ohttpshandler.py 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33601d66f88c9cae999341c40c460be202efa4a3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: pki: avoid trusting system defined CA certs
by stirabos＠redhat.com 29 Apr '16

29 Apr '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: pki: avoid trusting system defined CA certs ...................................................................... pki: avoid trusting system defined CA certs ssl.create_default_context() loads by default also the system defined CA certs and so hosted-engine-setup can securely download the internal CA cert and the pubblic SSH key from the engine also if the user replaced the internally signed apache cert with one signed by a system trusted CA. On the other side, python SDK will ignore them and so, to behave consistently, it's better to ignore also here till we get the capability to trust system trusted CA certs also in python SDK. Change-Id: I33601d66f88c9cae999341c40c460be202efa4a3 Bug-Url: https://bugzilla.redhat.com/1321381 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/ohttpshandler.py 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33601d66f88c9cae999341c40c460be202efa4a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine_upgrade-engine: allow multiple jobs
by sbonazzo＠redhat.com 29 Apr '16

29 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine_upgrade-engine: allow multiple jobs ...................................................................... ovirt-engine_upgrade-engine: allow multiple jobs Override default properties in order to allow to run multiple ovirt-engine_upgrade-engine jobs in parallel. Change-Id: Ia057208e77415d6cd2be965a82d4a7c7565023c2 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/templates/engine-upgrade.yaml 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56835 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia057208e77415d6cd2be965a82d4a7c7565023c2 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Release 4.0.0.a1
by juan.hernandez＠redhat.com 29 Apr '16

29 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Release 4.0.0.a1 ...................................................................... Release 4.0.0.a1 Change-Id: Ia0410391141fcdb56f223960851eef4bb8f53623 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M packaging/build.sh M sdk/lib/ovirtsdk4/version.py M sdk/setup.py 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56808 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0410391141fcdb56f223960851eef4bb8f53623 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: resatpi: Collections#singletonList in tests
by juan.hernandez＠redhat.com 29 Apr '16

29 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: resatpi: Collections#singletonList in tests ...................................................................... resatpi: Collections#singletonList in tests Use Collections#singletonList, which performs slightly better than Arrays#asList. Change-Id: I4444e0f58f5c7bda6d985b81d5a7c522f3ff80a0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesBasedResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmHostDeviceResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmHostDevicesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/GlusterTestHelper.java 10 files changed, 19 insertions(+), 20 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/56790 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4444e0f58f5c7bda6d985b81d5a7c522f3ff80a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Copying array to collection
by juan.hernandez＠redhat.com 29 Apr '16

29 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Copying array to collection ...................................................................... restapi: Copying array to collection Use addAll(Arrays.asList(GUIDs) instead of manually looping over the GUIDs. If nothing else, it's easier to read, and it may have a slight performance benefit. Change-Id: Ia980bcbdb30d45aa577f559710883e45f8496c7b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskResourceTest.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/56792 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia980bcbdb30d45aa577f559710883e45f8496c7b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-3.6]: node: use default zone for firewalld services
by sbonazzo＠redhat.com 29 Apr '16

29 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: use default zone for firewalld services ...................................................................... node: use default zone for firewalld services In the past we ship a zone but it's not recommended as others daemons might also add their own zones. It's recommended to use the current zone and simplify the firewalld schema. Change-Id: Ib46992eb866f3b3dc6e4d4e4274fb86a810f4cc7 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M host-node/Makefile.am D host-node/firewalld/zones/ovirthostnode.xml M ovirt-release36.spec.in 3 files changed, 9 insertions(+), 32 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56812 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib46992eb866f3b3dc6e4d4e4274fb86a810f4cc7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: node: use default zone for firewalld services
by sbonazzo＠redhat.com 29 Apr '16

29 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: use default zone for firewalld services ...................................................................... node: use default zone for firewalld services In the past we ship a zone but it's not recommended as others daemons might also add their own zones. It's recommended to use the current zone and simplify the firewalld schema. Change-Id: Ib46992eb866f3b3dc6e4d4e4274fb86a810f4cc7 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M host-node/Makefile.am D host-node/firewalld/zones/ovirthostnode.xml M ovirt-release40.spec.in 3 files changed, 9 insertions(+), 32 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib46992eb866f3b3dc6e4d4e4274fb86a810f4cc7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0