Change in ovirt-engine[master]: scheduler: Store correct OS version in map
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: scheduler: Store correct OS version in map
......................................................................
scheduler: Store correct OS version in map
Write the new version into the highest version map.
Change-Id: I9594f2f8f8c5d9c7fbeba7b6aff3a77cdc533d14
Bug-Url: https://bugzilla.redhat.com/1241149
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/InClusterUpgradeWeightPolicyUnit.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/InClusterUpgradeWeightPolicyUnitTest.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Martin Sivák: Looks good to me, but someone else must approve
Roman Mohr: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55565
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9594f2f8f8c5d9c7fbeba7b6aff3a77cdc533d14
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: engine: don't allow removal of inherited perms via rest
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: engine: don't allow removal of inherited perms via rest
......................................................................
engine: don't allow removal of inherited perms via rest
Previously it was possible to remove inherited permissions from user/group
via rest api call. Now we do check at backend if user is trying to remove
inherited permissions from user/group and if yes we do not allow it.
Change-Id: Ica8610e4cf613629c0fbc0a8d7414598a8bbd899
Bug-Url: https://bugzilla.redhat.com/1302034
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PermissionsOperationsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResourceTest.java
7 files changed, 33 insertions(+), 3 deletions(-)
Approvals:
Ondra Machacek: Verified
Martin Peřina: Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55107
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica8610e4cf613629c0fbc0a8d7414598a8bbd899
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine-sdk[master]: Fix name of method to close element
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Fix name of method to close element
......................................................................
Fix name of method to close element
Currently the code generated for XML writers uses in some cases the
"XmlWriter.end_element" method, but that method doesn't exist, it should
be "write_end". This patch corrects the error.
Change-Id: I00a4406ea2bda1b93025d8f3e59837f2990f0466
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55560
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I00a4406ea2bda1b93025d8f3e59837f2990f0466
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[ovirt-engine-3.6.5]: construct jsonrpc with identifier name.
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: construct jsonrpc with identifier name.
......................................................................
construct jsonrpc with identifier name.
this patch help to identifiy host by http connect header,
in order to support multiple access for same ip address,
specially for vdsmfake.
moving to use setter and getter instead of constrctors.
adding ConfigValue in order to control this.
deafualt is false.
update db configuratoin.
this patch depndes on https://gerrit.ovirt.org/#/c/39835/
Bug-Url: https://bugzilla.redhat.com/1317248
Change-Id: Ic423322de3f1e0d1862d147a3b529f5c047d8b02
Signed-off-by: emarcian <emarcian(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
3 files changed, 24 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Eldad Marciano: Verified
--
To view, visit https://gerrit.ovirt.org/55501
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic423322de3f1e0d1862d147a3b529f5c047d8b02
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.5
Gerrit-Owner: Eldad Marciano <emarcian(a)redhat.com>
Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[ovirt-engine-3.6]: HE: Enable hosted engine vNIC editing
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: HE: Enable hosted engine vNIC editing
......................................................................
HE: Enable hosted engine vNIC editing
This patch enabled vNIC management for the hosted engine VM,
But the management interface (ovirtmgmt) can't be deactivated
for the HE VM.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1319769
Change-Id: Ic85659ef7c036762afa64a43e7bda7e7d527f483
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VmActionByVmOriginTypeValidator.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 39 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Martin Sivák: Verified
Martin Mucha: Looks good to me, but someone else must approve
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55451
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic85659ef7c036762afa64a43e7bda7e7d527f483
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[ovirt-engine-3.6]: HE: Make the unmanaged hosted engine error a bit more generic
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: HE: Make the unmanaged hosted engine error a bit more generic
......................................................................
HE: Make the unmanaged hosted engine error a bit more generic
This updates the ACTION_TYPE_FAILED_UNMANAGED_HOSTED_ENGINE
error message to include the full action and type to make
it ready for more actions than just VM activation.
The message is changed from:
Cannot ${action} unmanaged hosted engine VM. Please upgrade the cluster
level to 3.6 and wait for the hosted engine storage domain to be
properly imported.
To:
Cannot ${action} ${type}. You are using an unmanaged hosted engine VM.
Please upgrade the cluster level to 3.6 and wait for the hosted engine
storage domain to be properly imported.
Change-Id: Ie3230c4b7a783d200df0da18cf8462a21aa0b54f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1319769
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Martin Sivák: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55422
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3230c4b7a783d200df0da18cf8462a21aa0b54f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years