Change in ovirt-engine[master]: core: Use SATA CD-ROM for q35 chipset
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Use SATA CD-ROM for q35 chipset
......................................................................
core: Use SATA CD-ROM for q35 chipset
Extended os.other.devices.cdInterface option syntax in osinfo properties
to be able to set different interface types (IDE, SCSI, SATA) for CD-ROM
device for different chipsets. Now this option contains comma-separated
list of interface types possibly prefixed with "<chipset name>/". The
value without prefix is used by default, if no other value is defined
for the chipset used by the VM.
Change-Id: I71ef92e9d096eeadb17e64bd37e17219a07155f2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1305900
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ChipsetType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
M backend/manager/modules/utils/src/main/javacc/org/ovirt/engine/core/utils/osinfo/osinfo.jj
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
M build/validations/src/test/java/org/ovirt/engine/build/validations/OsinfoValidationsTest.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M packaging/conf/osinfo-defaults.properties
9 files changed, 96 insertions(+), 22 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/56588
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71ef92e9d096eeadb17e64bd37e17219a07155f2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 12 months
Change in ovirt-engine[master]: core: Migration max bandwidth
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Migration max bandwidth
......................................................................
core: Migration max bandwidth
Computation of max bandwidth for migration based on Cluster properties
'migrationBandwidthLimitType', 'customMigrationNetworkBandwidth' and
MigrationPolicy#maxMigrations.
If limit type == AUTO and no QoS is set on migration network than the
bandwidth is estimated as minimum of link speeds of source and
destination NICs connected to the migration network.
In case of limit type == AUTO && cross-cluster migration, the bandwidth
is estimate as a minimum of estimations for each cluster.
Change-Id: I7840b44ab114ff7c8276287fe1b6c19864d3b39e
Bug-Url: https://bugzilla.redhat.com/1252426
Feature-Page: http://www.ovirt.org/Features/Migration_Enhancements
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ObjectUtils.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoImpl.java
M packaging/dbscripts/network_sp.sql
5 files changed, 98 insertions(+), 18 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55840
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7840b44ab114ff7c8276287fe1b6c19864d3b39e
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 12 months
Change in ovirt-engine[ovirt-engine-3.6]: build: post ovirt-engine-3.6.6 branching
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: build: post ovirt-engine-3.6.6 branching
......................................................................
build: post ovirt-engine-3.6.6 branching
bumped version to 3.6.7
Change-Id: I6a6730bff15fd691b7f950db568c397da63289b6
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M backend/manager/dependencies/common/pom.xml
M backend/manager/dependencies/pom.xml
M backend/manager/dependencies/tools/pom.xml
M backend/manager/extensions-tool/pom.xml
M backend/manager/modules/aaa/pom.xml
M backend/manager/modules/auth-plugin/pom.xml
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/branding/pom.xml
M backend/manager/modules/builtin-extensions/pom.xml
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M backend/manager/modules/dal/pom.xml
M backend/manager/modules/docs/pom.xml
M backend/manager/modules/extensions-manager/pom.xml
M backend/manager/modules/logger/pom.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
M backend/manager/modules/restapi/interface/common/pom.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/pom.xml
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/modules/restapi/pom.xml
M backend/manager/modules/restapi/types/pom.xml
M backend/manager/modules/restapi/webapp/pom.xml
M backend/manager/modules/root/pom.xml
M backend/manager/modules/scheduler/pom.xml
M backend/manager/modules/searchbackend/pom.xml
M backend/manager/modules/services/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/uutils/pom.xml
M backend/manager/modules/vdsbroker/pom.xml
M backend/manager/modules/welcome/pom.xml
M backend/manager/pom.xml
M backend/manager/tools/pom.xml
M backend/pom.xml
M build-tools-root/checkstyles/pom.xml
M build-tools-root/jboss-modules-maven-plugin/pom.xml
M build-tools-root/ovirt-checkstyle-extension/pom.xml
M build-tools-root/pom.xml
M build/validations/pom.xml
M ear/pom.xml
M frontend/pom.xml
M frontend/webadmin/modules/frontend-symbols/pom.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/uicompat/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M frontend/webadmin/pom.xml
M mavenmake/pom.xml
M pom.xml
M version.mak
55 files changed, 55 insertions(+), 55 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/56915
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a6730bff15fd691b7f950db568c397da63289b6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 12 months
Change in ovirt-engine[master]: core: fix findbug issue
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix findbug issue
......................................................................
core: fix findbug issue
Change inner class that doesn't use its embedded reference
to the object which created it to static.
Change-Id: I3e071f555b4a6f5e8bceaebf1ff1d9dd859ef08f
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkFilterDaoImpl.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/56918
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e071f555b4a6f5e8bceaebf1ff1d9dd859ef08f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 12 months
Change in ovirt-engine[master]: core: Fix of active_migration_network_interface view
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Fix of active_migration_network_interface view
......................................................................
core: Fix of active_migration_network_interface view
The view is used to get link speed of interfaces to compute suitable
migration bandwidth.
Previously the view took into account all migrational host interfaces
of all hosts. This patch fixes it to show only interfaces in state "Up"
of hosts in states "Up" and "PreparingForMaintenance", i.e. states
that allow host to be involved in migration.
Change-Id: I4e1b26145dd64e14b70ce433b28de4db5e82759c
Bug-Url: https://bugzilla.redhat.com/1252426
Feature-Page: http://www.ovirt.org/Features/Migration_Enhancements
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/network_sp.sql
2 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/56844
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e1b26145dd64e14b70ce433b28de4db5e82759c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 12 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: storage: correctly evaluate glusterfs SD canonical path
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: storage: correctly evaluate glusterfs SD canonical path
......................................................................
storage: correctly evaluate glusterfs SD canonical path
In the past we let the user specify a path for file based
(NFS or gluster) storage domains which includes a trailing '/'.
This caused other issues (double mount point when the engine
import it) and so we had a patch to evaluate the canonical path
and eventually fix the mount point in the configuration file
before trying again to connect it. Due to a bug in the evaluation
of the canonical path for gluster volumes, it was looping forever
on gluster deployed systems.
Improoving the the logging to make it more evident.
Change-Id: Ic7a877bb4386214044cf85de18f99b1b443222eb
Bug-Url: https://bugzilla.redhat.com/1327516
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/env/constants.py.in
M ovirt_hosted_engine_ha/env/path.py
M ovirt_hosted_engine_ha/lib/storage_server.py
3 files changed, 34 insertions(+), 17 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56797
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7a877bb4386214044cf85de18f99b1b443222eb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 12 months
Change in jenkins[master]: Publish version 3.6 of the CLI to the master repository
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Publish version 3.6 of the CLI to the master repository
......................................................................
Publish version 3.6 of the CLI to the master repository
There won't be a version 4 of the CLI, at least not for release 4.0 of
the project. This patch changes the master publisher job so that it
publishes version 3.6 of the CLI instead of the currently frozen master
branch.
Change-Id: Ie14fc06dacbc5d9ca18b4abdc6e5c809ebed6bd8
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Juan Hernandez: Ready for review
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56904
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie14fc06dacbc5d9ca18b4abdc6e5c809ebed6bd8
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 12 months
Change in ovirt-engine[master]: core: Fix NPE raised in ProviderDaoTest
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: Fix NPE raised in ProviderDaoTest
......................................................................
core: Fix NPE raised in ProviderDaoTest
Fixes NPE raised in ProviderDaoTest which was caused by commit
I24004be008c766478179084cb8e292b15a83b597.
Change-Id: Idcb521a801d1bafbbdc0b1172a3c627705e90912
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/provider/ProviderDaoTest.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Martin Peřina: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56902
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcb521a801d1bafbbdc0b1172a3c627705e90912
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 12 months
Change in ovirt-engine[master]: packaging: engine-backup: Fail nicely on unknown option
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: engine-backup: Fail nicely on unknown option
......................................................................
packaging: engine-backup: Fail nicely on unknown option
Change-Id: I96e0ee4d377aa72ae1dafd07e095f8a7baa0a004
Bug-Url: https://bugzilla.redhat.com/1329383
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/bin/engine-backup.sh.in
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/56872
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96e0ee4d377aa72ae1dafd07e095f8a7baa0a004
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 12 months
Change in ovirt-scheduler-proxy[master]: automation: fix el6 and fc22 check-patch
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: automation: fix el6 and fc22 check-patch
......................................................................
automation: fix el6 and fc22 check-patch
master branch is used for both 3.6 and 4.0.
In 4.0 el6 and fc22 are not supported anymore so for
testing this package on 3.6 we need 3.6 repos.
Change-Id: I92ac3977f231365905537b1130cda1e1b8de5979
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A automation/check-patch.repos.el6
A automation/check-patch.repos.fc22
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56832
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92ac3977f231365905537b1130cda1e1b8de5979
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-scheduler-proxy
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 12 months