May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Synched Cpu Pinning label and textbox
by tnisan＠redhat.com 02 May '16

02 May '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Synched Cpu Pinning label and textbox ...................................................................... webadmin: Synched Cpu Pinning label and textbox "Cpu Pinning Topology" label wasn't in sync with the availability of it's textbox. It was constantly greyed out(disabled) even when the textbox was enabled. This patch introduced synching with between the textbox and the label. Due to the blue tooltip between the label and the textbox it's impossible to use the combined label and textbox object. So, This patch is using listeners inorder to overcome this problem. Change-Id: I007814512506170699050a4cb82abfea2278c4d4 Bug-Url: https://bugzilla.redhat.com/1226767 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 2 files changed, 30 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Tomer Saban: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/56919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I007814512506170699050a4cb82abfea2278c4d4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: vdsbroker: check connection identifier during policy reset
by tnisan＠redhat.com 02 May '16

02 May '16

Tal Nisan has submitted this change and it was merged. Change subject: vdsbroker: check connection identifier during policy reset ...................................................................... vdsbroker: check connection identifier during policy reset We need to check whether we need to wait for the connection to disconnect during policy reset. We can based our decision of connection identifier. Change-Id: I58a1e7d4b3024be0be3f76e3dd4092003b1cdfe7 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1329317 --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 2 insertions(+), 9 deletions(-) Approvals: Piotr Kliczewski: Verified Tal Nisan: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56282 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58a1e7d4b3024be0be3f76e3dd4092003b1cdfe7 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: connect: update timeout
by tnisan＠redhat.com 02 May '16

02 May '16

Tal Nisan has submitted this change and it was merged. Change subject: connect: update timeout ...................................................................... connect: update timeout Change-Id: I74b3b2d6b21a9b174fcaf685c465e97a9511198e Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1329317 --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Tal Nisan: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74b3b2d6b21a9b174fcaf685c465e97a9511198e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: remove 'unsupported browser' warning
by tnisan＠redhat.com 02 May '16

02 May '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: remove 'unsupported browser' warning ...................................................................... webadmin: remove 'unsupported browser' warning Commit db95728 introduced a popup message in the webadmin header that warned people when their browser was "unsupported." However, we received many complaints that this message was simply confusing. Since we haven't have a browser compatibility issue in a very long time, we decided it was best to just remove the message. Change-Id: I2094c7640d4bda243e7b524f463962337398ab7f Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1326511 --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginFormView.java 1 file changed, 1 insertion(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2094c7640d4bda243e7b524f463962337398ab7f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin,userportal: Code cleanup
by vszocs＠redhat.com 02 May '16

02 May '16

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Code cleanup ...................................................................... webadmin,userportal: Code cleanup 1. removed unused InternalConfiguration class along with its GIN binding 2. added ClientAgentType.isFirefox method 3. updated code to use ClientAgentType.isIE and ClientAgentType.isFirefox methods instead of hard-coded string comparison Change-Id: Ie20290cefa9e7f18399b6a5db1a4882a540229f2 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/place/ApplicationPlaceManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/ClientAgentType.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/SystemModule.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/InternalConfiguration.java 5 files changed, 8 insertions(+), 106 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/56939 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie20290cefa9e7f18399b6a5db1a4882a540229f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: connect: update timeout
by mperina＠redhat.com 02 May '16

02 May '16

Martin Peřina has submitted this change and it was merged. Change subject: connect: update timeout ...................................................................... connect: update timeout Change-Id: I74b3b2d6b21a9b174fcaf685c465e97a9511198e Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Martin Peřina: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74b3b2d6b21a9b174fcaf685c465e97a9511198e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: jsonrpc: version bump
by tnisan＠redhat.com 02 May '16

02 May '16

Tal Nisan has submitted this change and it was merged. Change subject: jsonrpc: version bump ...................................................................... jsonrpc: version bump Change-Id: I6edc49f59d14dbc58508b46ef88314e98f355d7d Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1320128 Bug-Url: https://bugzilla.redhat.com/1329317 --- M ovirt-engine.spec.in M pom.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified Tal Nisan: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56649 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6edc49f59d14dbc58508b46ef88314e98f355d7d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: remove 'unsupported browser' warning
by gshereme＠redhat.com 02 May '16

02 May '16

Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin: remove 'unsupported browser' warning ...................................................................... webadmin: remove 'unsupported browser' warning Commit db95728 introduced a popup message in the webadmin header that warned people when their browser was "unsupported." However, we received many complaints that this message was simply confusing. Since we haven't have a browser compatibility issue in a very long time, we decided it was best to just remove the message. It's safe to say that we can support "any modern browser." I'll add something to that effect on the oVirt website. Change-Id: I2094c7640d4bda243e7b524f463962337398ab7f Bug-Url: https://bugzilla.redhat.com/1326511 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServlet.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/BaseDynamicMessages.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DynamicMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/DisplayBrowserCompatibilityWarning.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java M packaging/branding/ovirt.brand/external_resources.properties A packaging/dbscripts/upgrade/04_00_0590_remove_deprecated_config_value.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 14 files changed, 4 insertions(+), 81 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56653 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2094c7640d4bda243e7b524f463962337398ab7f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: storage: correctly evaluate NFS SD canonical path
by msivak＠redhat.com 02 May '16

02 May '16

Martin Sivák has submitted this change and it was merged. Change subject: storage: correctly evaluate NFS SD canonical path ...................................................................... storage: correctly evaluate NFS SD canonical path Patch https://gerrit.ovirt.org/56797/ fixed on glusterFS but broken on NFS. Change-Id: Iffe3cafe211674502e109a6c4c186ddcad809ecd Bug-Url: https://bugzilla.redhat.com/1327516 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/env/path.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved; Passed CI tests Simone Tiraboschi: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/56925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffe3cafe211674502e109a6c4c186ddcad809ecd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: storage: correctly evaluate NFS SD canonical path
by msivak＠redhat.com 02 May '16

02 May '16

Martin Sivák has submitted this change and it was merged. Change subject: storage: correctly evaluate NFS SD canonical path ...................................................................... storage: correctly evaluate NFS SD canonical path Patch https://gerrit.ovirt.org/56797/ fixed on glusterFS but broken on NFS. Change-Id: Iffe3cafe211674502e109a6c4c186ddcad809ecd Bug-Url: https://bugzilla.redhat.com/1327516 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/env/path.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56926 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffe3cafe211674502e109a6c4c186ddcad809ecd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0