Change in ovirt-engine[master]: packaging:pom: update requirements
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: packaging:pom: update requirements
......................................................................
packaging:pom: update requirements
Update pom requirements:
otopi: 1.5.0
ovirt-host-deploy: 1.5.0
Change-Id: I2cb1cd9f766ccf4ee63053bfe96568ef41e0c647
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58300
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2cb1cd9f766ccf4ee63053bfe96568ef41e0c647
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: core: provide CA in .vv file only if not overridden
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: provide CA in .vv file only if not overridden
......................................................................
core: provide CA in .vv file only if not overridden
Detect that a custom CA has been provided. If provided, don't set it to the .vv
file.
Change-Id: I439306bd3c001cade83a31929d3aab3f98a641a0
Bug-Url: https://bugzilla.redhat.com/1313379
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleOptions.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/EngineLocalConfig.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/AbstractConsoleWithForeignMenu.java
4 files changed, 27 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved; Passed CI tests
Martin Peřina: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/58178
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I439306bd3c001cade83a31929d3aab3f98a641a0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: aaa: engine doesn't trust externally-issued web certificate
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: aaa: engine doesn't trust externally-issued web certificate
......................................................................
aaa: engine doesn't trust externally-issued web certificate
Engine should use configurable trustore
for communication with sso module.
New config variables have been added
to pki conf file to let the user set
custom trustsore for SSO<->Engine
SSL communication. If the admin sets
up custom apache certificates and loads
the certificate into system wide trust
store, the admin can add a new conf
file to point the ENGINE_HTTPS_PKI_TRUST_STORE
and ENGINE_HTTPS_PKI_TRUST_STORE_PASSWORD to
the system truststore's location and password.
Change-Id: I35788dea6fff2f4bf4b554f4457591c29db057ed
Bug-Url: https://bugzilla.redhat.com/1336838
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoOAuthServiceUtils.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java
M packaging/services/ovirt-engine/ovirt-engine.conf.in
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/ca.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/sso.py
5 files changed, 15 insertions(+), 21 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57812
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I35788dea6fff2f4bf4b554f4457591c29db057ed
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: userportal: division by zero in resource allocation tab
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal: division by zero in resource allocation tab
......................................................................
userportal: division by zero in resource allocation tab
If the user has no VMs accessible in userportal, going to resource allocation
tab fails on division by zero.
Fixed the same way as in other parts of this tab, just setting 0.
Change-Id: I7046457082ecd3099c31c4fc4c18f286a16a5c25
Bug-Url: https://bugzilla.redhat.com/1339649
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Marek Libra: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/58075
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7046457082ecd3099c31c4fc4c18f286a16a5c25
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: Limit sonar analysis to master branch
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Limit sonar analysis to master branch
......................................................................
Limit sonar analysis to master branch
Sonar by default does not differentiate between different branches.
Limit the analysis to master to get untainted reports.
Change-Id: Icab31f0aaf98adc88214ed70d7276f13eac188ee
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M .travis.yml
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Roman Mohr: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58082
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icab31f0aaf98adc88214ed70d7276f13eac188ee
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: core: MacPoolPerDc—>MacPoolPerCluster
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: MacPoolPerDc—>MacPoolPerCluster
......................................................................
core: MacPoolPerDc—>MacPoolPerCluster
change scope of MAC pool from DataCenter to Cluster
Bug-Url: https://bugzilla.redhat.com/994283
Change-Id: Ia12b5c3bde7ef5e3732e6209a24dfc04fe5921d9
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddMacPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetMacPoolsByClusterIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolValidator.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveMacsOfUpdatedCluster.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ObjectCompensation.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateMacPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerCluster.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/TransactionalMacPoolDecorator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddEmptyStoragePoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/GetStoragePoolByDatacenterNameQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/GetStoragePoolByIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/GetStoragePoolsByClusterServiceQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/GetStoragePoolsByStorageDomainIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/StoragePoolQueryBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddClusterCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MacPoolValidatorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVMFromConfigurationCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerClusterTest.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerDcTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelperTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/GetStoragePoolByIdQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MacPoolDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MacPoolDaoImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/MacPoolDaoTest.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
50 files changed, 799 insertions(+), 554 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50756
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia12b5c3bde7ef5e3732e6209a24dfc04fe5921d9
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: webadmin: hosts: add ssh management submenu
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: webadmin: hosts: add ssh management submenu
......................................................................
webadmin: hosts: add ssh management submenu
This patch adds new submenu to Management host menu
called SSH Management. This menu contains restart and
stop buttons for SSH restart and SSH stop commands.
Change-Id: I1c73c667a750557d3e78d2a58b9fa246c63e417a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1024063
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
5 files changed, 147 insertions(+), 6 deletions(-)
Approvals:
Ondra Machacek: Verified
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57941
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c73c667a750557d3e78d2a58b9fa246c63e417a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-image-uploader[master]: ovirt-image-uploader: show deprecation warning
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-image-uploader: show deprecation warning
......................................................................
ovirt-image-uploader: show deprecation warning
Change-Id: Icf803ef6bd1739f86382b9cd8dfe2ff9d0a2ca4a
Bug-Url: https://bugzilla.redhat.com/1306637
Signed-off-by: Rafael Martins <rmartins(a)redhat.com>
---
M src/__main__.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Rafael Martins: Verified
--
To view, visit https://gerrit.ovirt.org/57872
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf803ef6bd1739f86382b9cd8dfe2ff9d0a2ca4a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-image-uploader
Gerrit-Branch: master
Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: webadmin: hosts: change structure of host list model buttons
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: webadmin: hosts: change structure of host list model buttons
......................................................................
webadmin: hosts: change structure of host list model buttons
Since there are many buttons in host list menu, this patch structures
them as follows:
- New (B)
- Edit(B)
- Remove(B)
- Management (M)
- Maintenance (B)
- Activate (B)
- Refresh capabilities (B)
- Confirm 'Host has been Rebooted' (B)
- Power Management (M)
- Restart (B)
- Start (B)
- Stop (B)
- Select as SPM (B)
- Configure local storage (B)
- Installation (M)
- Reinstall (B)
- Enroll certificate (B)
- Upgrade (B)
- Assign tags (B)
- NUMA Support (B)
- Approve (B)
Change-Id: I890678448e1d65727e74e373d663939d58774419
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1024063
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
3 files changed, 102 insertions(+), 60 deletions(-)
Approvals:
Ondra Machacek: Verified
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57791
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I890678448e1d65727e74e373d663939d58774419
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: Make video device explicit
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Make video device explicit
......................................................................
Make video device explicit
ovirt-engine specifies the video device it requires explicitly. This
does the same thing for HE setup to avoid any surprises regarding VDSM
reporting these devices.
In some cases the implicitly added video devices were not completely
reported of omitted by VDSM.
Change-Id: I75e80f2d4cb008a6c7567acf872736f1347c4971
Related-to: https://bugzilla.redhat.com/1326810
Related-to: https://bugzilla.redhat.com/1328921
Bug-Url: https://bugzilla.redhat.com/1339306
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/mixins.py
M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py
M templates/vm.conf.in
3 files changed, 21 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/57885
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75e80f2d4cb008a6c7567acf872736f1347c4971
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.3
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months