Change in ovirt-engine[master]: webadmin: v2v -moving vms between lists got stuck
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: v2v -moving vms between lists got stuck
......................................................................
webadmin: v2v -moving vms between lists got stuck
when choosing vms to import in the import VMs dialog, then clicking
"Next" to next import dialog for choosing cluster and then clicking
"Back" to display the first import dialog again:
in this senario when moving vms from importedVmModels list to
externalVmModels and vice versa, at some point clicking the arrow
button does nothing (arrow button is clicked and button callback is
called but VM is not moved).
This problem occurred because when clicking "back" button and
displaying 1st dialog, new UI objects are created for the 1st dialog
(SplitTable,ImportVmsPopupView...), but the old ones for this 1st dialog
are still alive and both old and new UI objects share the same model.
This causes the old UI button callbacks to disrupt the data for the new
UI objects. in some point when clicking on
a vm to select it with checkbox, the "old" button callback calulated it
as 2 vms checked although only one vm is actually checked.
Trying to move this VM by clicking the arrow causes failure and nothing
is moved.
The fix for this bug includes reseting both importedVmModels and
externalVmModels lists of the model (copying the items list only)
before creating the new UI instances for the "Back" operation.
Change-Id: Ib34d108a2959a50df0e39edd21360d2e5feb4f54
Bug-Url: https://bugzilla.redhat.com/1338740
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
2 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/58336
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib34d108a2959a50df0e39edd21360d2e5feb4f54
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: Fix unit test issue in ConfigureConsoleOptionsQueryTest
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: core: Fix unit test issue in ConfigureConsoleOptionsQueryTest
......................................................................
core: Fix unit test issue in ConfigureConsoleOptionsQueryTest
Fixes unit test issue in ConfigureConsoleOptionsQueryTest introduced in
patch I439306bd3c001cade83a31929d3aab3f98a641a0.
Change-Id: If2ad24dbe6a1ab78db307e3b8c51b20e3eda5d7c
Bug-Url: https://bugzilla.redhat.com/1313379
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQueryTest.java
1 file changed, 24 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, but someone else must approve
Martin Peřina: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58344
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2ad24dbe6a1ab78db307e3b8c51b20e3eda5d7c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in mom[master]: Release mom-0.5.4
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Release mom-0.5.4
......................................................................
Release mom-0.5.4
Change-Id: I83521d6dd0bc6840be88eb2f75f605037d892a97
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/58340
Continuous-Integration: Jenkins CI
---
M configure.ac
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58340
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I83521d6dd0bc6840be88eb2f75f605037d892a97
Gerrit-PatchSet: 2
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6.7]: build: ovirt-engine-3.6.7.1
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: build: ovirt-engine-3.6.7.1
......................................................................
build: ovirt-engine-3.6.7.1
Change-Id: Ieefc89d838c45c5dbf438a41c6123a0c9c239a99
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M automation/build-artifacts.sh
M backend/manager/dependencies/common/pom.xml
M backend/manager/dependencies/pom.xml
M backend/manager/dependencies/tools/pom.xml
M backend/manager/extensions-tool/pom.xml
M backend/manager/modules/aaa/pom.xml
M backend/manager/modules/auth-plugin/pom.xml
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/branding/pom.xml
M backend/manager/modules/builtin-extensions/pom.xml
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M backend/manager/modules/dal/pom.xml
M backend/manager/modules/docs/pom.xml
M backend/manager/modules/extensions-api-root/extensions-api/pom.xml
M backend/manager/modules/extensions-api-root/pom.xml
M backend/manager/modules/extensions-manager/pom.xml
M backend/manager/modules/logger/pom.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
M backend/manager/modules/restapi/interface/common/pom.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/pom.xml
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/modules/restapi/pom.xml
M backend/manager/modules/restapi/types/pom.xml
M backend/manager/modules/restapi/webapp/pom.xml
M backend/manager/modules/root/pom.xml
M backend/manager/modules/scheduler/pom.xml
M backend/manager/modules/searchbackend/pom.xml
M backend/manager/modules/services/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/uutils/pom.xml
M backend/manager/modules/vdsbroker/pom.xml
M backend/manager/modules/welcome/pom.xml
M backend/manager/pom.xml
M backend/manager/tools/pom.xml
M backend/pom.xml
M build-tools-root/checkstyles/pom.xml
M build-tools-root/jboss-modules-maven-plugin/pom.xml
M build-tools-root/ovirt-checkstyle-extension/pom.xml
M build-tools-root/pom.xml
M build/validations/pom.xml
M ear/pom.xml
M frontend/pom.xml
M frontend/webadmin/modules/frontend-symbols/pom.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/uicompat/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M frontend/webadmin/pom.xml
M mavenmake/pom.xml
M ovirt-engine.spec.in
M pom.xml
M version.mak
59 files changed, 64 insertions(+), 64 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58339
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieefc89d838c45c5dbf438a41c6123a0c9c239a99
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.7
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 10 months
Change in ovirt-dwh[master]: build: dwh build for 4.0 rc
by Shirly Radco
Shirly Radco has submitted this change and it was merged.
Change subject: build: dwh build for 4.0 rc
......................................................................
build: dwh build for 4.0 rc
Added release notes.
Change-Id: I04f500ba96e1afe768a776dcfd439ade3b2652c5
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M ovirt-engine-dwh.spec.in
M version.mak
2 files changed, 11 insertions(+), 2 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58318
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04f500ba96e1afe768a776dcfd439ade3b2652c5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-hosted-engine-setup[master]: upgrade: creating a new disk for engine-appliance-4.0
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: upgrade: creating a new disk for engine-appliance-4.0
......................................................................
upgrade: creating a new disk for engine-appliance-4.0
creating a new disk for engine-appliance-4.0 to preserve the
engine-appliance-3.6 disk till the migration end in order to
provide a quick/seamless rollback on errors.
Depends-on: https://gerrit.ovirt.org/#/c/54537/
Change-Id: I92bf4c677f15dbe432178f705b513e980fa8f466
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M configure.ac
M po/POTFILES.in
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/gr-he-common/vm/boot_disk.py
M src/plugins/gr-he-common/vm/misc.py
M src/plugins/gr-he-setup/vm/runvm.py
M src/plugins/gr-he-upgradeappliance/Makefile.am
M src/plugins/gr-he-upgradeappliance/core/misc.py
A src/plugins/gr-he-upgradeappliance/engine/Makefile.am
A src/plugins/gr-he-upgradeappliance/engine/__init__.py
A src/plugins/gr-he-upgradeappliance/engine/add_vm_disk.py
M src/plugins/gr-he-upgradeappliance/vm/configurevm.py
M src/plugins/gr-he-upgradeappliance/vm/runvm.py
13 files changed, 633 insertions(+), 52 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58136
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92bf4c677f15dbe432178f705b513e980fa8f466
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-hosted-engine-setup[master]: packaging: moving bridge and CA acquiring to gr-he-common
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: packaging: moving bridge and CA acquiring to gr-he-common
......................................................................
packaging: moving bridge and CA acquiring to gr-he-common
Moving engine CA acquiring to gr-he-common since also the upgrade
path will need it and on an earlier stage.
Moving also bridge plugin to gr-he-common since we have to detect
the host address from the bridge.
Change-Id: I7e7bc76f726e466185b2886f2d5572f2473ae1df
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M configure.ac
M po/POTFILES.in
M src/ovirt_hosted_engine_setup/Makefile.am
M src/ovirt_hosted_engine_setup/constants.py
A src/ovirt_hosted_engine_setup/engineapi.py
M src/plugins/gr-he-common/Makefile.am
M src/plugins/gr-he-common/engine/Makefile.am
M src/plugins/gr-he-common/engine/__init__.py
A src/plugins/gr-he-common/engine/ca.py
A src/plugins/gr-he-common/network/Makefile.am
A src/plugins/gr-he-common/network/__init__.py
R src/plugins/gr-he-common/network/bridge.py
M src/plugins/gr-he-setup/engine/add_host.py
M src/plugins/gr-he-setup/network/Makefile.am
M src/plugins/gr-he-setup/network/__init__.py
15 files changed, 475 insertions(+), 242 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58131
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e7bc76f726e466185b2886f2d5572f2473ae1df
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: fix monitoring of guest agent nics
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix monitoring of guest agent nics
......................................................................
core: fix monitoring of guest agent nics
We used to to compare the hash that is being calculated by the engine (of
network interfaces reported by the guest agent) with the hash in the
dynamic VM data reported by VDSM. The problem is that VDSM doesn't report
this hash, therefore it is always zero and therefore we update the dynamic
data of a VM that is installed with guest agent on each monitoring cycle.
This patch fixes this by changing the mentioned check so the computed
hash will be compared to the one that was calculated previously.
Change-Id: I38533ac778ffef528340d33cfbb64589d5d49fe8
Bug-Url: https://bugzilla.redhat.com/1340722
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Vinzenz Feenstra: Looks good to me, but someone else must approve
Arik Hadas: Verified; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/58303
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38533ac778ffef528340d33cfbb64589d5d49fe8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: Fix broken DAO tests
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: Fix broken DAO tests
......................................................................
core: Fix broken DAO tests
The assumption is that stored mac-pool ranges are in lower-case
should apply also to the fixtures file.
Change-Id: I490a4b9e04cd90153de5652902bee174db6425b4
Bug-Url: https://bugzilla.redhat.com/1324125
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/MacPoolDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
2 files changed, 12 insertions(+), 12 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I490a4b9e04cd90153de5652902bee174db6425b4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-image-uploader[master]: ovirt-image-uploader: port to SDK version 4
by rmartins＠redhat.com
Rafael Martins has submitted this change and it was merged.
Change subject: ovirt-image-uploader: port to SDK version 4
......................................................................
ovirt-image-uploader: port to SDK version 4
Please note that 'list' action behaviour changed, due to some
limitations of ovirt-engine-sdk4:
- Not showing the datacenter where the storage domain belongs
- Status column isn't very reliable.
Change-Id: I39029e5f3f13e3b748c417d1bc4f2ce0c349ab2d
Signed-off-by: Rafael Martins <rmartins(a)redhat.com>
---
M configure.ac
M ovirt-image-uploader.spec.in
M src/__main__.py
3 files changed, 57 insertions(+), 112 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Rafael Martins: Verified; Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/58271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I39029e5f3f13e3b748c417d1bc4f2ce0c349ab2d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-image-uploader
Gerrit-Branch: master
Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months