Change in ovirt-engine[master]: core: DomainPoolMap race - domain in 'detaching' as attached
by laravot@redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: DomainPoolMap race - domain in 'detaching' as attached
......................................................................
core: DomainPoolMap race - domain in 'detaching' as attached
When executing connectStoragePool/reconstructMaster verbs the engine
build the domain map and passes it to vdsm.
When deactivating domain its status is changed to 'Detaching' in the
begining of the operation, domains in that status aren't included in
the built domain map.
If multiple domain deactivations are performed concurrently the following
scenario could occur:
1. domain A deactivation start -> status changed to Deactivating
2. domain B deactivation start -> status changed to Deactivating
3. DeactiveStorageDomainVdsCommand executed for domain A
4. ConnectStoragePool is executed as part as domain A deactivation flow.
Both domains A and B aren't sent as part of the domain pool map as they
are in Deactivating status.
5. DeactiveStorageDomainVdsCommand executed for domain B and fails as
the domain isn't part of the pool domains anymore (as it wasn't sent as
part of the ConnectStoragePool call).
6. As part of the pool metadata synchronization domain B is marked as
detached altough its metadata wasn't updated to reflect that its not a
part of a storage pool.
The current solution to this race condition is to send domains in
Deactivating status as 'attached', domains in 'attached' status aren't
being accessed by the host anyway and the last deactivation pool metadata
refresh should contain the updated information to all the hosts.
Additionally, if the detach operation fails on the spm - this will
allow to activate the domain again.
Change-Id: I5e45ce1bbd37f3562c988a427026ec07c471d7e2
Bug-Url: https://bugzilla.redhat.com/1324076
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DetachStorageDomainFromPoolCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59338
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e45ce1bbd37f3562c988a427026ec07c471d7e2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: webadmin: fix UploadDiskModel validation and flush.
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: fix UploadDiskModel validation and flush.
......................................................................
webadmin: fix UploadDiskModel validation and flush.
Currently, the validation of the model gets a parameter that determines
if the object's diskModel validation will be called. When starting the
upload, this function is called 2 times, once when flushing, then before
starting the upload.
In case that the diskModel validation failed, it didn't flush, causing
an NPE when calling onUpload() without filling the needed fields- as the
diskModel validation is not called before flushing.
This patch makes the validation always call to the diskModel validation,
and makes flush() to return false if the model wasn't able to flush.
Change-Id: I2fc1942ffffd60254d1344fce582afbb6562c697
Bug-Url: https://bugzilla.redhat.com/1328887
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
1 file changed, 15 insertions(+), 22 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/59439
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fc1942ffffd60254d1344fce582afbb6562c697
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in jenkins[master]: make 4.0 publisher use otopi-1.5 branch
by eedri@redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: make 4.0 publisher use otopi-1.5 branch
......................................................................
make 4.0 publisher use otopi-1.5 branch
Change-Id: Icc9e237471e24bb9793d08b44b6c72cc9da1d80f
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Eyal Edri: Ready for merge
Barak Korren: Looks good to me
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/59430
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc9e237471e24bb9793d08b44b6c72cc9da1d80f
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: webadmin: hide Interface selectbox when resuming upload
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: hide Interface selectbox when resuming upload
......................................................................
webadmin: hide Interface selectbox when resuming upload
Resuming an upload will always be performed on disks that aren't
attached to a VM, therefore the "Interface" selectbox is not relevant in
that scenario.
Change-Id: I0db01d9360c703b95a0d762ba35f961dbc7f1798
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/59326
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0db01d9360c703b95a0d762ba35f961dbc7f1798
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: Add parenthesis to sql remove query
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add parenthesis to sql remove query
......................................................................
core: Add parenthesis to sql remove query
Once we remove old unreigstered disks of a storage domain the
query should use parenthesis.
Change-Id: I968d5a59039038089e9690a2e5f7c18f03195159
Bug-Url: https://bugzilla.redhat.com/1302780
Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com>
---
M packaging/dbscripts/unregistered_disks_sp.sql
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/59424
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I968d5a59039038089e9690a2e5f7c18f03195159
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-release[ovirt-4.0]: node: Fix repo enablement
by fabiand@redhat.com
Fabian Deutsch has submitted this change and it was merged.
Change subject: node: Fix repo enablement
......................................................................
node: Fix repo enablement
Change-Id: I31b68d5a8f19f08fb2a1c282b5acc85aedb9e9ef
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1340382
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M configure.ac
M ovirt-release40.spec.in
2 files changed, 12 insertions(+), 5 deletions(-)
Approvals:
Fabian Deutsch: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59433
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31b68d5a8f19f08fb2a1c282b5acc85aedb9e9ef
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-release[master]: node: Fix repo enablement
by fabiand@redhat.com
Fabian Deutsch has submitted this change and it was merged.
Change subject: node: Fix repo enablement
......................................................................
node: Fix repo enablement
Change-Id: I31b68d5a8f19f08fb2a1c282b5acc85aedb9e9ef
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1340382
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M configure.ac
M ovirt-release-master.spec.in
2 files changed, 12 insertions(+), 5 deletions(-)
Approvals:
Fabian Deutsch: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59432
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31b68d5a8f19f08fb2a1c282b5acc85aedb9e9ef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in otopi[otopi-1.5]: packaging: post otopi-1.5.0
by didi@redhat.com
Yedidyah Bar David has submitted this change and it was merged.
Change subject: packaging: post otopi-1.5.0
......................................................................
packaging: post otopi-1.5.0
Change-Id: I07de4dd0489c7f21b77ff60c3eab22705c5d9643
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ChangeLog
M configure.ac
2 files changed, 5 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58894
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07de4dd0489c7f21b77ff60c3eab22705c5d9643
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: otopi-1.5
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: RemovesSnapshot - Disk snapshots attached to other vms...
by laravot@redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: RemovesSnapshot - Disk snapshots attached to other vms validation
......................................................................
core: RemovesSnapshot - Disk snapshots attached to other vms validation
The validation of whether disk snapshots from the removed snapshots
was mistakenly removed in change I1bc597f, this patch restores it.
Change-Id: Ia7e1ba391e928911cf0ef8d27001d757d88f969d
Bug-Url: https://bugzilla.redhat.com/1342783
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/59305
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7e1ba391e928911cf0ef8d27001d757d88f969d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in jenkins[master]: otopi: add standard ci for branch otopi-1.5
by eedri@redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: otopi: add standard ci for branch otopi-1.5
......................................................................
otopi: add standard ci for branch otopi-1.5
Change-Id: I2b0b0888178c3a0107cc651d8c6f78599f8561eb
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M jobs/confs/projects/otopi/otopi_standard.yaml
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/58905
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b0b0888178c3a0107cc651d8c6f78599f8561eb
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months