June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: aaa: Failed to execute login on behalf - for user admin.
by piotr.kliczewski＠gmail.com 16 Jun '16

16 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: Failed to execute login on behalf - for user admin. ...................................................................... aaa: Failed to execute login on behalf - for user admin. LoginOnBehalf needs to query user by id. The SSO directory query needs to be a public query to facilitate LoginOnBehalf. Change-Id: Ib5bae00e5ab9ec05147487b916e8c4b36c3b81fa Bug-Url: https://bugzilla.redhat.com/1344272 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoOAuthServiceUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginOnBehalfCommand.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/search/DirectorySearch.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java 4 files changed, 24 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59340 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5bae00e5ab9ec05147487b916e8c4b36c3b81fa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use ReplacementUtils
by masayag＠redhat.com 16 Jun '16

16 Jun '16

Moti Asayag has submitted this change and it was merged. Change subject: core: Use ReplacementUtils ...................................................................... core: Use ReplacementUtils • used ReplacementUtils in CommandBase instead of constructing set string manually • replaced usage of MessageFormat in ReplacementUtils with String.format; MessageFormat is intended for internationalization, not simple string formatting. Change-Id: I123801a63bfffd3519fbacc7f9ca15e14f73f878 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReplacementUtils.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I123801a63bfffd3519fbacc7f9ca15e14f73f878 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Sync gluster servers with virt service
by sabose＠redhat.com 16 Jun '16

16 Jun '16

Sahina Bose has submitted this change and it was merged. Change subject: engine: Sync gluster servers with virt service ...................................................................... engine: Sync gluster servers with virt service Currently the code skips syncing gluster server status as well as probing alternate interfaces if the cluster has virt service. We need to make sure that servers are not removed if virt service is enabled, but other info can be synced. Fixing with this patch Change-Id: Idf4c591284cef9a4223134bca9887cb47df5ccfe Bug-Url: https://bugzilla.redhat.com/1300095 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java 1 file changed, 45 insertions(+), 42 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Verified; Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56854 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf4c591284cef9a4223134bca9887cb47df5ccfe Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: build: post ovirt-hosted-engine-setup-2.0.0.2
by stirabos＠redhat.com 16 Jun '16

16 Jun '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-2.0.0.2 ...................................................................... build: post ovirt-hosted-engine-setup-2.0.0.2 Change-Id: I7c018f01b5fee236881ee20e7ace76276b0a972b Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 10 insertions(+), 4 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved; Passed CI tests Rafael Martins: Looks good to me, but someone else must approve Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/59333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c018f01b5fee236881ee20e7ace76276b0a972b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: build: ovirt-hosted-engine-setup-2.0.0.2
by stirabos＠redhat.com 16 Jun '16

16 Jun '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-2.0.0.2 ...................................................................... build: ovirt-hosted-engine-setup-2.0.0.2 Change-Id: I88508ef1896cad62b747aad5f82aa45c26b53856 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved; Passed CI tests Rafael Martins: Looks good to me, but someone else must approve Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/59331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88508ef1896cad62b747aad5f82aa45c26b53856 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in jenkins[master]: ioprocess: Add release 0.16 branch
by bkorren＠redhat.com 16 Jun '16

16 Jun '16

Barak Korren has submitted this change and it was merged. Change subject: ioprocess: Add release 0.16 branch ...................................................................... ioprocess: Add release 0.16 branch ovirt-4.0 should use this branch. Change-Id: Ifb2e5c098604957762937d800db808d31c194be3 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M jobs/confs/projects/ioprocess/ioprocess.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Barak Korren: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me -- To view, visit https://gerrit.ovirt.org/59294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb2e5c098604957762937d800db808d31c194be3 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: User setting of FullScreen propagated to .vv
by piotr.kliczewski＠gmail.com 16 Jun '16

16 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: User setting of FullScreen propagated to .vv ...................................................................... webadmin: User setting of FullScreen propagated to .vv Fix: User setting of 'Open in Full Screen' is propagated to console.vv Change-Id: Id294c4fb4e7ee40d89a8ab2bd6cb739b7dce0275 Bug-Url: https://bugzilla.redhat.com/1345791 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/59329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id294c4fb4e7ee40d89a8ab2bd6cb739b7dce0275 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: Adding dao tests to std ci
by piotr.kliczewski＠gmail.com 16 Jun '16

16 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: Adding dao tests to std ci ...................................................................... Adding dao tests to std ci Basically this patch is all about running dao tests inside a mock. For this, a postgresql DB should be installed and run inside the mock. Added postgres packages to .packages files Created a new script, dao-tests.sh. This script is being called only if files that are relevant to DB had been changed. The script will pick a port randomly and will update pg_hba.conf file to allow DB access. All the rest is the same as how the tests were running when not in std ci. Change-Id: If01639ebd0e346e0bd724a3b9ec68b44e7e9e765 Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- M automation/check-merged.packages M automation/check-merged.sh M automation/check-patch.packages A automation/check-patch.packages.el6 M automation/check-patch.sh A automation/dao-tests.sh 6 files changed, 119 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eyal Edri: Looks good to me, but someone else must approve Gil Shinar: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58663 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d62c210ebc488f473f6dcc291f056d7111e1e1f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VmDevicesMonitoring function reference
by ahadas＠redhat.com 16 Jun '16

16 Jun '16

Arik Hadas has submitted this change and it was merged. Change subject: core: VmDevicesMonitoring function reference ...................................................................... core: VmDevicesMonitoring function reference Use function reference instead of lambda expression to make the code easier to read. Change-Id: I75ae3c54f7d3f46ca3d1a3d80fd258045f9b3164 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75ae3c54f7d3f46ca3d1a3d80fd258045f9b3164 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: final VmDevicesMonitoring#devicesStatusesLock
by ahadas＠redhat.com 16 Jun '16

16 Jun '16

Arik Hadas has submitted this change and it was merged. Change subject: core: final VmDevicesMonitoring#devicesStatusesLock ...................................................................... core: final VmDevicesMonitoring#devicesStatusesLock Converted the effectively final devicesStatusesLock to actually be final, as it's used as a lock, and changing the reference by mistake may introduce hard to find bugs. Note that this patch solves a warning reported by IntelliJ IDEA. Change-Id: Ie7ca0121b5423a9bf184577ade4cc6d0e9fb1299 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7ca0121b5423a9bf184577ade4cc6d0e9fb1299 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0