Change in ovirt-release[master]: Enables hystrix and its dependencies on EPEL
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Enables hystrix and its dependencies on EPEL
......................................................................
Enables hystrix and its dependencies on EPEL
Enables to download hystrix and its dependencies from EPEL7 repo.
Change-Id: Ie04627d56a400831ec5609f97ce88b07c90e5ddc
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M ovirt-el7-deps.repo.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
Roman Mohr: Looks good to me, but someone else must approve
Eyal Edri: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59962
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie04627d56a400831ec5609f97ce88b07c90e5ddc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
7 years, 10 months
Change in ovirt-engine[master]: core: Update the OVF store when hosted engine VM is edited
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: Update the OVF store when hosted engine VM is edited
......................................................................
core: Update the OVF store when hosted engine VM is edited
Retrigger the ovf update from the UpdateVmCommand when
the hosted engine VM was edited.
This is needed to persist the hosted engine VM configuration
as soon as possible in case the ovirt-hosted-engine-agent
needs to restart the engine VM with the proper settings.
There is still a very slight chance of hitting a race
condition (when the regularly scheduled OVF updater processes
the hosted engine VM at the exact same moment as the triggered
job), but the VM will be saved during the next OVF update anyway.
Bug-Url: https://bugzilla.redhat.com/1340626
Change-Id: I121a9f587b2a85bdd4b366f07b040dc85fa515cf
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
1 file changed, 29 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Verified
Liron Aravot: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51842
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I121a9f587b2a85bdd4b366f07b040dc85fa515cf
Gerrit-PatchSet: 26
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: Take VM lock before assigning a pooled VM to user
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: core: Take VM lock before assigning a pooled VM to user
......................................................................
core: Take VM lock before assigning a pooled VM to user
In AttachUserToVmFromPoolAndRunCommand, take an exclusive lock on the VM
before setting user's ownership on it. This prevents other commands to
act on this VM before it is run as the result of
AttachUserToVmFromPoolAndRunCommand. On another side, if the VM is
already locked by some other command (e.g. RunVmCommand),
AttachUserToVmFromPoolAndRunCommand will not be able to lock it and will
be forced to take another VM from the pool.
Change-Id: Id2290f7b229041b989011f2acd4bf96af51357f9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1349049
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
1 file changed, 107 insertions(+), 44 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
--
To view, visit https://gerrit.ovirt.org/59795
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2290f7b229041b989011f2acd4bf96af51357f9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: Fix sorting and whitespace errors
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: core: Fix sorting and whitespace errors
......................................................................
core: Fix sorting and whitespace errors
Change-Id: Ic54cb2ee5de61c76867cc3646062315d61a0a823
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M ovirt-engine.spec.in
M packaging/etc/engine-config/engine-config.properties
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Roman Mohr: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59935
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic54cb2ee5de61c76867cc3646062315d61a0a823
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[ovirt-engine-4.0]: aaa: oVirt welcome page locale selector is broken
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: oVirt welcome page locale selector is broken
......................................................................
aaa: oVirt welcome page locale selector is broken
The login page labels and the welcome
page login menu labels need to be localized.
Change-Id: I96a4dd255f82e50e46f1eb1c5c9085f6c0ca15b3
Bug-Url: https://bugzilla.redhat.com/1323484
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
(cherry picked from commit c0e2ec7210286a333e0ba6c2227dd02c386ed2ec)
---
M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/header.tag
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59955
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96a4dd255f82e50e46f1eb1c5c9085f6c0ca15b3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 10 months
Change in ovirt-engine[ovirt-engine-4.0]: aaa: FQDN checking introduced by SSO should be case-insensitive
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: FQDN checking introduced by SSO should be case-insensitive
......................................................................
aaa: FQDN checking introduced by SSO should be case-insensitive
The client redirect uri check done by
sso needs to be case insensitive.
Change-Id: I01b12c1f2671d16bfe0aafd3c11f92e1421ba1bc
Bug-Url: https://bugzilla.redhat.com/1351217
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
(cherry picked from commit a7acb2bcc3703ec5dc13663981798c37eb1de510)
---
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59954
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I01b12c1f2671d16bfe0aafd3c11f92e1421ba1bc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 10 months
Change in ovirt-engine[master]: core: make VmDeviceUtils non-static
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: make VmDeviceUtils non-static
......................................................................
core: make VmDeviceUtils non-static
The patch makes VmDeviceUtils non-static and by that achieves:
* make VmDeviceUtils a CDI managed bean:
** being able to inject its dependencies.
** being able to consume it as a dependency of other beans.
* Stop obtaining DbFacade through SimpleDependecyInjector.
* Being able to declare the real class dependencies.
* Get DAO dependencies through CDI rather then using DbFacade.
* Make its users easier testable by being able to mock VmDeviceUtils.
Change-Id: Ia0f299b7874f1fac50cc659b21d1fd26315a389d
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVirtioScsiControllersQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ConvertVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/MoveOrCopyTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/AbstractVmHostDevicesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/AddVmTemplateInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/ChangeDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/DetachDiskFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfUpdateProcessHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ExportRepoImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportExportRepoImageCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVMFromConfigurationCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
62 files changed, 456 insertions(+), 297 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/58946
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0f299b7874f1fac50cc659b21d1fd26315a389d
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: aaa: oVirt welcome page locale selector is broken
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: aaa: oVirt welcome page locale selector is broken
......................................................................
aaa: oVirt welcome page locale selector is broken
The login page labels and the welcome
page login menu labels need to be localized.
Change-Id: I96a4dd255f82e50e46f1eb1c5c9085f6c0ca15b3
Bug-Url: https://bugzilla.redhat.com/1323484
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/header.tag
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59945
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96a4dd255f82e50e46f1eb1c5c9085f6c0ca15b3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
7 years, 10 months
Change in ovirt-engine[ovirt-engine-4.0]: jsonrpc: version bump
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: jsonrpc: version bump
......................................................................
jsonrpc: version bump
Change-Id: I12f0dd2759e046b241ac1790b15fb3384495b3c2
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1349008
---
M ovirt-engine.spec.in
M pom.xml
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/59888
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12f0dd2759e046b241ac1790b15fb3384495b3c2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: support sort by client and server side in one table
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: support sort by client and server side in one table
......................................................................
webadmin: support sort by client and server side in one table
Before when we have table we could sort only server side or client side,
depends on flag we set. There could be situations where we need to have
support for both. An example is 'Active User Sessions' tab, where we show
columns which are in database and also in memory.
This patch add support, so we can have some columns sorted server side,
and some by client side.
Change-Id: Ic4c1dba19cedf015c5cad42a4f6872a79669d944
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1340451
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnResizeCellTable.java
1 file changed, 20 insertions(+), 11 deletions(-)
Approvals:
Ondra Machacek: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59938
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4c1dba19cedf015c5cad42a4f6872a79669d944
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months