Change in ovirt-engine-sdk-ruby[master]: Add support for following links to lists
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Add support for following links to lists
......................................................................
Add support for following links to lists
Currently the "follow_link" method of the "Conection" class only
supports links to single objects, but not links to list of objects. This
patch changes the SDK so that it will also support this kind of links.
For example, when a VM is retrieved it will include links to its NICs:
<vm id="123" href="/vms/123">
<link rel="nics" href="/vms/123/nics"/>
...
</vm>
The SDK will process this "link" element and store it in the "vm.nics"
property of the created object. Later, the user will be able to use the
"follow_link" method to retrieve that list:
vm = ...
nics = connection.follow_link(vm.nics)
nics.each do |nic|
puts "nic: #{nic.name}"
end
Change-Id: I33adfd45183838f81873ab70fade92c8d89e9c44
Related-To: https://bugzilla.redhat.com/1349857
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java
M sdk/examples/follow_vm_links.rb
M sdk/lib/ovirtsdk4/http.rb
M sdk/spec/vm_reader_spec.rb
4 files changed, 163 insertions(+), 8 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/60010
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I33adfd45183838f81873ab70fade92c8d89e9c44
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
7 years, 9 months
Change in ovirt-engine[master]: restapi: Don't generate streaming support code
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Don't generate streaming support code
......................................................................
restapi: Don't generate streaming support code
When version 4 of the API was planned it was decided to introduce
support for streaming results. This required the introduction of
streaming XML and JSON parsing and rendering code, automatically
generated from the model. But this code isn't currently used, and
generating increases the compilation time and incorrectly reduces the
percentage of coverage reported by some tools. To avoid those
inconveniences this patch removes the generation of this code from the
bulid process. This will be reintroduced later, when the streaming
support is completed.
Change-Id: Iff09f64dc755493facaa4c9b7e457860c4982f18
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/pom.xml
1 file changed, 0 insertions(+), 21 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59778
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff09f64dc755493facaa4c9b7e457860c4982f18
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: Use the hosted storage domain id instead of name when ...
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Use the hosted storage domain id instead of name when importing it
......................................................................
core: Use the hosted storage domain id instead of name when importing it
When importing hosted storage domain the system relied on a hardcoded
name: "hosted_storage".
Instead of using that constant to find and import the domain the code is
now using the domain id that is reported by vdsm in the vm data.
The system verifies that a hosted engine VM is running on a storage
domain to determine if that domain is a hosted engine domain.
Change-Id: Iad7c5f4e5557e4c861e5a2317c79bc3fae874e70
Bug-Url: https://bugzilla.redhat.com/1301105
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsWithAttachedStoragePoolGuidQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddExistingBlockStorageDomainCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddExistingFileStorageDomainCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsWithAttachedStoragePoolGuidQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBaseTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/StorageConstants.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
A packaging/dbscripts/upgrade/04_01_0100_remove_hosted_engine_storage_domain_name_config_value.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
16 files changed, 106 insertions(+), 116 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/58422
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad7c5f4e5557e4c861e5a2317c79bc3fae874e70
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.0]: core: fix PowerSavingWeight score calculation
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: fix PowerSavingWeight score calculation
......................................................................
core: fix PowerSavingWeight score calculation
EvenDistributionWeightPolicy unit calculated a weight score that was
comprised from CPU usage and memory consumption.
This calculation was wrong (which Power saving weight module relied on)
there was a need to separate the weight policy units to 2 units :
EvenDistributionCPUWeightPolicy and EvenDistributionMemoryWeightPolicy
which produced 2 new power saving units:
PowerSavingMemoryWeightPolicyUnit and PowerSavingMemoryCPUPolicyUnit
instead of PowerSavingWeightPolicyUnit.
CPU usage is calculated as before
(power saving unit takes the opposite score)
Memory score is calculated by
the range of 1 to the maximum available memory of a host in the cluster
and normalized to the score range.
NonWeightPolicy unit was removed and will replaced
with memory and CPU even distribution policies under
the default 'None' scheduling policy
Change-Id: I4ed2fa107b4c1139a4a4f9c07894472280acbf6b
Bug-Url: https://bugzilla.redhat.com/1260381
Signed-off-by: Yanir Quinn <yquinn(a)redhat.com>
Signed-off-by: yquinn <yquinn(a)redhat.com>
(cherry picked from commit 6037d18)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalClusterPolicies.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalPolicyUnits.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionCPUWeightPolicyUnit.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionMemoryWeightPolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnit.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingCPUWeightPolicyUnit.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingMemoryWeightPolicyUnit.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/InternalClusterPoliciesTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnitTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingWeightPolicyUnitTest.java
10 files changed, 300 insertions(+), 82 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Yanir Quinn: Verified
--
To view, visit https://gerrit.ovirt.org/59674
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ed2fa107b4c1139a4a4f9c07894472280acbf6b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in jenkins[master]: replace 4.0.0 with 4.0.1 branch for running jobs
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: replace 4.0.0 with 4.0.1 branch for running jobs
......................................................................
replace 4.0.0 with 4.0.1 branch for running jobs
Change-Id: I9f75ec6c456926fe8a42c2ccc4fecc85059c0294
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me; Ready for merge
Anton Marchukov: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59972
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f75ec6c456926fe8a42c2ccc4fecc85059c0294
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
7 years, 9 months
Change in ovirt-engine[master]: add XEN provider to v2v infrastructure
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: add XEN provider to v2v infrastructure
......................................................................
add XEN provider to v2v infrastructure
Change-Id: I70961cb0c336229840811d653b315a268d72d3c4
Bug-Url: https://bugzilla.redhat.com/1349321
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxyFactory.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/XENVmProviderProxy.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ProviderType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/XENVmProviderProperties.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDaoImpl.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/EditProviderModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/XENPropertiesModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.ui.xml
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/XENPropertiesWidget.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/XENPropertiesWidget.ui.xml
16 files changed, 454 insertions(+), 7 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59680
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70961cb0c336229840811d653b315a268d72d3c4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Remove redundant c'tors
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: Remove redundant c'tors
......................................................................
core: Remove redundant c'tors
Bug-Url: https://bugzilla.redhat.com/1350399
Change-Id: I3abda2d6515de979497479f990e801b18d7daa7c
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddFenceAgentCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BookmarkCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExternalEventCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceAgentCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveFenceAgentCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateFenceAgentCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/UserCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RemoveFenceAgentsByVdsIdCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/SyncImageGroupDataCommand.java
13 files changed, 2 insertions(+), 65 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/59529
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3abda2d6515de979497479f990e801b18d7daa7c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Update the OVF store when hosted engine VM is edited
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: Update the OVF store when hosted engine VM is edited
......................................................................
core: Update the OVF store when hosted engine VM is edited
Retrigger the ovf update from the UpdateVmCommand when
the hosted engine VM was edited.
This is needed to persist the hosted engine VM configuration
as soon as possible in case the ovirt-hosted-engine-agent
needs to restart the engine VM with the proper settings.
There is still a very slight chance of hitting a race
condition (when the regularly scheduled OVF updater processes
the hosted engine VM at the exact same moment as the triggered
job), but the VM will be saved during the next OVF update anyway.
Bug-Url: https://bugzilla.redhat.com/1340626
Change-Id: I121a9f587b2a85bdd4b366f07b040dc85fa515cf
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
1 file changed, 29 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/59968
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I121a9f587b2a85bdd4b366f07b040dc85fa515cf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.0]: engine: Validate network providers against required fields.
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: Validate network providers against required fields.
......................................................................
engine: Validate network providers against required fields.
It was possible to create a an openstack network provider
without the required fields. This patch adds the required
validation.
Change-Id: I709e3df59eaf3cd0db983dd132342e90b1f02f74
Bug-Url: https://bugzilla.redhat.com/1333728
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/NetworkProviderValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/NetworkProviderValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
10 files changed, 156 insertions(+), 7 deletions(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/59877
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I709e3df59eaf3cd0db983dd132342e90b1f02f74
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.0]: Revert "webadmin: Add label comboboxes to VM & host dialogs"
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: Revert "webadmin: Add label comboboxes to VM & host dialogs"
......................................................................
Revert "webadmin: Add label comboboxes to VM & host dialogs"
The bug (https://bugzilla.redhat.com/show_bug.cgi?id=1338799) is targeted to
4.1, should not be part to 4.0.
Also the feature does not make much sense in edit dialogs since it is a read
only property. Also the placement of it inside the dialog is questionable. The
implementation itself is also not really aligned with the rest of the code.
This reverts commit 61d899dd1b19ebd475ef3187ca74c9cf1360da35.
Bug-Url: https://bugzilla.redhat.com/1338799
Change-Id: I4e13cd4651a614d68d7dd7462094f9180c7479d6
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalExistingVmModelBehavior.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
13 files changed, 4 insertions(+), 172 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, but someone else must approve
Michal Skrivanek: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/59925
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e13cd4651a614d68d7dd7462094f9180c7479d6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
7 years, 9 months