Change in ovirt-engine[master]: core: Remove redundant field from AddVmParameters
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Remove redundant field from AddVmParameters
......................................................................
core: Remove redundant field from AddVmParameters
This field in the parameters is only used in the validation of
AddVmFromScratchCommand and is empty and never set thus can safely be
removed
Change-Id: Ia5c5b9d06f42fc7b8a46a261ffa4acf43fe9372e
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmParameters.java
2 files changed, 0 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/58844
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5c5b9d06f42fc7b8a46a261ffa4acf43fe9372e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: fix detection of unmanaged vms
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix detection of unmanaged vms
......................................................................
core: fix detection of unmanaged vms
When detecting an unmanaged VM running on the host, we add the dynamic
data that is reported by VDSM to the database. This data does not contain
the host that the VM is running on, so we end up having a running VM
without the host that it runs on. This situation must be prevented.
Change-Id: I9f488df83c9335922b0b422e85da4bc93b8a380b
Bug-Url: https://bugzilla.redhat.com/1342818
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified; Looks good to me, but someone else must approve
Shmuel Leib Melamud: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/58640
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f488df83c9335922b0b422e85da4bc93b8a380b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: packaging: setup: Always update ovirt-engine-dashboard
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: setup: Always update ovirt-engine-dashboard
......................................................................
packaging: setup: Always update ovirt-engine-dashboard
Change-Id: I21d9bc56278c720ddfc26b00f8bb64932fbab465
Bug-Url: https://bugzilla.redhat.com/1342070
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 922b696bd498bee188339170ca7fcda6f5cbb3e3)
---
M packaging/setup/ovirt_engine_setup/engine/constants.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/58913
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21d9bc56278c720ddfc26b00f8bb64932fbab465
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: packaging: setup: versionlock ovirt-engine-dashboard
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: setup: versionlock ovirt-engine-dashboard
......................................................................
packaging: setup: versionlock ovirt-engine-dashboard
Change-Id: I3cba352280f7ac37ed1f869df281e0615987171c
Bug-Url: https://bugzilla.redhat.com/1342070
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit d0f0c487b77ab6f047982e97f84a6b96909f5d21)
---
M packaging/setup/ovirt_engine_setup/constants.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/58912
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3cba352280f7ac37ed1f869df281e0615987171c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-3.6]: core: DiskImageDynamicDao - deadlock caused by wrong sorting
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: DiskImageDynamicDao - deadlock caused by wrong sorting
......................................................................
core: DiskImageDynamicDao - deadlock caused by wrong sorting
updateAllDiskImageDynamicWithDiskIdByVmId is supposed to sort
the DiskImageDynamicDao objects its updating in order to avoid
deadlocks. Currently the sorting is done on the first object
of the pair which is the vm id instead of the the image group id.
This patch changes the sorting to be according the image group id as
it was supposed to be.
Change-Id: I4194c93b0e919543b5a5c1b3621dab0d4604c983
Bug-Url: https://bugzilla.redhat.com/1342317
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoTest.java
2 files changed, 37 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/58915
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4194c93b0e919543b5a5c1b3621dab0d4604c983
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in otopi[master]: packaging: post otopi-1.5
by didi＠redhat.com
Yedidyah Bar David has submitted this change and it was merged.
Change subject: packaging: post otopi-1.5
......................................................................
packaging: post otopi-1.5
Change-Id: Iec38b262a49e830997da675ab830ea1537e0ad4b
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ChangeLog
M configure.ac
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58893
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec38b262a49e830997da675ab830ea1537e0ad4b
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine-sdk-java[master]: Use default port number of protocol if not explicitly set
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Use default port number of protocol if not explicitly set
......................................................................
Use default port number of protocol if not explicitly set
We should use default port associated with protocol, if user don't explicitly set
his own port. This patch changes behavior to respect that.
Change-Id: I74d5c46e64c9e3939a79e586fe5a9de79b0f75d2
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M sdk/src/main/java/org/ovirt/engine/sdk4/ConnectionBuilder.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Petr Balogh: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58886
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74d5c46e64c9e3939a79e586fe5a9de79b0f75d2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Petr Balogh <pbalogh(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: packaging: setup: Always update ovirt-engine-dashboard
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: packaging: setup: Always update ovirt-engine-dashboard
......................................................................
packaging: setup: Always update ovirt-engine-dashboard
Change-Id: I21d9bc56278c720ddfc26b00f8bb64932fbab465
Bug-Url: https://bugzilla.redhat.com/1342070
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine/constants.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/58629
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21d9bc56278c720ddfc26b00f8bb64932fbab465
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: allow to remove diskless vm when storage pool is not up
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: allow to remove diskless vm when storage pool is not up
......................................................................
core: allow to remove diskless vm when storage pool is not up
We do not need the storage pool to be up in order to remove diskless VM.
Change-Id: I3956338d9a4ff3a443eb135f8a9809c488be18ba
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/58643
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3956338d9a4ff3a443eb135f8a9809c488be18ba
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: really fix div by 0 exception
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: really fix div by 0 exception
......................................................................
webadmin: really fix div by 0 exception
- On a VM without a disk the query would fail. I thought I had fixed
the problem early but I had messed up the way the sql worked, this
patch fixes the problem.
Change-Id: I9c1f0ad0554828063c62e0f2541f8aba3193bad2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1342098
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/StorageDomainDwhDAO.properties
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/58910
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c1f0ad0554828063c62e0f2541f8aba3193bad2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months