Change in ovirt-engine[ovirt-engine-4.0]: webadmin: improve the look of New/Edit ISCSI domain window
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: improve the look of New/Edit ISCSI domain window
......................................................................
webadmin: improve the look of New/Edit ISCSI domain window
This patch improves the look of the New/Edit ISCSI storage domain
window.
To do that, this patch:
1. Decreases the tabs height ("Luns to Target" and "Targets to Luns").
2. Increases the height of each tab's content to be exactly twice the
height of each tab to align them with the tabs.
3. Decreases the height of the "Luns to Target" view to fit into the
tab's content.
Change-Id: I10e077460b1073ce7931ddfe3033b41b46d44ac4
Bug-Url: https://bugzilla.redhat.com/1344301
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/58909
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10e077460b1073ce7931ddfe3033b41b46d44ac4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: core: DiskImageDynamicDao - deadlock caused by wrong sorting
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: DiskImageDynamicDao - deadlock caused by wrong sorting
......................................................................
core: DiskImageDynamicDao - deadlock caused by wrong sorting
updateAllDiskImageDynamicWithDiskIdByVmId is supposed to sort
the DiskImageDynamicDao objects its updating in order to avoid
deadlocks. Currently the sorting is done on the first object
of the pair which is the vm id instead of the the image group id.
This patch changes the sorting to be according the image group id as
it was supposed to be.
Change-Id: I4194c93b0e919543b5a5c1b3621dab0d4604c983
Bug-Url: https://bugzilla.redhat.com/1342317
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoTest.java
3 files changed, 47 insertions(+), 25 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/58902
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4194c93b0e919543b5a5c1b3621dab0d4604c983
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: packaging: setup: versionlock ovirt-engine-dashboard
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: packaging: setup: versionlock ovirt-engine-dashboard
......................................................................
packaging: setup: versionlock ovirt-engine-dashboard
Change-Id: I3cba352280f7ac37ed1f869df281e0615987171c
Bug-Url: https://bugzilla.redhat.com/1342070
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/58628
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3cba352280f7ac37ed1f869df281e0615987171c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: Correct flow of RunVmCommand.endAction()
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: core: Correct flow of RunVmCommand.endAction()
......................................................................
core: Correct flow of RunVmCommand.endAction()
Recent change in RunVmCommand.getCallback() forces RunVmCommand to
actively use the callback. This requires changes in other places to
correctly execute RunVmCommand.endAction() in every situation.
The flow selected by RunVmCommand.getFlow() method is now cached in
RunVmParams. The cache in RunVmCommand itself is useless, because the
command is created from scratch when CoCo calls its callback, and
getFlow() cannot determine the flow correctly in this situation.
AttachUserToVmFromPoolAndRunCommand is modified to correctly use the
callback - without it endAction() is never called. RunVmCommand is
started as COMMAND_MANAGED and performs by itself all actions needed to
start a VM as stateless or stateful.
AttachUserToVmFromPoolAndRunCommand.endAction() is executed after that
and checks the final result of RunVmCommand. If it failed, user's
ownership of the VM is reverted.
Change-Id: I099d5a8b7ee3aef6b8abb124de39767de6a99c20
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1342795
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java
4 files changed, 94 insertions(+), 59 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
--
To view, visit https://gerrit.ovirt.org/58555
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I099d5a8b7ee3aef6b8abb124de39767de6a99c20
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: Remove unused NaturalOrderComparator
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused NaturalOrderComparator
......................................................................
core: Remove unused NaturalOrderComparator
Change-Id: I0e5ba5104df2921f6c58b992a94feba21ec567bb
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/NaturalOrderComparator.java
1 file changed, 0 insertions(+), 19 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/58908
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e5ba5104df2921f6c58b992a94feba21ec567bb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: backend: generate default template's name for repo-image
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: backend: generate default template's name for repo-image
......................................................................
backend: generate default template's name for repo-image
When importing an image from glance as a template, if the template's
name is not specified then we generate a default one in
ImportRepoImageCopyTaskHandler::createTemplate.
The problem with this is that ImportRepoImageCommand doesn't know about
this auto generated template's name (it's null in the command's
parameters), and then the template is logged as a part of the event as
"<UNKNOWN>", although it's created with its default name.
This patch generates that default template's name in the command instead
of the handler.
Change-Id: I7386be3d2c1254dc3df0dfab9c6c340b41a00aed
Bug-Url: https://bugzilla.redhat.com/1324780
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCopyTaskHandler.java
2 files changed, 10 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/58903
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7386be3d2c1254dc3df0dfab9c6c340b41a00aed
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: don't ignore new template's name on import image fr...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: don't ignore new template's name on import image from Glance
......................................................................
restapi: don't ignore new template's name on import image from Glance
When importing an image as a template from Glance, if the URL that is
used is of the form
"/api/openstackimageproviders/<provider_id>/images/<image_id>/import"
and the template's name is specified, it is ignored and not passed to
ImportRepoImageCommand.
This patch passes this parameter if it is specified.
Change-Id: I60f44c0d519e7deea29095543b1a06ac0d6a1ef4
Bug-Url: https://bugzilla.redhat.com/1344048
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageResource.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/58904
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60f44c0d519e7deea29095543b1a06ac0d6a1ef4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: webadmin: improve the look of New/Edit ISCSI domain window
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: improve the look of New/Edit ISCSI domain window
......................................................................
webadmin: improve the look of New/Edit ISCSI domain window
This patch improves the look of the New/Edit ISCSI storage domain
window.
To do that, this patch:
1. Decreases the tabs height ("Luns to Target" and "Targets to Luns").
2. Increases the height of each tab's content to be exactly twice the
height of each tab to align them with the tabs.
3. Decreases the height of the "Luns to Target" view to fit into the
tab's content.
Change-Id: I10e077460b1073ce7931ddfe3033b41b46d44ac4
Bug-Url: https://bugzilla.redhat.com/1344301
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/58900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10e077460b1073ce7931ddfe3033b41b46d44ac4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: DiskImageDynamicDao - deadlock caused by wrong sorting
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: DiskImageDynamicDao - deadlock caused by wrong sorting
......................................................................
core: DiskImageDynamicDao - deadlock caused by wrong sorting
updateAllDiskImageDynamicWithDiskIdByVmId is supposed to sort
the DiskImageDynamicDao objects its updating in order to avoid
deadlocks. Currently the sorting is done on the first object
of the pair which is the vm id instead of the the image group id.
This patch changes the sorting to be according the image group id as
it was supposed to be.
Change-Id: I4194c93b0e919543b5a5c1b3621dab0d4604c983
Bug-Url: https://bugzilla.redhat.com/1342317
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoTest.java
3 files changed, 47 insertions(+), 25 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/58882
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4194c93b0e919543b5a5c1b3621dab0d4604c983
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: webadmin: v2v-fix message and load button enabling
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: webadmin: v2v-fix message and load button enabling
......................................................................
webadmin: v2v-fix message and load button enabling
While opening the "import Virtual Machine(s)" dialog, the following
error message always appears on start: "Not available when no Export
Domain is active", although an active export domain does exist and
active. And also "Load" button is enabled while should be disabled.
The reason is that checking export Domain existence for the "Export
Domain" Source is done on VmListModel constructor on initializing while
querying for getting the export Domain is done later on while query
callback returns from backend.
So while opening the dialog, exportDomain is always null.
The same relevant for enabling the "Load" button.
Fixing that bug requires moving the error message and button enabling
checks to later on. Immediate after reading the export domain from DB.
Current behaviour is as follows:
1. While opening the dialog - error message and button disabling
appears only if no export doamin really exists for that DC.
2. Changing the Source from other source back to be "Export Domain" -
no actul checking is done for export domain existence. The previous
status is kept and displayed.
3. Selecting other Data Center for the "export Domain" source - actual
checking is done by querying the DB and in case no export Domain exists
then an err msg in dislayed and "load" button is disabled.
Furtheremore, this fix cleans VMs list while selecting other Data Center
Change-Id: I2e89d26ce8363c111f5df91bc4a214011270c920
Bug-Url: https://bugzilla.redhat.com/1340025
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/ImportVmsPopupPresenterWidget.java
2 files changed, 33 insertions(+), 24 deletions(-)
Approvals:
Jakub Niedermertl: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/58744
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e89d26ce8363c111f5df91bc4a214011270c920
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months