June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix of New Cluster dialog
by tnisan＠redhat.com 01 Jun '16

01 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix of New Cluster dialog ...................................................................... webadmin: Fix of New Cluster dialog ClusterVersionChangeValidation was applied even during new cluster flow causing frontend NPE. Now the validation is only applied during cluster edit. Change-Id: I5bf8a0d6ce41e639077cc5dee25934a55429f7a2 Bug-Url: https://bugzilla.redhat.com/1341078 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58455 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bf8a0d6ce41e639077cc5dee25934a55429f7a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Fix of New Cluster dialog
by tnisan＠redhat.com 01 Jun '16

01 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix of New Cluster dialog ...................................................................... webadmin: Fix of New Cluster dialog ClusterVersionChangeValidation was applied even during new cluster flow causing frontend NPE. Now the validation is only applied during cluster edit. Change-Id: I5bf8a0d6ce41e639077cc5dee25934a55429f7a2 Bug-Url: https://bugzilla.redhat.com/1341078 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Marek Libra: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58445 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bf8a0d6ce41e639077cc5dee25934a55429f7a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in vm fetchers
by ahadas＠redhat.com 01 Jun '16

01 Jun '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in vm fetchers ...................................................................... core: cleanup in vm fetchers VmsStatisticsFetcher only needs to override the poll request from VDSM (GetAllVmStats instead of List) - it doesn't need to override the long VmsListFetcher#fetch for that. In this patch only the relevant part from 'fetch' method that needs to be overridden is extracted to separate method. This change reduce code duplication. In addition, add SupressWarning on intentional unchecked cast and rename a variable for better readability. Change-Id: I3eeb9ebaa04e5c52de8cc6b03162054239d5ddc6 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsListFetcher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsStatisticsFetcher.java 2 files changed, 14 insertions(+), 23 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/58410 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3eeb9ebaa04e5c52de8cc6b03162054239d5ddc6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: imageio: add imageio port to IPTables configuration
by sbonazzo＠redhat.com 01 Jun '16

01 Jun '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: imageio: add imageio port to IPTables configuration ...................................................................... imageio: add imageio port to IPTables configuration Change-Id: I97d8cf3add33caee546e24dc8f316bf619fca3ef Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Amit Aviram: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97d8cf3add33caee546e24dc8f316bf619fca3ef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: centos-7: fix issue with nfs-server
by sbonazzo＠redhat.com 01 Jun '16

01 Jun '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: centos-7: fix issue with nfs-server ...................................................................... centos-7: fix issue with nfs-server fixing issue we got due to the wrong default rwtab configuration for the nfs directories. Change-Id: Id64f81bb344f85c2f13db30c27261475df52263a Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58454 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id64f81bb344f85c2f13db30c27261475df52263a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update to model 4.0.20
by juan.hernandez＠redhat.com 01 Jun '16

01 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to model 4.0.20 ...................................................................... restapi: Update to model 4.0.20 This version of the model includes the following relevant changes: * Remove the `macPool` attribute from the `DataCenter` type. * Add types and services for affinity labels. Change-Id: I8f6660c190582d150e3a8a384e30426083a28f19 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DataCenterInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DataCenterOutAdapter.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DataCenterMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DataCenterMapperTest.java M pom.xml 8 files changed, 22 insertions(+), 18 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f6660c190582d150e3a8a384e30426083a28f19 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix of New Cluster dialog
by tjelinek＠redhat.com 01 Jun '16

01 Jun '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix of New Cluster dialog ...................................................................... webadmin: Fix of New Cluster dialog ClusterVersionChangeValidation was applied even during new cluster flow causing frontend NPE. Now the validation is only applied during cluster edit. Change-Id: I5bf8a0d6ce41e639077cc5dee25934a55429f7a2 Bug-Url: https://bugzilla.redhat.com/1341078 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Marek Libra: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bf8a0d6ce41e639077cc5dee25934a55429f7a2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix NoSuchElementException in StoragePoolQueryBase
by mperina＠redhat.com 01 Jun '16

01 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Fix NoSuchElementException in StoragePoolQueryBase ...................................................................... core: Fix NoSuchElementException in StoragePoolQueryBase Fixes NoSuchElementException in StoragePoolQueryBase caused by patch Ia12b5c3bde7ef5e3732e6209a24dfc04fe5921d9 Change-Id: Ief065523e6e7bd99f4f3b4bfd06b7a2b9b34f9bf Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/StoragePoolQueryBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Martin Mucha: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief065523e6e7bd99f4f3b4bfd06b7a2b9b34f9bf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Adding 'type' to openstacknetworkprovider v3 in ad...
by juan.hernandez＠redhat.com 01 Jun '16

01 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Adding 'type' to openstacknetworkprovider v3 in adapter ...................................................................... restapi: Adding 'type' to openstacknetworkprovider v3 in adapter An openstack network provider can not be created using rest api v3. The problem is the type property which has been added. When the v3 provider is translated to v4, this property must be added. The property must always be set to NEUTRON, as this is the only provider type supported before v4. Change-Id: I63c35a3f9823c199fc00b08a0d17d0a05aa56d33 Bug-Url: https://bugzilla.redhat.com/1340862 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3OpenStackNetworkProviderInAdapter.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Marcin Mirecki: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63c35a3f9823c199fc00b08a0d17d0a05aa56d33 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: moved reference to mac pool from DataCenter to Cluster
by juan.hernandez＠redhat.com 01 Jun '16

01 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: moved reference to mac pool from DataCenter to Cluster ...................................................................... restapi: moved reference to mac pool from DataCenter to Cluster Bug-Url: https://bugzilla.redhat.com/994283 Change-Id: Ie4f5e92803122997c5b300bdca629b59db0d5a45 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ClusterMapperTest.java 2 files changed, 17 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4f5e92803122997c5b300bdca629b59db0d5a45 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0