July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Move SDM checks to BaseImagesCommand
by laravot＠redhat.com 13 Jul '16

13 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: Move SDM checks to BaseImagesCommand ...................................................................... core: Move SDM checks to BaseImagesCommand This patch moves the isDataCenterWithSpm()/isDataCenterWithoutSpm() methods to BaseImagesCommand. Change-Id: I24ca127f873333368e20baaba2d0ac0a9fda3288 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java 2 files changed, 14 insertions(+), 14 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/60662 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24ca127f873333368e20baaba2d0ac0a9fda3288 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-image-uploader: move from fc22 to fc24
by sbonazzo＠redhat.com 13 Jul '16

13 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-image-uploader: move from fc22 to fc24 ...................................................................... ovirt-image-uploader: move from fc22 to fc24 - Drop fc22 on 3.6 since fc22 gone EOL - Move master to fc24 - move 4.0 to its own branch Change-Id: I1f99f1e6d2787119288816d5fb90dcf21b919529 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-image-uploader/ovirt-image-uploader_standard.yaml 1 file changed, 11 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60670 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f99f1e6d2787119288816d5fb90dcf21b919529 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: build: post ovirt-hosted-engine-setup-2.0.1
by sbonazzo＠redhat.com 13 Jul '16

13 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-2.0.1 ...................................................................... build: post ovirt-hosted-engine-setup-2.0.1 Change-Id: I356786bf8bfa83266d2912f4357f00c1f642bdf9 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60604 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I356786bf8bfa83266d2912f4357f00c1f642bdf9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[refs/meta/config]: Allow everyone to push patches and mark them as verified.
by sbonazzo＠redhat.com 13 Jul '16

13 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Allow everyone to push patches and mark them as verified. ...................................................................... Allow everyone to push patches and mark them as verified. Change-Id: I58c4ccdaa37747d1a579e6a668d006fbb8823480 --- M project.config 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58c4ccdaa37747d1a579e6a668d006fbb8823480 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: refs/meta/config Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Fix validation of pool when adding permission
by tnisan＠redhat.com 13 Jul '16

13 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix validation of pool when adding permission ...................................................................... restapi: Fix validation of pool when adding permission When adding a permission we check that there is an object provided, a data center, a virtual machine, etc. But the validation for the pool uses an incorrect name, "vmpool" instead of "vmPool". As a result the validation always fail, and it is impossible to add a permission for a pool. This patch fixes that issue. Change-Id: I8be122dc6be608f5df85864be50d8faa0032806c Bug-Url: https://bugzilla.redhat.com/1354463 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit a6782813d66fecec7ff2f32e610375e4ac6527f9) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUserAssignedPermissionsResourceTest.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8be122dc6be608f5df85864be50d8faa0032806c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: HE: Store maximum number of vcpus to the OVF file
by rgolan＠redhat.com 13 Jul '16

13 Jul '16

Roy Golan has submitted this change and it was merged. Change subject: HE: Store maximum number of vcpus to the OVF file ...................................................................... HE: Store maximum number of vcpus to the OVF file This patch adds the computed number of vCPUs to the OVF file for VMs. The number can then be used by the hosted engine tooling to request the proper topology from VDSM when starting the hosted engine VM and that in turn should enable CPU hotplug for the VM. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1304387 Change-Id: If48ec31ada5888dc4ed90c30db044a188481fc0c Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmCpuCountHelper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 5 files changed, 69 insertions(+), 15 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If48ec31ada5888dc4ed90c30db044a188481fc0c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix validation of pool when adding permission
by juan.hernandez＠redhat.com 13 Jul '16

13 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix validation of pool when adding permission ...................................................................... restapi: Fix validation of pool when adding permission When adding a permission we check that there is an object provided, a data center, a virtual machine, etc. But the validation for the pool uses an incorrect name, "vmpool" instead of "vmPool". As a result the validation always fail, and it is impossible to add a permission for a pool. This patch fixes that issue. Change-Id: I8be122dc6be608f5df85864be50d8faa0032806c Bug-Url: https://bugzilla.redhat.com/1354463 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUserAssignedPermissionsResourceTest.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60483 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8be122dc6be608f5df85864be50d8faa0032806c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Description of engine lock structure
by ahadas＠redhat.com 13 Jul '16

13 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Description of engine lock structure ...................................................................... core: Description of engine lock structure JavaDoc only change Change-Id: I54b2452baaf8351e4a6dfdc3d033e138ae856030 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Arik Hadas: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54b2452baaf8351e4a6dfdc3d033e138ae856030 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: prevent floating vms in unknown status
by ahadas＠redhat.com 13 Jul '16

13 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: prevent floating vms in unknown status ...................................................................... core: prevent floating vms in unknown status On non-responsive treatment, update VMs to unknown status only if they run on some host. This check is done in the database level, with the protection of the database lock. This way, if the monitoring has just updated the VM to down state we will not end up with a VM with unknown status and run_on_vds = NULL. This is not the ideal solution but it seems to cover the most problematic scenario and yet simple. Change-Id: I48c205e9228a32822148332af13c89e51cc80afa Bug-Url: https://bugzilla.redhat.com/1354494 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/dbscripts/vms_sp.sql 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48c205e9228a32822148332af13c89e51cc80afa Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-dwh: removed fc23 build for 3.6
by sbonazzo＠redhat.com 13 Jul '16

13 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-dwh: removed fc23 build for 3.6 ...................................................................... ovirt-dwh: removed fc23 build for 3.6 fc23 is not supported for dwh 3.6 since it requires java 1.7 Change-Id: Id029abdbbdc891cc0a7b153a86037202d15c6f8b Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M jobs/confs/projects/ovirt-dwh/ovirt-dwh_standard.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Shirly Radco: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id029abdbbdc891cc0a7b153a86037202d15c6f8b Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0