July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: core: evict event from cache when manually removed
by tnisan＠redhat.com 12 Jul '16

12 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: evict event from cache when manually removed ...................................................................... core: evict event from cache when manually removed When a event or alert is removed manually from the display in UI, we should also evict the corresponding cache entry for events that have 6he flood mechanism. This patch evict the corresponding event from the cache when it is manually deleted by the user. This solves the following problem : Event E1 with flood time of T1 is raised by the system The issue is fixed by the application administrator Event E1 is raised again within the T1 period The bug was that the second event was suppressed by the flooding mechanism since the cache still holds the first event. In order to solve this BZ there was a need to add code to the RemoveAuditLogByIdCommand to evict the event from the cache, this is done by composing the cache key from the command using the information from the event which is the candidate for the delete operation and generating a this key with the sysadmin user. Change-Id: I0e302aa0bb218f7986cac57b13a90f689d956e19 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1219147 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAuditLogByIdCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java 3 files changed, 59 insertions(+), 9 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60591 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e302aa0bb218f7986cac57b13a90f689d956e19 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: automation: drop suffix for release
by sbonazzo＠redhat.com 12 Jul '16

12 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: drop suffix for release ...................................................................... automation: drop suffix for release Change-Id: Ie8051540367ac3472f097b7c1d4cc4e979d43b9a --- M automation/build-artifacts.sh 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8051540367ac3472f097b7c1d4cc4e979d43b9a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: build: post ovirt-host-deploy-1.5.1
by sbonazzo＠redhat.com 12 Jul '16

12 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-host-deploy-1.5.1 ...................................................................... build: post ovirt-host-deploy-1.5.1 Change-Id: Ic51dca1d29efe7aa397705a3172f37ba25712412 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ChangeLog M automation/build-artifacts.sh M configure.ac M po/pt_BR.po 4 files changed, 9 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic51dca1d29efe7aa397705a3172f37ba25712412 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: build: ovirt-host-deploy-1.5.1
by sbonazzo＠redhat.com 12 Jul '16

12 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-host-deploy-1.5.1 ...................................................................... build: ovirt-host-deploy-1.5.1 Change-Id: Ic8241484bcb73aa28d30bb395e369071448c2c90 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ChangeLog M configure.ac M ovirt-host-deploy.spec.in M po/pt_BR.po 4 files changed, 14 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8241484bcb73aa28d30bb395e369071448c2c90 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: build: ovirt-release40-4.0.1
by sbonazzo＠redhat.com 12 Jul '16

12 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-release40-4.0.1 ...................................................................... build: ovirt-release40-4.0.1 Change-Id: I0830b5052c90135646339a708dfd698273a90c61 --- M configure.ac M ovirt-release40.spec.in 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60594 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0830b5052c90135646339a708dfd698273a90c61 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine : Command-coordination: re-acquire engine lock after ...
by mperina＠redhat.com 12 Jul '16

12 Jul '16

Martin Peřina has submitted this change and it was merged. Change subject: engine : Command-coordination: re-acquire engine lock after engine restart ...................................................................... engine : Command-coordination: re-acquire engine lock after engine restart CoCo needs to reacquire locks on engine restart for commands executing not managed by async task manager and managed by command callback. Change-Id: Ic6c9a92b3b1d6e151127187c1bdb869931ede45f Bug-Url: https://bugzilla.redhat.com/1226561 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsRepository.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/CommandStatus.java 3 files changed, 31 insertions(+), 8 deletions(-) Approvals: Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56643 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6c9a92b3b1d6e151127187c1bdb869931ede45f Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Adding pretty name to OS version format
by tnisan＠redhat.com 12 Jul '16

12 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Adding pretty name to OS version format ...................................................................... core: Adding pretty name to OS version format This patch adds pretty_name to vds_dynamic table and to the data access layer. This field is filled by the VDSM and sent to the engine's VdsBroker which persist it to the database. The pretty name is a friendly representation of the OS release/version and is displayed as a separate field in the UI Host->General->Software sub tab and is also available from the API when getting the host information. Change-Id: I0b1cc2fa4f9e351eae1b855670b3ffe505a2c618 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1346782 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_00_0820_add_vds_dynamic_pretty_name.sql M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql M packaging/dbscripts/vds_sp.sql 15 files changed, 66 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60590 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b1cc2fa4f9e351eae1b855670b3ffe505a2c618 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CommandBase - don't update the command entity always
by laravot＠redhat.com 12 Jul '16

12 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CommandBase - don't update the command entity always ...................................................................... core: CommandBase - don't update the command entity always In change Iae96c executeAction() was changed to only update the command entity if present after the execution. On flows with async tasks a CommandEntity is being created for the root command with special values during the execution, the update done in CommandBase will override those values to different ones. This patch sets the update to be done only on commands with cb/parent command with cb to avoid updating the unneeded entities. Change-Id: I68af8d469ce9f42c8b1230fc4bef23448345b59a Bug-Url: https://bugzilla.redhat.com/1352825 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68af8d469ce9f42c8b1230fc4bef23448345b59a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Conflict with python-daemon-2.1.0
by tnisan＠redhat.com 12 Jul '16

12 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Conflict with python-daemon-2.1.0 ...................................................................... core: Conflict with python-daemon-2.1.0 python-daemon-2.1.0 adds 'initgroups' parameter with default value True. That causes subsequential attempt of changing the process GID (in case the prameter is ommitted), which fails on insufficient privileges. This patch is an alternative approach to patch #58635 Change-Id: Icda9de9f58d0469f4217f12ddcfe40a7d56fab96 Bug-Url: https://bugzilla.redhat.com/1343155 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60579 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icda9de9f58d0469f4217f12ddcfe40a7d56fab96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: builders: stop publish fc22 artifacts
by sbonazzo＠redhat.com 12 Jul '16

12 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: builders: stop publish fc22 artifacts ...................................................................... builders: stop publish fc22 artifacts Avoid to publish fedora 22 artifacts after EOL. Change-Id: I2bb039c9983583235f4979d7e05695a35232788e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/builders/copy-create-job-artifact.yaml 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60585 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bb039c9983583235f4979d7e05695a35232788e Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0