July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: build: ovirt-hosted-engine-setup-2.0.1
by sbonazzo＠redhat.com 12 Jul '16

12 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-2.0.1 ...................................................................... build: ovirt-hosted-engine-setup-2.0.1 Change-Id: I8c957bfe6f127aa9562086a0d2c596f1f8ce9d34 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 13 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60584 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c957bfe6f127aa9562086a0d2c596f1f8ce9d34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: remove msg of Native USB on clusters < 3.2
by tjelinek＠redhat.com 12 Jul '16

12 Jul '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: remove msg of Native USB on clusters < 3.2 ...................................................................... webadmin: remove msg of Native USB on clusters < 3.2 This patch removed the following warning message appeared in New/Edit VM dialog, Console tab, while selecting USB Support to be "Native": "Migration is NOT currently supported using SPICE Native USB redirection on cluster version lower than 3.2". This message is no longer relevant on version 4.0.1 as the lowest supported cluster version is 3.6. Change-Id: I959f5c4e44c686d5e4d30d11cfff834b44b55e78 Bug-Url: https://bugzilla.redhat.com/1351200 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties 4 files changed, 0 insertions(+), 35 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/60484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I959f5c4e44c686d5e4d30d11cfff834b44b55e78 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[v2.0.z]: build: ovirt-hosted-engine-ha-2.0.1
by sbonazzo＠redhat.com 12 Jul '16

12 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-2.0.1 ...................................................................... build: ovirt-hosted-engine-ha-2.0.1 Change-Id: I1f660956aaa3b80a753b62fc41dadfb6fcf17e0c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f660956aaa3b80a753b62fc41dadfb6fcf17e0c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: v2.0.z Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: extract numa-statistics from vm-statistics
by ahadas＠redhat.com 12 Jul '16

12 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: extract numa-statistics from vm-statistics ...................................................................... core: extract numa-statistics from vm-statistics VM numa nodes resided in VmStatistics but were not persisted to the database. This patch changes this: 1. The nodes that are reported by VDSM are now stored in VdsmVm instead 2. The nodes were not persisted but they are expected to be used in the future so as a preparation for that, they are stored in VmAnalyzer and a getter was added in order to be able to fetch it in VmsMonitoring. Change-Id: I487e8507f3642f6274451d4d184461514d7e7e33 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VdsmVm.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java 5 files changed, 32 insertions(+), 29 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I487e8507f3642f6274451d4d184461514d7e7e33 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Yamlize the coverity_analysis job
by eedri＠redhat.com 12 Jul '16

12 Jul '16

Eyal Edri has submitted this change and it was merged. Change subject: Yamlize the coverity_analysis job ...................................................................... Yamlize the coverity_analysis job Change-Id: Ib6da53dc040922bfb3a0debf6cdef1109082121d Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- A jobs/confs/shell-scripts/coverity_analysis.sh A jobs/confs/yaml/jobs/ovirt-engine_master_coverity-analysis.yaml 2 files changed, 71 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6da53dc040922bfb3a0debf6cdef1109082121d Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: persist before validate() only when there is a parent ...
by laravot＠redhat.com 12 Jul '16

12 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: persist before validate() only when there is a parent with cb ...................................................................... core: persist before validate() only when there is a parent with cb Currently we persist the command entity before the validate() check and on failure the command status is updated to ENDED_WITH_FAILURE. We do that so that When there is a parent command with a callback, it will be able to detect that the child command execution failed on that phase. Additionally, the parent is responsible to clear the command hirerchy. When there is no parent command, the command entity will never be cleared/monitored. In this patch the logic is changed so that the command is persisted before the CDA phase only in case there's a parent with a CB, otherwise it'll be persisted on the execution phase. Change-Id: Iae96cb414677c970c91ef860824d2a5ca981d861 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1352825 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java 2 files changed, 22 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae96cb414677c970c91ef860824d2a5ca981d861 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Users with '%' in their password, cannot log in.
by mperina＠redhat.com 12 Jul '16

12 Jul '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: Users with '%' in their password, cannot log in. ...................................................................... aaa: Users with '%' in their password, cannot log in. Login form parameters don't need to be decoded Change-Id: Id1946fa9017b7a01e240a24e3fcca0ff0622300b Bug-Url: https://bugzilla.redhat.com/1352721 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveAuthServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveChangePasswdServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp 4 files changed, 14 insertions(+), 8 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60532 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1946fa9017b7a01e240a24e3fcca0ff0622300b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CommandsCallbackPoller - EXECUTION_FAILED handling
by laravot＠redhat.com 12 Jul '16

12 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CommandsCallbackPoller - EXECUTION_FAILED handling ...................................................................... core: CommandsCallbackPoller - EXECUTION_FAILED handling The initCommandExecutor() method updates command whose exuection wasn't completed to EXECUTION_FAILED status. Command status might be changed on ENDED_WITH_FAILURE even if it wasn't executed yet to indicate failure (for example, when the command fails on the validate() phase), those commands status shouldn't be changed to EXECUTION_FAILED status which is handled by the infrastacture. Change-Id: Ic3eaef060d4e8c148a20c967968838d9101fd45c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1353604 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCallbacksPoller.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3eaef060d4e8c148a20c967968838d9101fd45c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.1]: build: post ovirt-engine-4.0.1.1
by tnisan＠redhat.com 12 Jul '16

12 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: build: post ovirt-engine-4.0.1.1 ...................................................................... build: post ovirt-engine-4.0.1.1 Change-Id: Ia421d868d9aff11cf478ae976c86f7e6b9eb8140 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/ovirt-findbugs-filters/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M pom.xml M version.mak 59 files changed, 66 insertions(+), 63 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60530 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia421d868d9aff11cf478ae976c86f7e6b9eb8140 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-guest-agent[ovirt-4.0]: linux: Fix osinfo script typo as reported in BZ
by vfeenstr＠redhat.com 12 Jul '16

12 Jul '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: linux: Fix osinfo script typo as reported in BZ ...................................................................... linux: Fix osinfo script typo as reported in BZ Previously overlooked typo in the bug report. This fixes this typo. Change-Id: Iebcad103a751537f35a2532bb6c2bc891971ef9d Bug-Url: https://bugzilla.redhat.com/1337942 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> (cherry picked from commit fe036948268ec61b1c485e3b1c30002018d468f3) --- M scripts/ovirt-osinfo 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60556 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebcad103a751537f35a2532bb6c2bc891971ef9d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0