Change in ovirt-engine[ovirt-engine-3.6.9]: engine: add finish report on multi-host network commands
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: add finish report on multi-host network commands
......................................................................
engine: add finish report on multi-host network commands
The change adds reporting of finish applying network changes
to the hosts that were done asynchronously.
Change-Id: I93eeccdd6695ddabbcfe26517fc372134ddc0e6a
Bug-Url: https://bugzilla.redhat.com/1369064
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/util/HostIdToLoggableNameFunction.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/util/ReportFailedChildHostOperationsUtil.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManageNetworkClustersCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/PropagateLabeledNetworksToClusterHostsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/host/util/HostIdToLoggableNameFunctionTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ManageNetworkClustersParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
11 files changed, 308 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/62902
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93eeccdd6695ddabbcfe26517fc372134ddc0e6a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.9
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-3.6.9]: core: add setCustomValues to AuditLogableBase
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: add setCustomValues to AuditLogableBase
......................................................................
core: add setCustomValues to AuditLogableBase
In addition to providing more neat interface, the change enables
adding a collection of custom values to an auditable in a more
efficient way than calling the singlular method for every
collection node from the outside to the auditable.
Change-Id: Ib2be1221bb4c19bce115b4ad8d482d6533467f03
Bug-Url: https://bugzilla.redhat.com/1369064
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java
2 files changed, 54 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/62901
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2be1221bb4c19bce115b4ad8d482d6533467f03
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.9
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-3.6]: core: add setCustomValues to AuditLogableBase
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: add setCustomValues to AuditLogableBase
......................................................................
core: add setCustomValues to AuditLogableBase
In addition to providing more neat interface, the change enables
adding a collection of custom values to an auditable in a more
efficient way than calling the singlular method for every
collection node from the outside to the auditable.
Change-Id: Ib2be1221bb4c19bce115b4ad8d482d6533467f03
Bug-Url: https://bugzilla.redhat.com/1369064
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java
2 files changed, 54 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/62900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2be1221bb4c19bce115b4ad8d482d6533467f03
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: add finish report on multi-host network commands
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: add finish report on multi-host network commands
......................................................................
engine: add finish report on multi-host network commands
The change adds reporting of finish applying network changes
to the hosts that were done asynchronously.
Change-Id: I93eeccdd6695ddabbcfe26517fc372134ddc0e6a
Bug-Url: https://bugzilla.redhat.com/1369064
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/util/HostIdToLoggableNameFunction.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/util/ReportFailedChildHostOperationsUtil.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManageNetworkClustersCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/PropagateLabeledNetworksToClusterHostsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/host/util/HostIdToLoggableNameFunctionTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ManageNetworkClustersParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
11 files changed, 308 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/61350
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93eeccdd6695ddabbcfe26517fc372134ddc0e6a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0]: improve propriety UUID generation
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: improve propriety UUID generation
......................................................................
improve propriety UUID generation
UUID generation is not random enough and may generate in some circumstances
duplicate UUIDs
I was thinking first to use the native PG UUID generator but this seems
complex since the UUID generator functions are provided as a PG
extension that only a super user DB role can install and even if we
handled that in engine-setup, it will solve only local provisioned DB.
In this patch I suggest the following improvements to the
uuid_generate_v1 function
1) Setting a seed before using the random() function
2) Generating the first 8 characters using the clock timestamp value
3) Improve randomness of other generated values
I believe that the above is a pretty simple solution that is sufficient
for our needs
Change-Id: I3f3211f7d83ba2b4a37c5d533911ecd0d7f03e58
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1362459
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/dbscripts/create_functions.sql
1 file changed, 19 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Peřina: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/62859
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f3211f7d83ba2b4a37c5d533911ecd0d7f03e58
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0]: core: fix compensation mechanism in RefreshLunsSizeCommand
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: fix compensation mechanism in RefreshLunsSizeCommand
......................................................................
core: fix compensation mechanism in RefreshLunsSizeCommand
This patch fixes two issues in RefreshLunsSizeCommand's compensation
mechanism:
1. RefreshLunsSizeCommand doesn't contain the required compensation
constructor.
2. The updateStorageDomain method takes a snapshot of the new storage
domain dynamic object instead of the old one, which leads the
compensation of the same object in the db, instead of the old one.
Change-Id: I60d802529533aa073b178c273f4f21c89975b5ea
Bug-Url: https://bugzilla.redhat.com/1370912
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommand.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/62909
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60d802529533aa073b178c273f4f21c89975b5ea
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0]: core: update LUNs in DB on RefreshLunsSizeCommand
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: update LUNs in DB on RefreshLunsSizeCommand
......................................................................
core: update LUNs in DB on RefreshLunsSizeCommand
Previously, RefreshLunsSizeCommand didn't update the luns in the DB
after resizing them, causing an inconsistency between the LUNs real size
and their size in the DB.
This patch takes care of this update right after the PVs are resized.
Change-Id: I71d59b9bacaff5df3d3b2e1ca0908fe978eed7d4
Bug-Url: https://bugzilla.redhat.com/1370101
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
2 files changed, 31 insertions(+), 11 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/62910
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71d59b9bacaff5df3d3b2e1ca0908fe978eed7d4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: packaging: engine-backup: clarify random password
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: engine-backup: clarify random password
......................................................................
packaging: engine-backup: clarify random password
Change the text output to the user when creating an extra postgresql
user with a random password.
Change-Id: I93ee9bd5808f7f713465bc2db5373c5d1181e55b
Bug-Url: https://bugzilla.redhat.com/1369757
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/bin/engine-backup.sh.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/62886
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93ee9bd5808f7f713465bc2db5373c5d1181e55b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: backend: add missing commands' Guid constructors
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: backend: add missing commands' Guid constructors
......................................................................
backend: add missing commands' Guid constructors
The constructor that is used as a part of the compensation process on
startup is the one that receives the command id (Guid), and it should
exist in each class that is annotated with the
'NonTransactiveCommandAttribute' annotation and the annotation's
'forceCompensation' attribute is set to true.
This patch adds these missing constructors and a test to enforce their
existence in the future.
Change-Id: Ic369352b45ce86b3d38b9feb18d02d9d2ed80e9f
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FreezeVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RebootVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ThawVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ConnectStorageToVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageServerConnectionCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetDiskAlignmentCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandCtorsTest.java
14 files changed, 97 insertions(+), 14 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Idan Shaby: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/62894
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic369352b45ce86b3d38b9feb18d02d9d2ed80e9f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine-sdk[sdk_4.0]: Change Ruby to_s method to Python str method
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Change Ruby to_s method to Python str method
......................................................................
Change Ruby to_s method to Python str method
Previously we accidentally transformed id to string
with Ruby to_s method, but we should use Python str
method.
Change-Id: I1117ac6d3cbe8b4a620beee6825392e2fca66377
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit b165709db73cef8214987c42926137a95290c909)
---
M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62906
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1117ac6d3cbe8b4a620beee6825392e2fca66377
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months