Change in ovirt-engine-sdk[master]: Change Ruby to_s method to Python str method
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Change Ruby to_s method to Python str method
......................................................................
Change Ruby to_s method to Python str method
Previously we accidentally transformed id to string
with Ruby to_s method, but we should use Python str
method.
Change-Id: I1117ac6d3cbe8b4a620beee6825392e2fca66377
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62903
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1117ac6d3cbe8b4a620beee6825392e2fca66377
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in jenkins[master]: Reset repo variables values in repo_closure_check.sh
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Reset repo variables values in repo_closure_check.sh
......................................................................
Reset repo variables values in repo_closure_check.sh
Until now, if the STATIC_REPO and EXPERIMENTAL_REPO were set
as env vars, the script would have used them as additional repos,
even if the --static-repo and --experimental-repo was not set.
This patch fixes this bug by reseting the variables.
Change-Id: I9d792560915772db1fb7a9bdce6cb2118c2fc8b5
Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com>
---
M jobs/packaging/repo_closure_check.sh
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sharon Naftaly: Verified; Ready for review
Eyal Edri: Looks good to me; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/62890
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d792560915772db1fb7a9bdce6cb2118c2fc8b5
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0]: engine: add finish report on multi-host network commands
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: add finish report on multi-host network commands
......................................................................
engine: add finish report on multi-host network commands
The change adds reporting of finish applying network changes
to the hosts that were done asynchronously.
Change-Id: I93eeccdd6695ddabbcfe26517fc372134ddc0e6a
Bug-Url: https://bugzilla.redhat.com/1300220
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/util/HostIdToLoggableNameFunction.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/util/ReportFailedChildHostOperationsUtil.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManageNetworkClustersCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/PropagateLabeledNetworksToClusterHostsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/host/util/HostIdToLoggableNameFunctionTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ManageNetworkClustersParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
11 files changed, 279 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/62892
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93eeccdd6695ddabbcfe26517fc372134ddc0e6a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0]: core: add setCustomValues to AuditLogableBase
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: add setCustomValues to AuditLogableBase
......................................................................
core: add setCustomValues to AuditLogableBase
In addition to providing more neat interface, the change enables
adding a collection of custom values to an auditable in a more
efficient way than calling the singlular method for every
collection node from the outside to the auditable.
Change-Id: Ib2be1221bb4c19bce115b4ad8d482d6533467f03
Bug-Url: https://bugzilla.redhat.com/1300220
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java
3 files changed, 56 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/62891
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2be1221bb4c19bce115b4ad8d482d6533467f03
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: update LUNs in DB on RefreshLunsSizeCommand
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: update LUNs in DB on RefreshLunsSizeCommand
......................................................................
core: update LUNs in DB on RefreshLunsSizeCommand
Previously, RefreshLunsSizeCommand didn't update the luns in the DB
after resizing them, causing an inconsistency between the LUNs real size
and their size in the DB.
This patch takes care of this update right after the PVs are resized.
Change-Id: I71d59b9bacaff5df3d3b2e1ca0908fe978eed7d4
Bug-Url: https://bugzilla.redhat.com/1370101
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
2 files changed, 31 insertions(+), 11 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/62837
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71d59b9bacaff5df3d3b2e1ca0908fe978eed7d4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in gerrit-admin[master]: fix get_branches function in gerrit.sh file
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: fix get_branches function in gerrit.sh file
......................................................................
fix get_branches function in gerrit.sh file
The function returns a branch name for the passed pattern
(target milestone) if it exist.
The old command doesn't work so i've replaced it with a new one:
old command ==> git branch --list <pattern>
new command ==> git branch -a | grep -E <pattern>
Change-Id: I8f1fce222a901f3fd2261ed20fc08393b4ad468c
Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com>
---
M hooks/lib/gerrit.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Shlomo Ben David: Verified
Eyal Edri: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62856
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f1fce222a901f3fd2261ed20fc08393b4ad468c
Gerrit-PatchSet: 5
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: fix compensation mechanism in RefreshLunsSizeCommand
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: fix compensation mechanism in RefreshLunsSizeCommand
......................................................................
core: fix compensation mechanism in RefreshLunsSizeCommand
This patch fixes two issues in RefreshLunsSizeCommand's compensation
mechanism:
1. RefreshLunsSizeCommand doesn't contain the required compensation
constructor.
2. The updateStorageDomain method takes a snapshot of the new storage
domain dynamic object instead of the old one, which leads the
compensation of the same object in the db, instead of the old one.
Change-Id: I60d802529533aa073b178c273f4f21c89975b5ea
Bug-Url: https://bugzilla.redhat.com/1370912
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommand.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/62887
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60d802529533aa073b178c273f4f21c89975b5ea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in gerrit-admin[master]: fix change-merged.set_MODIFIED hook
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: fix change-merged.set_MODIFIED hook
......................................................................
fix change-merged.set_MODIFIED hook
The current state of the hook is that it moves bugs from POST ==> MODIFIED
with wrong logic.
Example 1:
bug target milestone: ovirt-4.0.2
change branch: master
After merge the bug will be moved automatically from POST ==> MODIFIED
although it was merged to master to perform a backport
Example 2:
bug target milestone: ovirt-4.0.2
change branch: ovirt-engine-4.0
After merge the bug will be moved automatically from POST ==> MODIFIED
although the branch ovirt-engine-4.0.2 exist
The new logic is as follows:
1. changes on master branch with any bug tm_suffix.
==> bug will be skipped (stay on POST)
2. changes that their branch_suffix match bug tm_suffix
(i.e tm_suffix=4.0.2 and branch_suffix=4.0.2)
==> bug will be moved (POST ==> MODIFIED)
3. changes that their branch_suffix match bug tm_suffix (X.Y) and
branch (ovirt-engine-4.0.4) isn't exist
(i.e tm_suffix=4.0.4 and branch_suffix=4.0)
==> bug will be moved (POST ==> MODIFIED)
else
==> bug will be skipped (stay on POST)
Change-Id: I248346f923e5ec0002526cc7e4e94733c9be4524
Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com>
---
M hooks/custom_hooks/change-merged.set_MODIFIED
1 file changed, 55 insertions(+), 57 deletions(-)
Approvals:
Shlomo Ben David: Verified
Eyal Edri: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62783
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I248346f923e5ec0002526cc7e4e94733c9be4524
Gerrit-PatchSet: 8
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: ui: Import KVM guest image: cannot convert VM with block dev...
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: ui: Import KVM guest image: cannot convert VM with block device to block device
......................................................................
ui: Import KVM guest image: cannot convert VM with block device to block device
Warn the user that we allocate the virtual size of the images until
we have the solution of physical size from Libvirt (bz 1332019)
Bug-Url: https://bugzilla.redhat.com/1362525
Change-Id: I1d254930978629bdc79459556ccded650668a9b1
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalSourceModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
5 files changed, 39 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Shahar Havivi: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62540
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d254930978629bdc79459556ccded650668a9b1
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: Import KVM guest image: cannot convert VM with block d...
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: core: Import KVM guest image: cannot convert VM with block device to block device
......................................................................
core: Import KVM guest image: cannot convert VM with block device to block device
For now the solution is to allocate the virtual size of the images until
we have the physical size from Libvirt (bz 1332019)
Change-Id: I8b71719b3b960528320cb625eca1e88b4e2c1145
Bug-Url: https://bugzilla.redhat.com/1362525
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java
1 file changed, 24 insertions(+), 0 deletions(-)
Approvals:
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/62427
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b71719b3b960528320cb625eca1e88b4e2c1145
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months