September 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Make CommandHelper.canDoAction accept CommandContext
by tnisan＠redhat.com 26 Sep '16

26 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Make CommandHelper.canDoAction accept CommandContext ...................................................................... core: Make CommandHelper.canDoAction accept CommandContext Currently, the CommandHelper gets ExecutionContext, which lacks the session ID of the caller command. Building the command without a session ID, resulting in having the command without a user in its context. This can cause an unexpected behaviour in some cases, where command validations rely on the currnt user. When developers uses CommandHelper.canDoAction, they don't need to worry about that- they should just clone the command's context and run CommandHelper.canDoAction. This patch changes the signature of CommandHelper.canDoAction, to get a CommandContext. Change-Id: I48e213de4a15480047952a7911de93b4076c040b Related-To: https://bugzilla.redhat.com/64378 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandHelper.java 2 files changed, 3 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Amit Aviram: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48e213de4a15480047952a7911de93b4076c040b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Improve error logging in HostMonitoring
by tnisan＠redhat.com 26 Sep '16

26 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Improve error logging in HostMonitoring ...................................................................... core: Improve error logging in HostMonitoring 1. Moves stacktrace logging into DEBUG log level 2. Replaces 'Vds' with 'host' 3. Adds host name into log message Change-Id: I6b429c27db5c886acb415802ba2287796b558fdd Bug-Url: https://bugzilla.redhat.com/1377310 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/HostMonitoring.java 1 file changed, 10 insertions(+), 9 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b429c27db5c886acb415802ba2287796b558fdd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: README: removing "(optional)" from mandatory prerequisite
by sbonazzo＠redhat.com 26 Sep '16

26 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: README: removing "(optional)" from mandatory prerequisite ...................................................................... README: removing "(optional)" from mandatory prerequisite Change-Id: Id3bfd4f960125c8a599ab7c3de6bef53deac94d3 Bug-Url: https://bugzilla.redhat.com/1379354 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M README.adoc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Ido Rosenzwig: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3bfd4f960125c8a599ab7c3de6bef53deac94d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: added link to moVirt to the welcome page
by tjelinek＠redhat.com 26 Sep '16

26 Sep '16

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: added link to moVirt to the welcome page ...................................................................... engine: added link to moVirt to the welcome page moVirt is quite stable and has couple of hundred of community users already. The community feedback is great (4.7 stars out of 5 on play store). It is time to expose it even more by providing a link on welcome page. Change-Id: If9fb0c42db582ee9fe9ef8bec9728ed1fccd172a Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M packaging/branding/ovirt.brand/messages.properties M packaging/branding/ovirt.brand/welcome_page.template 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64460 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9fb0c42db582ee9fe9ef8bec9728ed1fccd172a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: simplify hibernate vm flow
by ahadas＠redhat.com 26 Sep '16

26 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: simplify hibernate vm flow ...................................................................... core: simplify hibernate vm flow Remove redundant transaction when updating the status of the VM. It is not needed since HibernateVDSCommand extends ManagingVmCommand that locks the VM, thus prevents other updates at the same time. Change-Id: Ia0e0351a8b43413a6e06f89fee0b8d9d13ba364d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HibernateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java 2 files changed, 23 insertions(+), 22 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64432 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0e0351a8b43413a6e06f89fee0b8d9d13ba364d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Null check before model cleanup
by tnisan＠redhat.com 26 Sep '16

26 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Null check before model cleanup ...................................................................... webadmin: Null check before model cleanup Patch gerrit.ovirt.org/63708 introduced improved model cleanup yet in cases where the model is already null due to a missing null check a UI exception will be thrown (for instance when closing a dialog with ESC) Bug-Url: https://bugzilla.redhat.com/1379312 Change-Id: I89b94e175352a25019bfcabf1af70ea9a615af83 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64458 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89b94e175352a25019bfcabf1af70ea9a615af83 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Diff file added to jenkins check patch
by eedri＠redhat.com 26 Sep '16

26 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Diff file added to jenkins check patch ...................................................................... Diff file added to jenkins check patch On top of the above I have already reset the color in the differences.html file Change-Id: I4fa89e25cdc1bf67b9cd17b196deec10ddc4ced9 --- M jobs/confs/shell-scripts/htmldiff.sh M jobs/confs/yaml/publishers/exported-artifacts.yaml M jobs/confs/yaml/templates/standard-stage.yaml 3 files changed, 11 insertions(+), 11 deletions(-) Approvals: Eyal Edri: Looks good to me; Ready for merge Gil Shinar: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fa89e25cdc1bf67b9cd17b196deec10ddc4ced9 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: remove builds for cli on master branch
by eedri＠redhat.com 26 Sep '16

26 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: remove builds for cli on master branch ...................................................................... remove builds for cli on master branch ovirt-engine-cli development has stopped at 3.6 and there is no new code for 4.0 or master. Change-Id: Ia2dbd0ac9b7b0cd6ec5fc31c923450527953b2cc Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-cli/ovirt-engine-cli_build-artifacts.yaml 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Looks good to me Eyal Edri: Verified; Looks good to me; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2dbd0ac9b7b0cd6ec5fc31c923450527953b2cc Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in create vm
by ahadas＠redhat.com 26 Sep '16

26 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in create vm ...................................................................... core: cleanup in create vm 1. Replace usages of DBFacade with injections 2. Standardize log message on error 3. Minor layout issues Change-Id: I4b29b135b0be2d1353b7e06e9c76946287b21f98 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java 1 file changed, 36 insertions(+), 34 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b29b135b0be2d1353b7e06e9c76946287b21f98 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: improve log message on failure to initiate migrate vm
by ahadas＠redhat.com 26 Sep '16

26 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: improve log message on failure to initiate migrate vm ...................................................................... core: improve log message on failure to initiate migrate vm Print the IDs of the VM and the host and the error message as done in other VM related commands. Change-Id: I1a02131682ee0aae82278c6de6ed1e9dde755fe7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a02131682ee0aae82278c6de6ed1e9dde755fe7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0