Change in ovirt-engine[ovirt-engine-3.6.9]: core: do not pass Collections.singleton
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: do not pass Collections.singleton
......................................................................
core: do not pass Collections.singleton
probably command coordination serializes parameters to db. When
deserializing them (exact behavior is to be tested)
Collections.singleton cannot be deserialized due to missing default
constructor.
Change-Id: Icf2a08e713fac43a531297dc4eeb285a9205045d
Bug-Url: https://bugzilla.redhat.com/1372950
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Martin Mucha: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63313
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf2a08e713fac43a531297dc4eeb285a9205045d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.9
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0.4]: core: align db scripts to support upgrade
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: align db scripts to support upgrade
......................................................................
core: align db scripts to support upgrade
DB upgrade scripts content were amended to match their name.
Duplicate db script for change disk status to OK was added in order to
be activated when upgrading from minor versions 4.0.3 and below.
Change-Id: I369c81d4e72945bd7189e1e93523c6810a2f4e29
Bug-Url: https://bugzilla.redhat.com/1339660
Signed-off-by: Yanir Quinn <yquinn(a)redhat.com>
(cherry picked from commit 5138cdc)
Signed-off-by: Yanir Quinn <yquinn(a)redhat.com>
---
M packaging/dbscripts/upgrade/04_00_0790_change_vm_device_null_plugged_values_to_false.sql
M packaging/dbscripts/upgrade/04_00_0800_remove_hosted_engine_storage_domain_name_config_value.sql
M packaging/dbscripts/upgrade/04_00_0810_change_disk_status_to_ok.sql
A packaging/dbscripts/upgrade/04_00_0890_change_disk_status_to_ok_amended.sql
4 files changed, 29 insertions(+), 17 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Yanir Quinn: Verified
--
To view, visit https://gerrit.ovirt.org/63470
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I369c81d4e72945bd7189e1e93523c6810a2f4e29
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.4
Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0.4]: core: Set the Custom CV at old snapshot preview
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Set the Custom CV at old snapshot preview
......................................................................
core: Set the Custom CV at old snapshot preview
VM's custom compatibility version is set when previewing
snapshot with memory taken in previous cluster version.
The UpdateVmCommand from TryBackToAllSnapshotsOfVmCommand
is called to set the CCV.
The CCV keeps to be set after the preview commit
but is rolled back when undo the preview.
Change-Id: Ic181e144fa41cf77afe00feda58709f725eb2831
Bug-Url: https://bugzilla.redhat.com/1364456
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java
2 files changed, 39 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Marek Libra: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63474
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic181e144fa41cf77afe00feda58709f725eb2831
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.4
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Add CDI and unit tests for CpuProfileHelper
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add CDI and unit tests for CpuProfileHelper
......................................................................
core: Add CDI and unit tests for CpuProfileHelper
Change-Id: I3dd1d953812f057801c97ee752868a9965344036
Bug-Url: https://bugzilla.redhat.com/1371888
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/ProfileValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelperTest.java
12 files changed, 160 insertions(+), 48 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/63143
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3dd1d953812f057801c97ee752868a9965344036
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Fix cpu profile group permissions
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix cpu profile group permissions
......................................................................
core: Fix cpu profile group permissions
Use PermissionDao to correctly check
cpu profile user and group permissions.
Change-Id: I055c67bc9e3cb6024198e7ee021de3950357f0e1
Bug-Url: https://bugzilla.redhat.com/1371888
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/dbscripts/cpu_profiles_sp.sql
M packaging/dbscripts/create_views.sql
15 files changed, 65 insertions(+), 106 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/63142
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I055c67bc9e3cb6024198e7ee021de3950357f0e1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: webadmin: v2v VMware handle special chars in uri
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: v2v VMware handle special chars in uri
......................................................................
webadmin: v2v VMware handle special chars in uri
VMware seems to allow all special chars for data center, folder and cluster
name.
We should handle it correctlly in v2v engine side by encoding those
chars before sening them to VDSM.
This solution encodes the VMware data center and VMware cluster parts of
the uri
i.e. for uri vpx://user@vcenter/DATACENTER/CLUSTER/esxi?no_verify=1
we encode the DATACENTER and CLUSTER parts, including folders if
exists. Other parts of the uri are left decoded.
In UI we continue to display the data center and cluster as was
originally typed by the user (decoded).
The encoding is done on frontend and therefore should be also done while
using REST apis for v2v.
known problems:
If you include the following chars in VMware datacenter or
cluster, the import failed:
%, \, / ->
error of "Could not find datacenter specified in uri..." appesrs
&, +, =, ? ->
error of "virt-v2v: internal error: invalid argument: cannot fetch XML"
a bug is opened on libvirt/virt-v2v for that.
Change-Id: I5341fe5d7d12567258ffc07ee6fea4a025c6faeb
Bug-Url: https://bugzilla.redhat.com/1356767
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineException.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/VmwarePropertiesModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
3 files changed, 12 insertions(+), 6 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/63464
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5341fe5d7d12567258ffc07ee6fea4a025c6faeb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: build: post ovirt-hosted-engine-setup-2.0.2.1
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: build: post ovirt-hosted-engine-setup-2.0.2.1
......................................................................
build: post ovirt-hosted-engine-setup-2.0.2.1
Change-Id: I80676829ba948bdca2f187706a0ebb7a9e8d5e32
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M automation/build-artifacts.sh
M configure.ac
M ovirt-hosted-engine-setup.spec.in
3 files changed, 11 insertions(+), 5 deletions(-)
Approvals:
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/63475
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80676829ba948bdca2f187706a0ebb7a9e8d5e32
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-2.0
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
8 years, 3 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: build: ovirt-hosted-engine-setup-2.0.2.1
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: build: ovirt-hosted-engine-setup-2.0.2.1
......................................................................
build: ovirt-hosted-engine-setup-2.0.2.1
Change-Id: I11af0338456c0a46677421a81f11d2435b3565fc
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M automation/build-artifacts.sh
M configure.ac
M ovirt-hosted-engine-setup.spec.in
3 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/63473
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I11af0338456c0a46677421a81f11d2435b3565fc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-2.0
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
8 years, 3 months
Change in ovirt-engine[master]: aaa: sso: print only error message on login screen if fail
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: aaa: sso: print only error message on login screen if fail
......................................................................
aaa: sso: print only error message on login screen if fail
Before we printed full cause of the error to login screen, when login
failed. This error was unreadable to user, as user is interested only
to error message not full Java stack trace. This patch changes it, so
we now only show the error.
Change-Id: I45bfabbea16bac2e47506744d8e5c3429bbabe90
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373092
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveAuthServlet.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified
Martin Peřina: Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63298
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45bfabbea16bac2e47506744d8e5c3429bbabe90
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6]: core: do not pass Collections.singleton
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: do not pass Collections.singleton
......................................................................
core: do not pass Collections.singleton
probably command coordination serializes parameters to db. When
deserializing them (exact behavior is to be tested)
Collections.singleton cannot be deserialized due to missing default
constructor.
Change-Id: Icf2a08e713fac43a531297dc4eeb285a9205045d
Bug-Url: https://bugzilla.redhat.com/1372950
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63314
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf2a08e713fac43a531297dc4eeb285a9205045d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months