Change in ovirt-engine[master]: core: Set hosted engine maintenance mode to none after upgrade
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Set hosted engine maintenance mode to none after upgrade
......................................................................
core: Set hosted engine maintenance mode to none after upgrade
When upgrading hosted engine host, the engine first moves it
to maintenance mode in the engine and sets local maintenance
to true on the host itself.
After finishing the upgrade the engine sets the host status to
up but doesn't change the local maintenance status of the host.
This fix sets the local maintenance to false after upgrade if the
host is a hosted engine host.
Change-Id: I48f193b99dc8e71aef7e36532d36c551f9927ecd
Bug-Url: https://bugzilla.redhat.com/1370907
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 38 insertions(+), 8 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Moti Asayag: Looks good to me, but someone else must approve
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/62888
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48f193b99dc8e71aef7e36532d36c551f9927ecd
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: restapi: Add disk attachments collection to a VM in export d...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Add disk attachments collection to a VM in export domain
......................................................................
restapi: Add disk attachments collection to a VM in export domain
Change-Id: Id0fe5632244d7f61422fe1bdfc28a8ed8f7e2473
Bug-Url: https://bugzilla.redhat.com/1371024
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDiskAttachmentResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDiskAttachmentsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java
3 files changed, 75 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63394
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0fe5632244d7f61422fe1bdfc28a8ed8f7e2473
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: backend: improve getLunsToUpdateInDb
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: backend: improve getLunsToUpdateInDb
......................................................................
backend: improve getLunsToUpdateInDb
The method getLunsToUpdateInDb in
SyncLunsInfoForBlockStorageDomainCommand used to iterate over lunsFromDb
inside the iteration over lunsFromVgInfo, i.e run with a complexity of
O(n^2), and the method updateLunsInDb used to make one db call for each
update (existing lun that should be updated or a new lun).
This patch is responsible for the following things:
- Improves the complexity of getLunsToUpdateInDb to O(n) by using hash
maps.
- Makes less db calls - two calls in the worst case, one for updating
all the luns that need to be updated and one for new luns.
- Fixes a bug introduced by I9cfd2 - if lunsFromVgInfo had more luns
than lunsFromDb, and it contained luns with a new pv id (not identical
to any lun in lunsFromDb), they would not be updated (happens when a
user manually extends a vg with a new pv without using oVirt).
Now these luns will be updated.
- Previously, if lunsFromVgInfo and lunsFromDb contained the same number
of luns, but one of the luns in lunsFromVgInfo had a new pv id, it
wouldn't be updated. Now it will.
- Adds some tests to SyncLunsInfoForBlockStorageDomainCommandTest.
Change-Id: I6b3f790b7a5c7bbed75ed4346d4f958cca0ed153
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommandTest.java
2 files changed, 113 insertions(+), 78 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/63277
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b3f790b7a5c7bbed75ed4346d4f958cca0ed153
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: backend: call getVgInfo after extending a storage domain
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: backend: call getVgInfo after extending a storage domain
......................................................................
backend: call getVgInfo after extending a storage domain
When extending a storage domain, we get the new luns' information from
vdsm when calling ConnectAllHostsToLun (in validate()) and save it to
the db. This causes an inconsistency between the luns' real info from
the storage and their info as we save it in the db, for example a
different physical volume id.
Calling getVgInfo right after the extend itself gets us the new info,
and saving the new info fixes this bug.
Change-Id: I6a987f1f81f6ecad56a6854090fbba21131cbabd
Bug-Url: https://bugzilla.redhat.com/1371960
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ExtendSANStorageDomainCommand.java
1 file changed, 26 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
Liron Aravot: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/63084
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a987f1f81f6ecad56a6854090fbba21131cbabd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: scheduling: Remove null handling from PerHostMessages
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: scheduling: Remove null handling from PerHostMessages
......................................................................
scheduling: Remove null handling from PerHostMessages
Change-Id: I22040512ce2eb0496e13f30a386e96081ab39212
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PerHostMessages.java
2 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
Martin Sivák: Verified
Roman Mohr: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Jenny Tokar: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/59483
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22040512ce2eb0496e13f30a386e96081ab39212
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: Removing unused code in numa nodes
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Removing unused code in numa nodes
......................................................................
core: Removing unused code in numa nodes
Change-Id: I61c2e5aea1a76f6a629842e6e912b147b9cbb8be
Bug-Url: https://bugzilla.redhat.com/1148039
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDaoTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NumaUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VdsmVm.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java
M packaging/dbscripts/numa_sp.sql
10 files changed, 2 insertions(+), 517 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/60881
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61c2e5aea1a76f6a629842e6e912b147b9cbb8be
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: config: Increase KVM VCPU limit to 288
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: config: Increase KVM VCPU limit to 288
......................................................................
config: Increase KVM VCPU limit to 288
Increase limit for cluster 4.1 where 288 VCPUs will be supported.
Change-Id: I663faf16eef4641be375275fca27b446c872b934
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/63498
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I663faf16eef4641be375275fca27b446c872b934
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: engine: fix String.format() args in EngineException
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine: fix String.format() args in EngineException
......................................................................
engine: fix String.format() args in EngineException
Fix the String.format() call to handle special chars in args in a more
nicer way in EngineException class.
Change-Id: Idf190aecf46ecd7ba6762f532220691d5b82802a
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineException.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/63488
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf190aecf46ecd7ba6762f532220691d5b82802a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-live[ovirt-live-4.0]: build: oVirt Live 4.0.4 RC2
by lveyde＠redhat.com
Lev Veyde has submitted this change and it was merged.
Change subject: build: oVirt Live 4.0.4 RC2
......................................................................
build: oVirt Live 4.0.4 RC2
Change-Id: I28044fca784ca3748bf57fee333e024e14914b6f
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
---
M centos-7/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Lev Veyde: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Rafael Martins: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/63504
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28044fca784ca3748bf57fee333e024e14914b6f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-4.0
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in jenkins[master]: Changing repoclosure jobs to run inside mock
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Changing repoclosure jobs to run inside mock
......................................................................
Changing repoclosure jobs to run inside mock
All run in fc24 mock env
Change-Id: I0a40367b63b36f7079df819364e6db4b7d3684a0
Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com>
---
M jobs/confs/groovy-scripts/repos-check-closure_post-build.groovy
M jobs/confs/projects/repos-check-closure/repos-check-closure.yaml
M jobs/confs/shell-scripts/repos-check-closure_run-check.sh
M jobs/confs/yaml/templates/repos-check-closure.yaml
4 files changed, 70 insertions(+), 52 deletions(-)
Approvals:
Sharon Naftaly: Verified; Ready for review
Eyal Edri: Ready for merge
Barak Korren: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63330
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a40367b63b36f7079df819364e6db4b7d3684a0
Gerrit-PatchSet: 7
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <david(a)dcaro.es>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months