Change in ovirt-engine-sdk[sdk_4.0]: Release 4.0.1
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Release 4.0.1
......................................................................
Release 4.0.1
Change-Id: I8111fd25a292f2f0ff9a0eba35b012dad5460014
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M generator/pom.xml
M packaging/build.sh
M pom.xml
A sdk/CHANGES.adoc
M sdk/lib/ovirtsdk4/version.py
M sdk/pom.xml
M sdk/setup.py
7 files changed, 40 insertions(+), 7 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63415
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8111fd25a292f2f0ff9a0eba35b012dad5460014
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: use only vm dynamic data when intialization vm-jobs mo...
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: use only vm dynamic data when intialization vm-jobs monitoring
......................................................................
core: use only vm dynamic data when intialization vm-jobs monitoring
Change-Id: I717f13aef53a8d07fb1aa00ca118976c90c1c6be
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoring.java
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/63030
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I717f13aef53a8d07fb1aa00ca118976c90c1c6be
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk[sdk_4.0]: Improve type checking
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Improve type checking
......................................................................
Improve type checking
Currently the types of the parameters passed to service methods aren't
checked. As a result when there are errors they are detected too late,
and the error messages aren't clear. To avoid that this patch changes
the SDK so that the types of these parameters are checked inmediately,
and so that the error messages are explicit. For example, if the user
tries to start a virtual machine with wrong parameters like this:
vm_service.start(
use_cloud_init='true',
vm=types.Disk(
...
)
)
The SDK will inmediately raise a 'TypeError' exception with the
following error message:
The 'use_cloud_init' parameter should be of type 'bool',
but it is of type 'str'. The 'vm' parameter should be of
type 'Vm', but it is of type 'Disk'.
The type check is performed by the new 'Service._check_types' function. The
calls to this function are added to the beginning of each service method. For
example, for the 'VmService.start' method:
# Check the types of the parameters:
Service._check_types([
('async', async, bool),
('filter', filter, bool),
('pause', pause, bool),
('use_cloud_init', use_cloud_init, bool),
('use_sysprep', use_sysprep, bool),
('vm', vm, types.Vm),
])
Change-Id: Icb77aa4327dfff0ee0ea9bf8d2a1cf0b70c1ec90
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit ca085e490a59eb469c54299a5e3ff0561e6a96db)
---
M generator/src/main/java/org/ovirt/sdk/python/PythonBuffer.java
M generator/src/main/java/org/ovirt/sdk/python/PythonNames.java
A generator/src/main/java/org/ovirt/sdk/python/PythonTypeReference.java
M generator/src/main/java/org/ovirt/sdk/python/ReadersGenerator.java
M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java
M generator/src/main/java/org/ovirt/sdk/python/TypesGenerator.java
M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java
M sdk/lib/ovirtsdk4/service.py
A sdk/tests/test_check_types.py
9 files changed, 379 insertions(+), 88 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63411
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb77aa4327dfff0ee0ea9bf8d2a1cf0b70c1ec90
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk[master]: Improve type checking
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Improve type checking
......................................................................
Improve type checking
Currently the types of the parameters passed to service methods aren't
checked. As a result when there are errors they are detected too late,
and the error messages aren't clear. To avoid that this patch changes
the SDK so that the types of these parameters are checked inmediately,
and so that the error messages are explicit. For example, if the user
tries to start a virtual machine with wrong parameters like this:
vm_service.start(
use_cloud_init='true',
vm=types.Disk(
...
)
)
The SDK will inmediately raise a 'TypeError' exception with the
following error message:
The 'use_cloud_init' parameter should be of type 'bool',
but it is of type 'str'. The 'vm' parameter should be of
type 'Vm', but it is of type 'Disk'.
The type check is performed by the new 'Service._check_types' function. The
calls to this function are added to the beginning of each service method. For
example, for the 'VmService.start' method:
# Check the types of the parameters:
Service._check_types([
('async', async, bool),
('filter', filter, bool),
('pause', pause, bool),
('use_cloud_init', use_cloud_init, bool),
('use_sysprep', use_sysprep, bool),
('vm', vm, types.Vm),
])
Change-Id: Icb77aa4327dfff0ee0ea9bf8d2a1cf0b70c1ec90
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/python/PythonBuffer.java
M generator/src/main/java/org/ovirt/sdk/python/PythonNames.java
A generator/src/main/java/org/ovirt/sdk/python/PythonTypeReference.java
M generator/src/main/java/org/ovirt/sdk/python/ReadersGenerator.java
M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java
M generator/src/main/java/org/ovirt/sdk/python/TypesGenerator.java
M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java
M sdk/lib/ovirtsdk4/service.py
A sdk/tests/test_check_types.py
9 files changed, 379 insertions(+), 88 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63222
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb77aa4327dfff0ee0ea9bf8d2a1cf0b70c1ec90
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: use only vm dynamic data when initializing resource ma...
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: use only vm dynamic data when initializing resource manager
......................................................................
core: use only vm dynamic data when initializing resource manager
Change-Id: I153941dc643d63123d02ecd796d2fb74bb92dce8
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M packaging/dbscripts/vms_sp.sql
3 files changed, 16 insertions(+), 10 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/63029
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I153941dc643d63123d02ecd796d2fb74bb92dce8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk[master]: Add test for iSCSI discover
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Add test for iSCSI discover
......................................................................
Add test for iSCSI discover
This patch adds a test to verify that the host 'iscsi_discover' method
generates the correct response body, as this worked incorrectly in the
past.
Change-Id: I62a5348babf0db1e7419122ceb2d4a2389345d21
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A sdk/tests/test_iscsi_discover.py
1 file changed, 60 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62a5348babf0db1e7419122ceb2d4a2389345d21
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0.4]: webadmin: infinite loop in new VM/pool dialog
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: infinite loop in new VM/pool dialog
......................................................................
webadmin: infinite loop in new VM/pool dialog
Open new VM/pool dialog and pick a template which had non-null custom
compatibility version, the dialog ends up in infinite refresh loop.
The reason was that the CoreVmBaseToUnitBuilder.postBuild called the
model.getCustomCompatibilityVersion().setSelectedItem(vm.getCustomCompatibilityVersion());
all the time regardless of the fact it changed or not. This change leads to a
full refresh of the whole dialog, including this builder.
Fixed by setting this value only if changed.
Change-Id: I6c2e24faf1793f9de0e973ee41425f7cd32ea922
Bug-Url: https://bugzilla.redhat.com/1373204
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
(cherry picked from commit a453c83060eba01a630ab7fcdff5645e168ceed8)
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CoreVmBaseToUnitBuilder.java
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63395
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c2e24faf1793f9de0e973ee41425f7cd32ea922
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.4
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: query only dynamic data of migrating vms
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: query only dynamic data of migrating vms
......................................................................
core: query only dynamic data of migrating vms
The query for VM that are being migrated is used in 2 places
that do not actually need the whole VM data but only the one
inside VmDynamic so can use a cheaper query.
Change-Id: Ib72949de53af0adea9da8477b7a01590533298af
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M packaging/dbscripts/vms_sp.sql
7 files changed, 23 insertions(+), 27 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/63237
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib72949de53af0adea9da8477b7a01590533298af
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-ruby[sdk_4.0]: [maven-release-plugin] prepare for next development iteration
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: [maven-release-plugin] prepare for next development iteration
......................................................................
[maven-release-plugin] prepare for next development iteration
Change-Id: I5de78ec6b9d5ae4b6476808c6f6e6a6ee14a1aa5
---
M generator/pom.xml
M pom.xml
M sdk/pom.xml
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63399
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5de78ec6b9d5ae4b6476808c6f6e6a6ee14a1aa5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine-sdk-ruby[sdk_4.0]: restapi: Update to model 4.0.33
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Update to model 4.0.33
......................................................................
restapi: Update to model 4.0.33
The more relevant changes included in the new version of the model are
the following:
* Add the `custom_scheduling_policy_properties` attribute to the
`Cluster` type.
* Add services and types to support transfer of images.
* Remove the `add` and `remove` operations of virtual machine
CDROMs.
* Fix the type of the `usages` attribute of the `Network` type, it
should be a list of values of the `NetworkUsage` enum, not a list
of strings.
Change-Id: I2dd1175dca29c58e519f0f8c47379d5a5154b7db
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63396
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2dd1175dca29c58e519f0f8c47379d5a5154b7db
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months