Change in ovirt-engine-sdk-ruby[sdk_4.0]: [maven-release-plugin] prepare release 4.0.1
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: [maven-release-plugin] prepare release 4.0.1
......................................................................
[maven-release-plugin] prepare release 4.0.1
Change-Id: I5a78df248351ab05dab3ba701b1c00543f17c796
---
M generator/pom.xml
M pom.xml
M sdk/pom.xml
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63398
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a78df248351ab05dab3ba701b1c00543f17c796
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine-sdk-ruby[sdk_4.0]: Update CHANGES.adoc for release 4.0.1
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Update CHANGES.adoc for release 4.0.1
......................................................................
Update CHANGES.adoc for release 4.0.1
This patch updates the CHANGES.adoc file, documenting the relevant
changes in release 4.0.1.
Change-Id: Ic2e70d31b501b55504ebfe4645c8543505f64e52
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/CHANGES.adoc
1 file changed, 33 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63397
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2e70d31b501b55504ebfe4645c8543505f64e52
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine-sdk[sdk_4.0]: Fix reading of lists of elements
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Fix reading of lists of elements
......................................................................
Fix reading of lists of elements
Currently the method that read lists of elements doesn't handle
correctly empty elements without close tags. For example, when reading
the following cluster:
<cluster>
...
<required_rng_sources/>
<switch_type>legacy</switch_type>
</cluster>
The 'legacy' value of the 'switch_type' element is interpreted as one of
the values of the previous 'required_rng_sources' list.
This patch fixes the method and introduces two tests to verify that it
works correctly.
Change-Id: I76c3625719c5e2ef327fcee7cec974d740d5f655
Bug-Url: https://bugzilla.redhat.com/1373431
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 576f99f2223d816450bfd05d594873213ece463a)
---
M sdk/ext/ov_xml_reader.c
A sdk/tests/test_cluster_reader.py
M sdk/tests/test_xml_reader.py
3 files changed, 101 insertions(+), 10 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63388
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76c3625719c5e2ef327fcee7cec974d740d5f655
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[ovirt-engine-4.0.4]: restapi: Update to model 4.0.33
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Update to model 4.0.33
......................................................................
restapi: Update to model 4.0.33
The more relevant changes included in the new version of the model are
the following:
* Add the `custom_scheduling_policy_properties` attribute to the
`Cluster` type.
* Add services and types to support transfer of images.
* Remove the `add` and `remove` operations of virtual machine
CDROMs.
* Fix the type of the `usages` attribute of the `Network` type, it
should be a list of values of the `NetworkUsage` enum, not a list
of strings.
Change-Id: I934f27cbb78fa73fe06df85b1673a94d2880b896
Related-To: https://bugzilla.redhat.com/1351576
Related-To: https://bugzilla.redhat.com/1337077
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 6985b51966c29d9ed0e9b6718ae1d28ddbec076c)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmCdromResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmCdromsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3NetworkInAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3NetworkOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmCdromServer.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmCdromsServer.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java
D backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkUsage.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NetworkMapperTest.java
M pom.xml
12 files changed, 50 insertions(+), 49 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63319
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I934f27cbb78fa73fe06df85b1673a94d2880b896
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.4
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 1 month
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: infinite loop in new VM/pool dialog
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: infinite loop in new VM/pool dialog
......................................................................
webadmin: infinite loop in new VM/pool dialog
Open new VM/pool dialog and pick a template which had non-null custom
compatibility version, the dialog ends up in infinite refresh loop.
The reason was that the CoreVmBaseToUnitBuilder.postBuild called the
model.getCustomCompatibilityVersion().setSelectedItem(vm.getCustomCompatibilityVersion());
all the time regardless of the fact it changed or not. This change leads to a
full refresh of the whole dialog, including this builder.
Fixed by setting this value only if changed.
Change-Id: I6c2e24faf1793f9de0e973ee41425f7cd32ea922
Bug-Url: https://bugzilla.redhat.com/1373204
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
(cherry picked from commit a453c83060eba01a630ab7fcdff5645e168ceed8)
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CoreVmBaseToUnitBuilder.java
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63387
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c2e24faf1793f9de0e973ee41425f7cd32ea922
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Added scheduling properties to cluster
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Added scheduling properties to cluster
......................................................................
restapi: Added scheduling properties to cluster
Custom scheduling policy properties added to cluster
in order to support update/add/get operations of these properties and
store them correctly at the back end.
See examples below:
GET /clusters/{cluster:id} :
<cluster>
<custom_scheduling_policy_properties/>
<property>
<name>{name}</name>
<value>{value}</value>
</property>
...
<custom_scheduling_policy_properties/>
</cluster>
PUT /clusters/{cluster:id}
<cluster>
<custom_scheduling_policy_properties/>
<property>
<name>{name}</name>
<value>{value}</value>
</property>
...
</custom_scheduling_policy_properties>
</cluster>
Change-Id: Ib1f3fad300e9fc79690b15159ca780ba7f97449a
Bug-Url: https://bugzilla.redhat.com/1351576
Signed-off-by: yquinn <yquinn(a)redhat.com>
(cherry picked from commit f4154ca)
Signed-off-by: Yanir Quinn <yquinn(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
1 file changed, 22 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
Yanir Quinn: Verified
--
To view, visit https://gerrit.ovirt.org/63380
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1f3fad300e9fc79690b15159ca780ba7f97449a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine-sdk-ruby[master]: Fix reading of lists of elements
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Fix reading of lists of elements
......................................................................
Fix reading of lists of elements
Currently the method that read lists of elements doesn't handle
correctly empty elements without close tags. For example, when reading
the following cluster:
<cluster>
...
<required_rng_sources/>
<switch_type>legacy</switch_type>
</cluster>
The 'legacy' value of the 'switch_type' element is interpreted as one of
the values of the previous 'required_rng_sources' list. This patch fixes
the method and introduces two tests to verify that it works correctly.
Change-Id: Id1495e873642aadd09ba3dd578077346f17e873e
Bug-Url: https://bugzilla.redhat.com/1373436
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/ext/ovirtsdk4c/ov_xml_reader.c
A sdk/spec/cluster_reader_spec.rb
M sdk/spec/xml_reader_spec.rb
3 files changed, 79 insertions(+), 4 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63389
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1495e873642aadd09ba3dd578077346f17e873e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine-sdk-ruby[sdk_4.0]: Fix reading of lists of elements
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Fix reading of lists of elements
......................................................................
Fix reading of lists of elements
Currently the method that read lists of elements doesn't handle
correctly empty elements without close tags. For example, when reading
the following cluster:
<cluster>
...
<required_rng_sources/>
<switch_type>legacy</switch_type>
</cluster>
The 'legacy' value of the 'switch_type' element is interpreted as one of
the values of the previous 'required_rng_sources' list. This patch fixes
the method and introduces two tests to verify that it works correctly.
Change-Id: Id1495e873642aadd09ba3dd578077346f17e873e
Bug-Url: https://bugzilla.redhat.com/1373436
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/ext/ovirtsdk4c/ov_xml_reader.c
A sdk/spec/cluster_reader_spec.rb
M sdk/spec/xml_reader_spec.rb
3 files changed, 79 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63393
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1495e873642aadd09ba3dd578077346f17e873e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine-sdk-java[master]: Add tests for some recent fixes
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Add tests for some recent fixes
......................................................................
Add tests for some recent fixes
This patch adds tests for some fixes which was recently fixed:
* Fix tag names of action parameters
* Don't return null from send method in case of failure
* Avoid of reading fault response in case response body is empty
This patch also adds test for proper reading of Cluster object.
Change-Id: I6d38c4c4085a874ea288e014d1a9e60164f15b23
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
A sdk/src/test/java/org/ovirt/engine/sdk4/ClusterReaderTest.java
A sdk/src/test/java/org/ovirt/engine/sdk4/IscsiDiscoverTest.java
M sdk/src/test/java/org/ovirt/engine/sdk4/VmsServiceTest.java
3 files changed, 138 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63391
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d38c4c4085a874ea288e014d1a9e60164f15b23
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6.9]: core: Allow null cpu_profile_id in the DB
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Allow null cpu_profile_id in the DB
......................................................................
core: Allow null cpu_profile_id in the DB
Will not throw NPE if VM has null cpu_profile_id in the DB.
Change-Id: Iad6281415ab0e9637bc12ecc0b9a9cfe8529f93e
Bug-Url: https://bugzilla.redhat.com/1373090
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java
4 files changed, 30 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/63382
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad6281415ab0e9637bc12ecc0b9a9cfe8529f93e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.9
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month