Change in ovirt-engine[ovirt-engine-3.6]: webadmin: v2v VMware handle special chars in uri
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: v2v VMware handle special chars in uri
......................................................................
webadmin: v2v VMware handle special chars in uri
VMware seems to allow all special chars for data center, folder and cluster
name.
We should handle it correctlly in v2v engine side by encoding those
chars before sening them to VDSM.
This solution encodes the VMware data center and VMware cluster parts of
the uri
i.e. for uri vpx://user@vcenter/DATACENTER/CLUSTER/esxi?no_verify=1
we encode the DATACENTER and CLUSTER parts, including folders if
exists. Other parts of the uri are left decoded.
In UI we continue to display the data center and cluster as was
originally typed by the user (decoded).
The encoding is done on frontend and therefore should be also done while
using REST apis for v2v.
known problems:
If you include the following chars in VMware datacenter or
cluster, the import failed:
%, \, / ->
error of "Could not find datacenter specified in uri..." appesrs
&, +, =, ? ->
error of "virt-v2v: internal error: invalid argument: cannot fetch XML"
a bug is opened on libvirt/virt-v2v for that.
Change-Id: I5341fe5d7d12567258ffc07ee6fea4a025c6faeb
Bug-Url: https://bugzilla.redhat.com/1379363
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineException.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/VmwarePropertiesModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
3 files changed, 12 insertions(+), 6 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/64461
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5341fe5d7d12567258ffc07ee6fea4a025c6faeb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: upgrade: avoid relying on cluster name from the answer file
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: upgrade: avoid relying on cluster name from the answer file
......................................................................
upgrade: avoid relying on cluster name from the answer file
Avoid relying on cluster name from the answer file since the
user can rename it or move the host to a different cluster.
Change-Id: Iaea4a67b36c2ee1b3032a6ed72f71a3e65b27633
Bug-Url: https://bugzilla.redhat.com/1377778
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/gr-he-upgradeappliance/engine/misc.py
1 file changed, 9 insertions(+), 8 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Rafael Martins: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/64360
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaea4a67b36c2ee1b3032a6ed72f71a3e65b27633
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-2.0
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: backend: Migrate IsoDomainListSynchronizer to CDI
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: backend: Migrate IsoDomainListSynchronizer to CDI
......................................................................
backend: Migrate IsoDomainListSynchronizer to CDI
Change-Id: I3a8712073a750a8f97cfd2d460d7f2eb42f1a5f4
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/ChangeDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ActivateStorageDomainCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/IsoDomainListSynchronizer.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/GetImageByIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/GetImagesListQueryBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
10 files changed, 119 insertions(+), 102 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/64065
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a8712073a750a8f97cfd2d460d7f2eb42f1a5f4
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Fix match disk profile to storage domain
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix match disk profile to storage domain
......................................................................
core: Fix match disk profile to storage domain
Problem cause:
A. When a template has a disk which is allocated to more than one
storage domain, it will contain for that disk image:
- A list of storage domains
- A list of disk profiles that belong to each storage domain
B. Creating a VM from that template using REST will :
- Select the first storage domain from the list
- Select the first disk profile from the list
Note : VM creation via UI selects a specific storage domain and a
specific disk profile which is associated with that storage domain.
There is no option to leave these values empty -
unlike a REST call where these values can be dismissed.
Consequence:
In cases where the selected disk profile is not associated with
the selected storage domain -
the VM will not be created due to this inconsistency.
Fix:
The disk profile is selected according to the selected
storage domain (out of the possible storage domains).
Change-Id: I2fd4b91842d8f8f6de5cb5e5a538e335c0fcfede
Bug-Url: https://bugzilla.redhat.com/1364792
Signed-off-by: yquinn <yquinn(a)redhat.com>
(cherry picked from commit 276df6effc6d14bc99fec4f75dfef97f30ef8d0d)
Signed-off-by: Yanir Quinn <yquinn(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelperTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
19 files changed, 260 insertions(+), 32 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Yanir Quinn: Verified
--
To view, visit https://gerrit.ovirt.org/63146
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fd4b91842d8f8f6de5cb5e5a538e335c0fcfede
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: webadmin: Enable force option in host maintenance
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: webadmin: Enable force option in host maintenance
......................................................................
webadmin: Enable force option in host maintenance
Enable 'force' option for gluster host maintenance. Force
option will be used to override the gluster quorum/self-heal
related check.
'Force' option in the RemoveConfirmationPopup is used for
stopping gluster services. So, created a new ConfirmationModel
for host maintenance.It will have 'Stop Gluster service' option
additional to ConfirmationModel. With this patch 'Force'
option will be used for force maintenance and 'stopGlusterService'
option will be used for stopping gluster services.
Change-Id: Id236d07a783514c9b49bd2092efeb5c825c58d02
Bug-Url: https://bugzilla.redhat.com/1213291
Bug-Url: https://bugzilla.redhat.com/1196433
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/HostMaintenanceConfirmationPopupPresenterWidget.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/HostMaintenanceConfirmationPopupView.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/HostMaintenanceConfirmationPopupView.ui.xml
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/HostMaintenanceConfirmationModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java
9 files changed, 377 insertions(+), 15 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/59102
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id236d07a783514c9b49bd2092efeb5c825c58d02
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in otopi[master]: automation: common.sh: Zero dnf.conf
by didi＠redhat.com
Yedidyah Bar David has submitted this change and it was merged.
Change subject: automation: common.sh: Zero dnf.conf
......................................................................
automation: common.sh: Zero dnf.conf
This is a hack, needed until jenkins properly supports
fedora24/python3/dnf.
Change-Id: I6eae84cd81a400769531060cb21af29c193d2e31
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M automation/common.sh
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/64000
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6eae84cd81a400769531060cb21af29c193d2e31
Gerrit-PatchSet: 11
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in otopi[master]: core: Use python3 on fedora >= 23
by didi＠redhat.com
Yedidyah Bar David has submitted this change and it was merged.
Change subject: core: Use python3 on fedora >= 23
......................................................................
core: Use python3 on fedora >= 23
Change-Id: If70f3cfda60d42a85f6ce8de1f4464ca940468e9
Bug-Url: https://bugzilla.redhat.com/1316950
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M automation/build-artifacts.packages
M automation/build-artifacts.sh
D automation/check-merged.packages
A automation/check-merged.packages
M automation/check-merged.sh
D automation/check-patch.packages
A automation/check-patch.packages
M automation/check-patch.sh
A automation/common.sh
R automation/coverage.rc.in
M otopi.spec.in
M src/bin/otopi
12 files changed, 92 insertions(+), 96 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified; Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/59831
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If70f3cfda60d42a85f6ce8de1f4464ca940468e9
Gerrit-PatchSet: 28
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in otopi[master]: packagers: minidnf: Install correct libselinux python package
by didi＠redhat.com
Yedidyah Bar David has submitted this change and it was merged.
Change subject: packagers: minidnf: Install correct libselinux python package
......................................................................
packagers: minidnf: Install correct libselinux python package
For python3, install libselinux-python3 if selinux can't be imported.
Also, reexec only if package was installed.
Change-Id: I0538e12c3b55e8570dd678f8689c9bc9129737c1
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M src/otopi/minidnf.py
1 file changed, 26 insertions(+), 14 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63240
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0538e12c3b55e8570dd678f8689c9bc9129737c1
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: gluster: handle new exceptions in create brick
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: gluster: handle new exceptions in create brick
......................................................................
gluster: handle new exceptions in create brick
https://gerrit.ovirt.org/#/c/62773/3 introduced
two new exceptions related to setting selinux
labels on the gluster bricks. Adding the newly
introduced exceptions to engine.
Change-Id: I49de4ee60a3f4c499dcd50f5327c2c961b50d463
Bug-Url: https://bugzilla.redhat.com/1368474
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
7 files changed, 16 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sahina Bose: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/62841
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I49de4ee60a3f4c499dcd50f5327c2c961b50d463
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: remove an unused argument from updateDiskImageProfiles...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: remove an unused argument from updateDiskImageProfilesList.
......................................................................
core: remove an unused argument from updateDiskImageProfilesList.
The argument "user" is unused and therefor shouldn't be in
updateDiskImageProfilesList's signature.
Change-Id: I809b02cb313532609b83a768c4916884095a800b
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/64382
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I809b02cb313532609b83a768c4916884095a800b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months