September 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: core: disallow boot protocol to be null
by tnisan＠redhat.com 26 Sep '16

26 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: disallow boot protocol to be null ...................................................................... core: disallow boot protocol to be null in response to bug 1371119 we should not allow null values in boot protocol columns any more. Change-Id: I535b0945b00b5462cd8a7158f22d63b94f531cd2 Bug-Url: https://bugzilla.redhat.com/1371119 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/04_00_0930_disallow_boot_protocol_to_be_null.sql 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I535b0945b00b5462cd8a7158f22d63b94f531cd2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: build: ovirt-live-4.0.4 GA
by sbonazzo＠redhat.com 26 Sep '16

26 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-4.0.4 GA ...................................................................... build: ovirt-live-4.0.4 GA Change-Id: If4fbc8b1a2b18fe06f7159bfc9ccf6d1634835ed Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64455 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4fbc8b1a2b18fe06f7159bfc9ccf6d1634835ed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix LockingInvocationHandler so that it does not throw...
by masayag＠redhat.com 26 Sep '16

26 Sep '16

Moti Asayag has submitted this change and it was merged. Change subject: core: fix LockingInvocationHandler so that it does not throw UndeclaredThrowableException ...................................................................... core: fix LockingInvocationHandler so that it does not throw UndeclaredThrowableException when using java.reflect.Proxy, proxied instance might fail with runtime exception. In that case, if InvocationHandler contains simple: return method.invoke(instance, args); such runtime exception will be 'upgraded' to controlled InvocationTargetException. If caller is not aware of proxy being used (which is kinda a point in using them), and he will not declare it in throws clause (which he shouldn't do anyways) then this controlled exception will be wrapped inside of UndeclaredThrowableException runtime exception. This is totally not desirable. Change-Id: I92e226147710666559781a42e3c25fc619dd727e Bug-Url: https://bugzilla.redhat.com/1378045 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/LockedObjectFactory.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/lock/LockedObjectFactoryTest.java 2 files changed, 28 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Martin Mucha: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92e226147710666559781a42e3c25fc619dd727e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: README: Fix spelling issue
by sbonazzo＠redhat.com 26 Sep '16

26 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: README: Fix spelling issue ...................................................................... README: Fix spelling issue Change-Id: I91e2f7b44f2981eeb6669ae61b5ef42dc2d19fda Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M README.adoc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Simone Tiraboschi: Looks good to me, but someone else must approve Ido Rosenzwig: Verified Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91e2f7b44f2981eeb6669ae61b5ef42dc2d19fda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Improve error logging in HostMonitoring
by mperina＠redhat.com 26 Sep '16

26 Sep '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Improve error logging in HostMonitoring ...................................................................... core: Improve error logging in HostMonitoring 1. Moves stacktrace logging into DEBUG log level 2. Replaces 'Vds' with 'host' 3. Adds host name into log message Change-Id: I6b429c27db5c886acb415802ba2287796b558fdd Bug-Url: https://bugzilla.redhat.com/1377310 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/HostMonitoring.java 1 file changed, 10 insertions(+), 9 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Martin Peřina: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b429c27db5c886acb415802ba2287796b558fdd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Fix bz.py module and added more functionality
by eedri＠redhat.com 25 Sep '16

25 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Fix bz.py module and added more functionality ...................................................................... Fix bz.py module and added more functionality The following functionality has been added: class: Bug class that includes constructor for setting bug structure The bug structure will include: 1. product 2. status 3. title 4. flags 5. target_rel 6. milestone 7. component 8. classification. functions: extract_bug_info(bug_id) function that will return bug data (default info, flags and external tracker info) from the passed bug_id extract_flags(list_of_flags_dicts) function that will return dict of flags with only flag name (key) and flag status (value) get_bug_urls(commit) function that will return list of bug urls from the passed commit message get_bug_ids(bug_urls) function that will return set of unique bug ids from the passed list of bug urls. Change-Id: I39f52bb9d2332cdc1ddb84ab4d412fd94ff75bbc Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/lib/bz.py 1 file changed, 136 insertions(+), 50 deletions(-) Approvals: Shlomo Ben David: Verified Eyal Edri: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39f52bb9d2332cdc1ddb84ab4d412fd94ff75bbc Gerrit-PatchSet: 4 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in detection of paused vm
by ahadas＠redhat.com 25 Sep '16

25 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in detection of paused vm ...................................................................... core: cleanup in detection of paused vm Minor cleanup in the part that handles a detection of VM that switches to Paused status in VmAnalyzer. Note that switch from MigratingFrom to Paused is expected to be handled soon as part of post-copy migration. Change-Id: Ie055bfc716195e88e4889a57627dc53eb38a27f7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie055bfc716195e88e4889a57627dc53eb38a27f7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in detection of suspended vm
by ahadas＠redhat.com 25 Sep '16

25 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in detection of suspended vm ...................................................................... core: cleanup in detection of suspended vm Change-Id: Ie921c5894a44e0aeb9144554338bbcc6b3d8e938 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64417 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie921c5894a44e0aeb9144554338bbcc6b3d8e938 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in detection of migration failure
by ahadas＠redhat.com 25 Sep '16

25 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in detection of migration failure ...................................................................... core: cleanup in detection of migration failure Inline VmAnalyzer#afterMigrationFrom. Change-Id: I7acc7fd57d3dc5af6805050888b93729e83dfb14 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 11 insertions(+), 16 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7acc7fd57d3dc5af6805050888b93729e83dfb14 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[refs/meta/config]: Update permissions for ovirt-engine project
by sbendavi＠redhat.com 25 Sep '16

25 Sep '16

Shlomo Ben David has submitted this change and it was merged. Change subject: Update permissions for ovirt-engine project ...................................................................... Update permissions for ovirt-engine project I've updated refs/* to include only owner. All the standard permissions are inherited from All-Project Example: Code-Review = -1..+1 group Registered Users (inherited from All-Project) Verified = -1..+1 group Registered Users (inherited from All-Project) This specific project is customized with permission per branch. Example: Code-Review = -2..+2 group ovirt-engine-stable-maintainers Continuous-Integration = -1..+1 group ovirt-engine-master-maintainers Change-Id: Ic505ff9fbbb884bff012a065dfa4a2e2e3478c96 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M groups M project.config 2 files changed, 15 insertions(+), 59 deletions(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic505ff9fbbb884bff012a065dfa4a2e2e3478c96 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: refs/meta/config Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0