Change in jenkins[master]: Re-factored standard-ci builders
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged.
Change subject: Re-factored standard-ci builders
......................................................................
Re-factored standard-ci builders
- Reduced code duplicaiton
- Improved log output and error checking
- Inlined the code into YAML for easier maintainance (!include* is the
root of a lot of evil)
Change-Id: I73754db1ab0b363362a80210b8c2e312bf248541
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-994
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
---
D jobs/confs/shell-scripts/standard_build_artifacts.sh
D jobs/confs/shell-scripts/standard_build_artifacts_manual.sh
D jobs/confs/shell-scripts/standard_check_merged.sh
D jobs/confs/shell-scripts/standard_check_patch.sh
M jobs/confs/yaml/builders/standard.yaml
M jobs/confs/yaml/templates/standard-stage.yaml
6 files changed, 44 insertions(+), 128 deletions(-)
Approvals:
Eyal Edri: Looks good to me
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Gil Shinar: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69375
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I73754db1ab0b363362a80210b8c2e312bf248541
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <david(a)dcaro.es>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in jenkins[master]: publish ovn master to 4.1 repos until we'll have a branch
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: publish ovn master to 4.1 repos until we'll have a branch
......................................................................
publish ovn master to 4.1 repos until we'll have a branch
Change-Id: If97626c25f92d7f96ca3231a9f133d54cec5b1f3
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/projects/ovirt-provider-ovn/ovirt-provider-ovn.yaml
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Gil Shinar: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69418
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If97626c25f92d7f96ca3231a9f133d54cec5b1f3
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1]: core: mention which Mac address is used log.
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: mention which Mac address is used log.
......................................................................
core: mention which Mac address is used log.
when Add nic fail on Mac address is already in use,
the Mac address is not mentioned in any log.
Change-Id: Ib84478ea4e4cfde0fdac93fed98c5c0d8330666c
Bug-Url: https://bugzilla.redhat.com/1396995
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MacAddressValidator.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 24 insertions(+), 14 deletions(-)
Approvals:
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69421
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib84478ea4e4cfde0fdac93fed98c5c0d8330666c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[master]: core: VmDeviceUtils respect allowed duplicate mac addresses.
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: VmDeviceUtils respect allowed duplicate mac addresses.
......................................................................
core: VmDeviceUtils respect allowed duplicate mac addresses.
The check if canPlugInterface of VmDeviceUtils is extended to
respect allowed duplicate mac addresses using macpool.
Change-Id: I880a7c90ae9c2c120ba0bfd7abafd90f8f3f8de8
Bug-Url: https://bugzilla.redhat.com/1404130
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
3 files changed, 27 insertions(+), 13 deletions(-)
Approvals:
Dominik Holler: Verified
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/68587
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I880a7c90ae9c2c120ba0bfd7abafd90f8f3f8de8
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
7 years, 3 months
Change in ovirt-engine[master]: restapi: Fix 'Image' broken link
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Fix 'Image' broken link
......................................................................
restapi: Fix 'Image' broken link
Link structure not declared correctly in LinkHelper;
decleration that Images may reside under the
ImageTransfer entity was missing.
Bug-Url: https://bugzilla.redhat.com/1408578
Change-Id: I3655353f537e879464285ba05731ad91b66d62af
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69222
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3655353f537e879464285ba05731ad91b66d62af
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[master]: core: HostedEngineHelper StorageDomainDao injection
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: HostedEngineHelper StorageDomainDao injection
......................................................................
core: HostedEngineHelper StorageDomainDao injection
Change-Id: I64b0d3d027fa09a63a34617e94beefd6e0057e8e
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/69403
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64b0d3d027fa09a63a34617e94beefd6e0057e8e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[master]: core: HostedEngineHelper type inference
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: HostedEngineHelper type inference
......................................................................
core: HostedEngineHelper type inference
Change-Id: Ie118de0aac52b7a2cf8d2acd73e5777cdcb306cd
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/69402
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie118de0aac52b7a2cf8d2acd73e5777cdcb306cd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine-sdk[sdk_4.1]: Fix writing 'id' attribute for enum values
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Fix writing 'id' attribute for enum values
......................................................................
Fix writing 'id' attribute for enum values
Currently the SDK doesn't generate correctly the XML for attributes
named 'id' that contain enum values. For example, when writing the list
of SSO methods of a virtual machine it generates the following:
<sso>
<methods>
<method>
<id>guest_agent</id>
</method>
</methods>
</sso>
But it should write the following instead, as the 'id' model attribute
should always be represented as an XML attribute:
<sso>
<methods>
<method id="guest_agent"/>
</methods>
</sso>
This patch addresses that issue, which was mostly a typo in the
generator of the XML writing code.
Change-Id: I52065c9aeba4628155cbdc638bf0334834f4a15d
Bug-Url: https://bugzilla.redhat.com/1408839
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 7aaafb7bac31622d351b5921e30266656128cfc3)
---
M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java
A sdk/tests/test_sso_writer.py
2 files changed, 68 insertions(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52065c9aeba4628155cbdc638bf0334834f4a15d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine-sdk-ruby[sdk_4.0]: Fix writing 'id' attribute for enum values
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Fix writing 'id' attribute for enum values
......................................................................
Fix writing 'id' attribute for enum values
Currently the SDK doesn't generate correctly the XML for attributes
named 'id' that contain enum values. For example, when writing the list
of SSO methods of a virtual machine it generates the following:
<sso>
<methods>
<method>
<id>guest_agent</id>
</method>
</methods>
</sso>
But it should write the following instead, as the 'id' model attribute
should always be represented as an XML attribute:
<sso>
<methods>
<method id="guest_agent"/>
</methods>
</sso>
This patch addresses that issue, which was mostly a typo in the
generator of the XML writing code.
Change-Id: I211c87dba59c6c9a52858b8b0faa9ddd0cf99fda
Related-To: https://bugzilla.redhat.com/1408839
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit e77ad2991a1e11e5ffd5a99ce4700ba4897d20e3)
(cherry picked from commit a047b0e8497d5e7c05ccf58d85b4854c281cdf24)
---
M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java
A sdk/spec/sso_writer_spec.rb
2 files changed, 38 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69409
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I211c87dba59c6c9a52858b8b0faa9ddd0cf99fda
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine-sdk[sdk_4.1]: Sync CHANGES.adoc with 4.0
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Sync CHANGES.adoc with 4.0
......................................................................
Sync CHANGES.adoc with 4.0
This patch synchronizes the CHANGES.adoc file with the 4.0 branch.
Change-Id: Ia61da60107e59b12f6e7da6b6a1306059d925a85
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit 5ad7e5ed8f54a61549399f2ac0258e56bc984692)
---
A sdk/CHANGES.adoc
1 file changed, 91 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69059
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia61da60107e59b12f6e7da6b6a1306059d925a85
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months