January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin, userportal: Remove unused login result classes
by Code Review 23 Jan '17

23 Jan '17

>From Vojtech Szocs <vszocs(a)redhat.com>: Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Remove unused login result classes ...................................................................... webadmin,userportal: Remove unused login result classes This patch removes VdcLoginReturnValueBase and the associated custom serializer. Since GWT UI no longer has a dedicated login screen, those classes are not needed anymore. Change-Id: Ibb1f4cea2c8d201c67a6173658db4a2096d55f3e Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcLoginReturnValueBase.java D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/action/VdcLoginReturnValueBase_CustomFieldSerializer.java 2 files changed, 0 insertions(+), 58 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/68016 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb1f4cea2c8d201c67a6173658db4a2096d55f3e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix disks allocation label appearing twice
by Code Review 23 Jan '17

23 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix disks allocation label appearing twice ...................................................................... webadmin: fix disks allocation label appearing twice Stop the Disks allocation label from appearing twice in the New Template dialog and do not show an empty Disks Allocation section when the VM has no disks attached Change-Id: If062e871c3f3915414e2f82476018edb4b72a275 Bug-Url: https://bugzilla.redhat.com/1414056 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml 2 files changed, 4 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Benny Zlotnik: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If062e871c3f3915414e2f82476018edb4b72a275 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: jsonrpc: version bump
by Code Review 23 Jan '17

23 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: jsonrpc: version bump ...................................................................... jsonrpc: version bump Bug-url: https://bugzilla.redhat.com/1364791 Change-Id: I7805d1b0cb75e829092e71e6fefe31e7629f7d6a Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Tal Nisan: Looks good to me, approved; Passed CI tests Martin Peřina: Looks good to me, but someone else must approve Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/71001 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7805d1b0cb75e829092e71e6fefe31e7629f7d6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Highlight path input in new domain popup when conn...
by Code Review 23 Jan '17

23 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Highlight path input in new domain popup when connection exists ...................................................................... webadmin: Highlight path input in new domain popup when connection exists When attempting to create a new file domain and the connection exists as a part of an existing storage domain an error message appears, in that case the path input should be highlighted as well to let the user know which input needs to be fixed Change-Id: I3b5258255b28ef5b7a8195664d1b66f409749ccf Bug-Url: https://bugzilla.redhat.com/1414984 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/70970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b5258255b28ef5b7a8195664d1b66f409749ccf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Extract messages section from expander in new NFS ...
by Code Review 23 Jan '17

23 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Extract messages section from expander in new NFS domain popup ...................................................................... webadmin: Extract messages section from expander in new NFS domain popup The messages section was inside of the 'Custom Connection Parameters' expander which was closed by default resulting in error messages not to be shown unless the expander was open. The section was moved out of the expander. Change-Id: Ica61a3bf9eb540971ec74721038e59a26bd828f4 Bug-Url: https://bugzilla.redhat.com/1414984 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/70965 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica61a3bf9eb540971ec74721038e59a26bd828f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-wgt: Require newer vdagent
by Code Review 23 Jan '17

23 Jan '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-wgt: Require newer vdagent ...................................................................... ovirt-wgt: Require newer vdagent Change-Id: I08dd74b0f892da6d4456396dcb559bc404a23b1b Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M jobs/confs/projects/ovirt-wgt/ovirt-wgt_create-rpms.yaml 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08dd74b0f892da6d4456396dcb559bc404a23b1b Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Don't use any for primitives and wrappers
by Code Review 23 Jan '17

23 Jan '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Don't use any for primitives and wrappers ...................................................................... core: Don't use any for primitives and wrappers anyWrapper() has the same semantics as any(Wrapper.class) and any(primitive.class), but is clearer and easier to read. This patch replaces all those instances with Mockito's built-in helper matchers in order to clean up the code. Change-Id: I871abf441e9e46a9ba03550fe02ccc20fb97b7ee Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractGetEntitiesWithPermittedActionParametersQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTestBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/aaa/GetUserBySessionIdQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmWatchdogValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java 15 files changed, 33 insertions(+), 29 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/70304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I871abf441e9e46a9ba03550fe02ccc20fb97b7ee Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Don't use anyObject()
by Code Review 23 Jan '17

23 Jan '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Don't use anyObject() ...................................................................... core: Don't use anyObject() Mockito 2.x has deprecated anyObject(). This patch replaces all its usages with the non-deprecated any(), that has the same semantics. Change-Id: Ie4249faceddde23d4b355ddf4963a9292abdf225 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelperTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManagerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/ScanStorageForUnregisteredDisksCommandTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/log/LoggedUtilsTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/DocsServletTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/FileServletTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/ServletUtilsTest.java 7 files changed, 24 insertions(+), 28 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/70303 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4249faceddde23d4b355ddf4963a9292abdf225 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Don't use anyMapOf(Class, Class)
by Code Review 23 Jan '17

23 Jan '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Don't use anyMapOf(Class, Class) ...................................................................... core: Don't use anyMapOf(Class, Class) Mockito 1.x's anyMap() returned a raw Map, which would cause unchecked assignment warning when it was used in a generic context. Mockito 2.x fixed this to return a Map<T, S>, and uses Java 8's capabilities to infer the generic type. As a result, anyMapOf(Class, Class) was deprecated, and will be removed in the near future. This patch removes all usages of anyMapOf(Class, Class) and replaces them with the recommended anyMap(). Change-Id: Iec2032f642430b4cde15a3d8b29e00cd6becd047 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJobTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java 5 files changed, 20 insertions(+), 32 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/70301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec2032f642430b4cde15a3d8b29e00cd6becd047 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Replace any(Map.class) with anyMap()
by Code Review 23 Jan '17

23 Jan '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Replace any(Map.class) with anyMap() ...................................................................... core: Replace any(Map.class) with anyMap() anyMap() has the same semantics of any(Map.class), but does not cause an unchecked assignment warning. This patch replaces all the old usages of any(Map.class) with the more modern approach. Change-Id: If8ffeeafad1e8cad852a0499c73f669394d7e9f1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommandTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/MultipleServicesMonitoringStrategyTest.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/70302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8ffeeafad1e8cad852a0499c73f669394d7e9f1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0