Change in ovirt-engine-sdk-java[sdk_4.1]: Check return code of the HTTP reponses
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Check return code of the HTTP reponses
......................................................................
Check return code of the HTTP reponses
If API will return HTTP response code higher than 400,
the SDK should raise ovirtsdk4.Error, with the meassage
what response code was returned by API.
Change-Id: I462c40c30739b502e7f099aa11ade170abf10b6c
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M sdk/src/main/java/org/ovirt/engine/sdk4/internal/services/ServiceImpl.java
M sdk/src/test/java/org/ovirt/engine/sdk4/VmsServiceTest.java
2 files changed, 36 insertions(+), 24 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70334
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I462c40c30739b502e7f099aa11ade170abf10b6c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine-sdk-java[master]: Check return code of the HTTP reponses
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Check return code of the HTTP reponses
......................................................................
Check return code of the HTTP reponses
If API will return HTTP response code higher than 400,
the SDK should raise ovirtsdk4.Error, with the meassage
what response code was returned by API.
Change-Id: I462c40c30739b502e7f099aa11ade170abf10b6c
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M sdk/src/main/java/org/ovirt/engine/sdk4/internal/services/ServiceImpl.java
M sdk/src/test/java/org/ovirt/engine/sdk4/VmsServiceTest.java
2 files changed, 36 insertions(+), 24 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70324
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I462c40c30739b502e7f099aa11ade170abf10b6c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: webadmin: Tag improvements
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Tag improvements
......................................................................
webadmin: Tag improvements
- Added UI plugin event that is fired when a tag is activated
or deactivated. The event object will contain the number of
current activated tags.
- Fixed issue with search string not being cleared after
de-activating a tag.
- Fixed issue where PluginModel were being marked unavailable
due to all ListModels in CommonModel being marked unavailable
even though PluginModels don't care about that field as the
dynamic tab presenters take care of showing/hiding the tab.
- Introduced new ui plugin API to retrieve the root tag node
including all the children.
Change-Id: Ie90a623cf3378bf39557223d19d305bff3faae91
Bug-Url: https://bugzilla.redhat.com/1367072
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/plugin/PluginModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java
M frontend/webadmin/modules/webadmin/exclude-filters.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginEventHandler.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/TagObject.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/TagModelProvider.java
9 files changed, 139 insertions(+), 3 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/68660
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie90a623cf3378bf39557223d19d305bff3faae91
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-hosted-engine-setup[master]: automation: Run the new shiny tests
by Code Review
>From Simone Tiraboschi <stirabos(a)redhat.com>:
Simone Tiraboschi has submitted this change and it was merged.
Change subject: automation: Run the new shiny tests
......................................................................
automation: Run the new shiny tests
Change-Id: I385c24edae2d14c91d7203ba9b72f0874ed27ab3
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M automation/check-patch.packages
M automation/check-patch.packages.fc24
M automation/check-patch.sh
3 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Nir Soffer: Verified
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69054
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I385c24edae2d14c91d7203ba9b72f0874ed27ab3
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: engine: Include mac address in REST to network provider when...
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: engine: Include mac address in REST to network provider when nic is plugged.
......................................................................
engine: Include mac address in REST to network provider when nic is plugged.
The mac address of a nic can be changed when a nic is unplugged.
When plugging in the nic, the mac must be passed in the PUT request
issued during nic plug, so that the mac is updated.
Change-Id: I2efd78188771c773d3a609dc74d68e62650987ef
Signed-off-by: Marcin Mirecki<mmirecki(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1408121
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Marcin Mirecki: Verified
Dominik Holler: Looks good to me, but someone else must approve
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69620
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2efd78188771c773d3a609dc74d68e62650987ef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: build: ovirt-host-deploy-1.6.0
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: ovirt-host-deploy-1.6.0
......................................................................
build: ovirt-host-deploy-1.6.0
Change-Id: I26b6d2d10a87e86100d211605c4e2f468e98f200
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ChangeLog
M automation/build-artifacts.sh
M configure.ac
M ovirt-host-deploy.spec.in
M po/pt_BR.po
5 files changed, 50 insertions(+), 9 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70320
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26b6d2d10a87e86100d211605c4e2f468e98f200
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine-sdk[master]: Deploy documentation to github pages
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Deploy documentation to github pages
......................................................................
Deploy documentation to github pages
Change-Id: I392f5cc19ec6fcb12e7634bc97b56f53ddddc28e
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M .travis.yml
A automation/deploy-on-gh-pages.sh
A automation/travis_rsa.enc
3 files changed, 124 insertions(+), 10 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70084
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I392f5cc19ec6fcb12e7634bc97b56f53ddddc28e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: core: use default mac pool for clusters without DC
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: core: use default mac pool for clusters without DC
......................................................................
core: use default mac pool for clusters without DC
There might exist clusters, which are not linked to any data center.
For those first update statement does not work, leaving possible null
values in cluster.mac_pool_id column, and because of that adding of
constraint will fail.
We have to select some mac pool to be used for such clusters, and
having no information which should be used, we can use only default
mac pool.
Change-Id: If33a212d6c8f730bae8ebe46bc1d6359e95c0495
Bug-Url: https://bugzilla.redhat.com/1410189
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M packaging/dbscripts/upgrade/04_01_0010_add_mac_pool_id_to_vds_group.sql
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Marcin Mirecki: Looks good to me, but someone else must approve
Martin Mucha: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70107
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If33a212d6c8f730bae8ebe46bc1d6359e95c0495
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: he: Removed obsolete workaround
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: he: Removed obsolete workaround
......................................................................
he: Removed obsolete workaround
As BZ#1101554 is fixed,
temporary workaround for vdsm-jsonrpc
deprecation warning is not needed
anymore.
Change-Id: Icd3feec3aba07907dca5e3ca15ca131b56b996b1
Bug-Url: https://bugzilla.redhat.com/1372237
Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com>
(cherry picked from commit a255b50c9ec88d4ff061e766af9e79786777c752)
---
M src/plugins/ovirt-host-common/hosted-engine/configureha.py
1 file changed, 1 insertion(+), 10 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70308
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd3feec3aba07907dca5e3ca15ca131b56b996b1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: packaging: setup: More aggressive autovacuum configuration
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: More aggressive autovacuum configuration
......................................................................
packaging: setup: More aggressive autovacuum configuration
Configuring the autovacuum daemon to be more performant and aggressive.
To make the daemon efficient we a) tell it to start working more frequent
on small number of changes (vacuum_scale_factor), b) spin more workers
as we have more then 3 tables which are updated frequently and we want
to prevent from exhausting the vacuum cost on few tables and starving
other tables from being vacuumed and c) raising the memory amount each
worker have to the passes on the pages would be efficient and quick.
Our v*_dynamic and v*_statistics tables (plus few more) are updated very
frequently as part of our monitoring needs. Even though we keep on
optimizing the amount of updates to the bare minimum we still have to
make sure we don't starve any of those tables otherwise we are in the
risk of bloating the db.
Change-Id: I426de8d2903dc8430e14957738e04757eb4c7eb5
Bug-Url: https://bugzilla.redhat.com/1388433
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine_common/constants.py
M packaging/setup/ovirt_engine_setup/engine_common/database.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/provisioning/postgres.py
M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/provisioning/postgres.py
4 files changed, 124 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Verified
--
To view, visit https://gerrit.ovirt.org/68676
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I426de8d2903dc8430e14957738e04757eb4c7eb5
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months