January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Update QCOW volumes in 4.0 DC to the default QCOW vers...
by Code Review 29 Jan '17

29 Jan '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Update QCOW volumes in 4.0 DC to the default QCOW version. ...................................................................... core: Update QCOW volumes in 4.0 DC to the default QCOW version. After upgrade of oVirt 4.1 if there were any added disks in a 4.0 DC those disks will not be initiailzed with the default QCOW version since the update could be done only if VDSM reported the QCOW version of the new volume which was only introduced in 4.1 DCs. Therefore any added QCOW volumes in DC 4.0 should be initialized with the default QCOW version which is 0.10. Also added an upgrade script that updates all the QCOW volumes that were added to a 4.0 DC after the oVirt upgrade, to the default QCOW version. Change-Id: Ibddd5a8bcac7e13aa98cc2c0bb9f8a48d4ac40f0 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommand.java A packaging/dbscripts/upgrade/04_02_0120_fix_default_qcow_version.sql 3 files changed, 30 insertions(+), 19 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibddd5a8bcac7e13aa98cc2c0bb9f8a48d4ac40f0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: improve domxml builder
by Code Review 29 Jan '17

29 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: improve domxml builder ...................................................................... core: improve domxml builder 1. Add keyboard layout for VNC 2. Add missing documentation 3. Some cleanup Change-Id: Ib8b66f446b2332cf699369f860d939321a32bd50 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java 2 files changed, 63 insertions(+), 23 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/71258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8b66f446b2332cf699369f860d939321a32bd50 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: extract common code for building vm-info
by Code Review 29 Jan '17

29 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: extract common code for building vm-info ...................................................................... core: extract common code for building vm-info Code that is common to both the generation of VM info map/dict and libvirt's Domain XML is extracted from VmInfoBuilderImpl to VmInfoBuildUtils. In general, the builders should not have code that is not directly related to the conversion to the target representation and can be extracted to a utility method. Change-Id: I72c9df7f03c42ef4405a9159fa7e84ca76cec64c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtilsTest.java 5 files changed, 89 insertions(+), 116 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/71257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72c9df7f03c42ef4405a9159fa7e84ca76cec64c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: order VMs by uptime doesn't work
by Code Review 29 Jan '17

29 Jan '17

>From Shahar Havivi <shavivi(a)redhat.com>: Shahar Havivi has submitted this change and it was merged. Change subject: core: order VMs by uptime doesn't work ...................................................................... core: order VMs by uptime doesn't work commit 166f43c3776a2332ce9cdf377795220fdb17f6e1 removed uptime which is needed by the search for sorting VMs by time elapsed Change-Id: Ibceac1cd71db90e16909def12e58b6b0ef189a96 Bug-Url: https://bugzilla.redhat.com/1416837 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_02_0110_add_elapset_time_to_vm_statistics.sql M packaging/dbscripts/vms_sp.sql 5 files changed, 19 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71252 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibceac1cd71db90e16909def12e58b6b0ef189a96 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: add class-level documentation for LibvirtVmXmlBuilder
by Code Review 29 Jan '17

29 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: add class-level documentation for LibvirtVmXmlBuilder ...................................................................... core: add class-level documentation for LibvirtVmXmlBuilder Change-Id: Id992f6324c5dfff9597f286734737ab21ebe46bb Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/71277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id992f6324c5dfff9597f286734737ab21ebe46bb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Update to model 4.2.4
by Code Review 27 Jan '17

27 Jan '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Update to model 4.2.4 ...................................................................... Update to model 4.2.4 The more relevant changes in this new version of the model are the following: * Add `initial_size` attribute to the `Disk` type. * Add new `NetworkFilterParameter` type and related services. * Add `execution_host` link to the `Step` type. * Add new `lease` attribute to virtual machines and templates. * Add `StorageDomainDisks` and `AttachedStorageDomainDisks`. * Add operation to register storage domain disk. Change-Id: I0457d9e3ef01b67a314aae412651512b1cfc9a6a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0457d9e3ef01b67a314aae412651512b1cfc9a6a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: [maven-release-plugin] prepare for next development iteration
by Code Review 27 Jan '17

27 Jan '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare for next development iteration ...................................................................... [maven-release-plugin] prepare for next development iteration Change-Id: I6fd080e45e870779f909516b557ce65845fe3694 --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fd080e45e870779f909516b557ce65845fe3694 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: [maven-release-plugin] prepare release 4.0.8
by Code Review 27 Jan '17

27 Jan '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare release 4.0.8 ...................................................................... [maven-release-plugin] prepare release 4.0.8 Change-Id: I710ab6a5111300a041de56002046d7ee35688f4e --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I710ab6a5111300a041de56002046d7ee35688f4e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Update CHANGES.adoc for release 4.0.8
by Code Review 27 Jan '17

27 Jan '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Update CHANGES.adoc for release 4.0.8 ...................................................................... Update CHANGES.adoc for release 4.0.8 This patch updates the CHANGES.adoc file, documenting the relevant changes in release 4.0.8. Change-Id: I1e4018c26bed2cafe0985d71e96d1b555dbea067 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/CHANGES.adoc 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e4018c26bed2cafe0985d71e96d1b555dbea067 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Update to model 4.0.41
by Code Review 27 Jan '17

27 Jan '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Update to model 4.0.41 ...................................................................... Update to model 4.0.41 The more relevant changes in this new version of the model are the following: * Add new `lease` attribute to virtual machines and templates. Change-Id: I554efd0df8069216387cbeccd38ef91ce7428889 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I554efd0df8069216387cbeccd38ef91ce7428889 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0