Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Edit VM-Pool storage domains logic
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Edit VM-Pool storage domains logic
......................................................................
webadmin: Edit VM-Pool storage domains logic
When searching for the right storage domain to display
in the Edit VM Pool dialog, the condition checked was wrong
in some cases.
Instead of checking for the "imageParentId", the "templateImageId" is
checked.
Change-Id: I99cde07885b1753f66bf213003b845f65fd2c329
Bug-Url: https://bugzilla.redhat.com/1392461
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/69859
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99cde07885b1753f66bf213003b845f65fd2c329
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Edit VM-Pool storage domains logic
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Edit VM-Pool storage domains logic
......................................................................
webadmin: Edit VM-Pool storage domains logic
When searching for the right storage domain to display
in the Edit VM Pool dialog, the condition checked was wrong
in some cases.
Instead of checking for the "imageParentId", the "templateImageId" is
checked.
Change-Id: I99cde07885b1753f66bf213003b845f65fd2c329
Bug-Url: https://bugzilla.redhat.com/1392461
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/69858
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99cde07885b1753f66bf213003b845f65fd2c329
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: backend: handle video devices for vm next run
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: backend: handle video devices for vm next run
......................................................................
backend: handle video devices for vm next run
In case of updating a running VM, the createNextRunSnapshot() updates
the "Number of monitors" property in ovf only if at least one video
device exists for the VM.
Till now we always removed the video devices in
VmDeviceUtils.getVmDevicesForNextRun() - for both Headless and
non Headless VMs (since the video device will be created anyway,
based on the vm.DefaultDislayType value).
But since the "Number of Monitors" based on video device existence, this
patch makes sure such a device exists in case of non headless.
Change-Id: Ifb6e3719ccd44c8371442f928b934de37ad7ab55
Bug-Url: https://bugzilla.redhat.com/1408691
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
2 files changed, 27 insertions(+), 6 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69624
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb6e3719ccd44c8371442f928b934de37ad7ab55
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: core: Replace for loops with Java streams in StorageDomainCo...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Replace for loops with Java streams in StorageDomainCommandBase
......................................................................
core: Replace for loops with Java streams in StorageDomainCommandBase
Change-Id: I55df0fce5f11e64cfb2af0cdd860279e4266d62e
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java
1 file changed, 7 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/69854
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I55df0fce5f11e64cfb2af0cdd860279e4266d62e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: bll: Prevent migration to the same host when balancing
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: bll: Prevent migration to the same host when balancing
......................................................................
bll: Prevent migration to the same host when balancing
This adds a new command - BalanceVm - that is the same as
MigrateVm in all aspects except one:
It allows the scheduler to select the host the VM is
currently running at and does nothing when it is selected
as the best host. All other results cause an ordinary
migration to be started.
Bug-Url: https://bugzilla.redhat.com/1410040
Change-Id: I466a72a546a048a177c55ea2ca6a1a0b697bd53e
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BalanceVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/BasicMigrationHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
6 files changed, 47 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Andrej Krejcir: Looks good to me, but someone else must approve
Yanir Quinn: Verified
--
To view, visit https://gerrit.ovirt.org/69842
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I466a72a546a048a177c55ea2ca6a1a0b697bd53e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: scheduling: Allow balancing to the same host
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: scheduling: Allow balancing to the same host
......................................................................
scheduling: Allow balancing to the same host
Bug-Url: https://bugzilla.redhat.com/1410040
Change-Id: Ib7bcc7c84c23c0e31e4182320482533554c9b5c9
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/BalanceResult.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnit.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnitTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnitTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnitTest.java
6 files changed, 67 insertions(+), 18 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Yanir Quinn: Verified
--
To view, visit https://gerrit.ovirt.org/69843
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7bcc7c84c23c0e31e4182320482533554c9b5c9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Throw exception on VDS detach failure.
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Throw exception on VDS detach failure.
......................................................................
core: Throw exception on VDS detach failure.
Once the engine encounters a SanlockException during force detach
operation, the error that is being presented is an internal error
log since VDSM does not set the failure in its return value.
Instead, we should throw the exception and handle it in the bll
commands.
Change-Id: I88a7ae1a0502e75dbe371b29558422726eca63b7
Bug-Url: https://bugzilla.redhat.com/1373181
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DetachStorageDomainVDSCommand.java
2 files changed, 12 insertions(+), 26 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/69836
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88a7ae1a0502e75dbe371b29558422726eca63b7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in jenkins[master]: jsonrpc 4.1 branch
by Code Review
>From Gil Shinar <gshinar(a)redhat.com>:
Gil Shinar has submitted this change and it was merged.
Change subject: jsonrpc 4.1 branch
......................................................................
jsonrpc 4.1 branch
Change-Id: I4092a521a8233c8548eb6f0637edef100534a30e
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M jobs/confs/projects/vdsm-jsonrpc-java/vdsm-jsonrpc-java_standard.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Gil Shinar: Looks good to me, approved; Ready for merge
Daniel Belenky: Verified; Looks good to me
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me
--
To view, visit https://gerrit.ovirt.org/69857
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4092a521a8233c8548eb6f0637edef100534a30e
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in jenkins[master]: Don't build RPMs for the JBoss modules Maven plugin
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: Don't build RPMs for the JBoss modules Maven plugin
......................................................................
Don't build RPMs for the JBoss modules Maven plugin
The Maven plugin that we use to build JBoss modules is a build-time
dependency that we use exclusively via Maven, and it doesn't need to be
packaged as an RPM package. This patch removes the jobs that build the
RPM packages, renames the .yaml file to use the '_standard' suffix
(insted of 'build-artifacts') and changes the remaining jobs so that
they only run in one distribution, as that is all what is needed to
verify that patches are acceptable.
Change-Id: I44bfd145bc4fe85d7b353011ee665f2ca0c2022f
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
D jobs/confs/projects/ovirt-jboss-modules-maven-plugin/ovirt-jboss-modules-maven-plugin_build-artifacts.yaml
A jobs/confs/projects/ovirt-jboss-modules-maven-plugin/ovirt-jboss-modules-maven-plugin_standard.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml
5 files changed, 15 insertions(+), 45 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69838
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44bfd145bc4fe85d7b353011ee665f2ca0c2022f
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: webadmin: Show note when removing host with deployed hosted ...
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Show note when removing host with deployed hosted engine
......................................................................
webadmin: Show note when removing host with deployed hosted engine
When removing hosts with hosted engine deployed,
the popup shows a warning message.
Change-Id: Ic06ae0a7be300e53bf7f068b955eccd5a37da20b
Bug-Url: https://bugzilla.redhat.com/1349460
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
3 files changed, 14 insertions(+), 1 deletion(-)
Approvals:
Denis Chaplygin: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, but someone else must approve
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Phillip Bailey: Looks good to me, but someone else must approve
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/69628
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic06ae0a7be300e53bf7f068b955eccd5a37da20b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months