Change in ovirt-engine[ovirt-engine-4.1]: engine: ref to gluster_volume in storage_connection
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: engine: ref to gluster_volume in storage_connection
......................................................................
engine: ref to gluster_volume in storage_connection
As part of integrating the flow for gluster volume
based storage domain
Change-Id: I82f6b07ba7bc64a8983528b3d41ba4ca88828ef0
Bug-Url: https://bugzilla.redhat.com/1177782
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDaoImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/inst_sp.sql
M packaging/dbscripts/storages_san_sp.sql
A packaging/dbscripts/upgrade/04_01_0700_add_glustervolume_id_to_storage_server_connection.sql
6 files changed, 46 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sahina Bose: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69004
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82f6b07ba7bc64a8983528b3d41ba4ca88828ef0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: core: Place UseHostNameIdentifier addition properly
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: core: Place UseHostNameIdentifier addition properly
......................................................................
core: Place UseHostNameIdentifier addition properly
Moves UseHostNameIdentifier addition of from update section
to add section, where it belongs.
Change-Id: I47248a74c5aa6a8e479bb7cfe83f8989ec25af2e
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 8 insertions(+), 6 deletions(-)
Approvals:
Martin Peřina: Verified
Ravi Nori: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69756
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47248a74c5aa6a8e479bb7cfe83f8989ec25af2e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: bll: Prevent migration to the same host when balancing
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: bll: Prevent migration to the same host when balancing
......................................................................
bll: Prevent migration to the same host when balancing
This adds a new command - BalanceVm - that is the same as
MigrateVm in all aspects except one:
It allows the scheduler to select the host the VM is
currently running at and does nothing when it is selected
as the best host. All other results cause an ordinary
migration to be started.
Bug-Url: https://bugzilla.redhat.com/1410040
Change-Id: I466a72a546a048a177c55ea2ca6a1a0b697bd53e
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BalanceVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/BasicMigrationHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
6 files changed, 47 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, but someone else must approve
Yanir Quinn: Verified
--
To view, visit https://gerrit.ovirt.org/69012
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I466a72a546a048a177c55ea2ca6a1a0b697bd53e
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: userportal: adjust VM Disks & Snapshots panel height
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: userportal: adjust VM Disks & Snapshots panel height
......................................................................
userportal: adjust VM Disks & Snapshots panel height
Adjust the height of the Virtual Machines' Disks & Snapshots in
the Resources tab to make it fill the bottom of page
Change-Id: Ic833e3340402775dbe0924ef93bbe1d69a34623e
Bug-Url: https://bugzilla.redhat.com/1315771
Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedResourceView.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Benny Zlotnik: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69831
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic833e3340402775dbe0924ef93bbe1d69a34623e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Fix bug in discard checks
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix bug in discard checks
......................................................................
core: Fix bug in discard checks
When passing a list of VM disks to validate if their discard value is
legal a map of a disk to its DiskVmElement is created.
The map is created by fetching all of the VM's DiskVmElements and
iterating on them, however, in some cases not all the VM's disk are sent
for the check (one example is deactivated disks) and the map is created
with a null key (since the corresponding disk does not exist in the list
of disks to check) thus causing an NPE later in the flow.
This was fixed by creating a map entry only if there is a disk in the list
corresponding to the DiskVmElement fetched
Change-Id: I5379f3ced6aeeed27e9ab572ff141c0711bd4454
Bug-Url: https://bugzilla.redhat.com/1409995
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/DiskHandler.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/69698
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5379f3ced6aeeed27e9ab572ff141c0711bd4454
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Remove ternary operator usage in RemoveDiskCommand aud...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Remove ternary operator usage in RemoveDiskCommand audit log
......................................................................
core: Remove ternary operator usage in RemoveDiskCommand audit log
Change the ternary operator usage in RemoveDiskCommand to a more readable
and more maintainable if-else condition in preparation of introducing a
new kind of audit log for disks attached to VMs
Change-Id: I623e64443e7ccd1f81f6c2053c58088f324ca3c6
Related-to: https://bugzilla.redhat.com/1391463
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java
1 file changed, 15 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69696
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I623e64443e7ccd1f81f6c2053c58088f324ca3c6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Upon disk removal log its attached VMs
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Upon disk removal log its attached VMs
......................................................................
core: Upon disk removal log its attached VMs
When removing a disk that is attached to VMs, the log will not report
which VMs the disk was attached to
Bug-Url: https://bugzilla.redhat.com/1391463
Change-Id: I724e37f81ca818fe733b5d23173b60d8b8b103bd
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 29 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69697
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I724e37f81ca818fe733b5d23173b60d8b8b103bd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.0]: core: TransferImage - callback end methods NPE
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: TransferImage - callback end methods NPE
......................................................................
core: TransferImage - callback end methods NPE
When the TransferImageCommand is being executed for pre existing disk
it'll attempt to load the disk from the db on the OnSucceeded/OnFailed
methods using the image id provided in the command parameters while for a
created disk by the command the data will be taken from the AddDisk parameters.
When uploading to a pre existing disk, the id provided by the user
is passed the in the parameters image id (field which should represent a volume)
instead of in the image group id field (which should represnt the disk id).
When attempting to load the image in the end method using getDiskImage()
no data will be returned as the disk id is used as the volume id and
NPE will be thrown.
In other parts of the command the disk is loaded manually, therefore
this exception is thrown only on the end methods.
Looking forward, we should pass the id provided by the user in the
parameters image group id and complete the image id from the db - this
patch fixes the problem by altering the log in order to reduce the risk
in backporting this change to the stable branches.
Change-Id: Ice26f4d19723042097a81ea4b685a7aa31faf976
Bug-url: https://bugzilla.redhat.com/1400299
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/69646
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice26f4d19723042097a81ea4b685a7aa31faf976
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.0]: dal: AuditLogMessages - missing message
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: dal: AuditLogMessages - missing message
......................................................................
dal: AuditLogMessages - missing message
This patch adds the missing
"USER_DEACTIVATE_STORAGE_DOMAIN_OVF_UPDATE_INCOMPLETE" message.
Change-Id: I29e2eb1f8faef4c3c4884a6b1fa5a7601e33a19f
Bug-Url: https://bugzilla.redhat.com/1410105
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/69645
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29e2eb1f8faef4c3c4884a6b1fa5a7601e33a19f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: scheduling: Allow balancing to the same host
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: scheduling: Allow balancing to the same host
......................................................................
scheduling: Allow balancing to the same host
Bug-Url: https://bugzilla.redhat.com/1410040
Change-Id: Ib7bcc7c84c23c0e31e4182320482533554c9b5c9
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/BalanceResult.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnit.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnitTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnitTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnitTest.java
6 files changed, 67 insertions(+), 18 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Yanir Quinn: Verified
--
To view, visit https://gerrit.ovirt.org/69014
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7bcc7c84c23c0e31e4182320482533554c9b5c9
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months