Change in ovirt-engine[master]: engine: add ipv6 properties to VmInitNetwork
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: engine: add ipv6 properties to VmInitNetwork
......................................................................
engine: add ipv6 properties to VmInitNetwork
Change-Id: I313b0709fcc0037ffa4d564f0b516a47b3db218f
Bug-Url: https://bugzilla.redhat.com/1330217
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInitNetwork.java
1 file changed, 33 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/72222
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I313b0709fcc0037ffa4d564f0b516a47b3db218f
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: engine: store ipv6 properties in CloudInitHandler
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: engine: store ipv6 properties in CloudInitHandler
......................................................................
engine: store ipv6 properties in CloudInitHandler
Change-Id: I7f99c3c18d62c0a2a2c36699708d5d52c49999c5
Bug-Url: https://bugzilla.redhat.com/1330217
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/network/vm/VmInitNetworkIpInfoFetcher.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/network/vm/VmInitNetworkIpv4InfoFetcher.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/network/vm/VmInitNetworkIpv6InfoFetcher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java
A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandlerTest.java
5 files changed, 241 insertions(+), 11 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/72223
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f99c3c18d62c0a2a2c36699708d5d52c49999c5
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: core: minor refactoring in create vm
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: minor refactoring in create vm
......................................................................
core: minor refactoring in create vm
Layout issues.
Change-Id: I5b481d8d2a6c43f126edac6877b678ef787d7fe4
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVDSCommand.java
1 file changed, 11 insertions(+), 10 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/73150
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b481d8d2a6c43f126edac6877b678ef787d7fe4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: core: minor optimization in create vm
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: minor optimization in create vm
......................................................................
core: minor optimization in create vm
Set VM's is_initialize to true only if it false (this prevents
an update in the database for many run VM operations).
Change-Id: I3962012c2a531771e94db3d5a23410622c09dbdc
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVDSCommand.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/73151
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3962012c2a531771e94db3d5a23410622c09dbdc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: core: changed logic when should be 'default_route' flag pass...
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: core: changed logic when should be 'default_route' flag passed to vdsm
......................................................................
core: changed logic when should be 'default_route' flag passed to vdsm
Before default_route role default_route
flag was set when network was management network, and
had ipConfiguration data with gateway set in ipv4 or ipv6 address.
During upgrade script sooner in this topic we set all management
networks to have default_route role, so we can just check this.
Change-Id: Iaedb9375c68781c0fae52080bd4205b3cab031ea
Bug-Url: https://bugzilla.redhat.com/1200963
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
1 file changed, 9 insertions(+), 6 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71181
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaedb9375c68781c0fae52080bd4205b3cab031ea
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: core: refactoring of HostSetupNetworksCommand
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: core: refactoring of HostSetupNetworksCommand
......................................................................
core: refactoring of HostSetupNetworksCommand
• removed caching 'networksToConfigure' via getNetworksToConfigure
• removed unused fillInUnsetIpConfigs
• fixed visibilities
• minimized numbers of calculation getNetworksToConfigure
• removed 'single exit point of method' rule in defaultRouteSupported
• removed one unneeded db call to figure out management network
Change-Id: Ic26bd17a80b4d6d17585fee9e4adafd74c67d972
Bug-Url: https://bugzilla.redhat.com/1200963
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtilImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtilImplTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtil.java
4 files changed, 111 insertions(+), 42 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71180
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic26bd17a80b4d6d17585fee9e4adafd74c67d972
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in jenkins[master]: ovirt-engine-dashboard: drop fc24 builds and 4.0 and 4.1 nig...
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: ovirt-engine-dashboard: drop fc24 builds and 4.0 and 4.1 nightly
......................................................................
ovirt-engine-dashboard: drop fc24 builds and 4.0 and 4.1 nightly
Change-Id: I87463eff99070372181da43d6aba6b7edaa3fd5e
Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine-dashboard/ovirt-engine-dashboard_standard.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml
3 files changed, 0 insertions(+), 9 deletions(-)
Approvals:
Eyal Edri: Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me
Scott Dickerson: Verified
--
To view, visit https://gerrit.ovirt.org/73182
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87463eff99070372181da43d6aba6b7edaa3fd5e
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[ovirt-engine-4.1.1.z]: packaging: spec: Require collectd/fluentd+plugins
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: spec: Require collectd/fluentd+plugins
......................................................................
packaging: spec: Require collectd/fluentd+plugins
To allow collecting data and sending to a central store.
Change-Id: Ie497bae2d80c7bf27ff4bd401e9c83dc49a33694
Bug-Url: https://bugzilla.redhat.com/1406005
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit eb5e384a395754f8f7cc42b664d6ddde57676a41)
---
M ovirt-engine.spec.in
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Sandro Bonazzola: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/73166
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie497bae2d80c7bf27ff4bd401e9c83dc49a33694
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: core: remove unused methods from VM class
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: remove unused methods from VM class
......................................................................
core: remove unused methods from VM class
Change-Id: Id567150cf30f01b724c065db37592f31ed728231
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
1 file changed, 0 insertions(+), 12 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/73139
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id567150cf30f01b724c065db37592f31ed728231
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[ovirt-engine-4.1.1.z]: search: Add spm_id as a searchable field for Host
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: search: Add spm_id as a searchable field for Host
......................................................................
search: Add spm_id as a searchable field for Host
Required for bare metal to HE migration procedure.
Also allow to quickly map VDSM's host_id to host
in the engine.
Change-Id: I07e8efdb31dc92bfa2958b7261fcde15e14c0bb4
Bug-Url: https://bugzilla.redhat.com/id=1417518
Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdsConditionFieldAutoCompleter.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Denis Chaplygin: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73241
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07e8efdb31dc92bfa2958b7261fcde15e14c0bb4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month