February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: search: Add spm_id as a searchable field for Host
by Code Review 28 Feb '17

28 Feb '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: search: Add spm_id as a searchable field for Host ...................................................................... search: Add spm_id as a searchable field for Host Required for bare metal to HE migration procedure. Also allow to quickly map VDSM's host_id to host in the engine. Change-Id: I07e8efdb31dc92bfa2958b7261fcde15e14c0bb4 Bug-Url: https://bugzilla.redhat.com/id=1417518 Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdsConditionFieldAutoCompleter.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Denis Chaplygin: Verified Martin Peřina: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72023 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07e8efdb31dc92bfa2958b7261fcde15e14c0bb4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Add download disk example
by Code Review 28 Feb '17

28 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add download disk example ...................................................................... Add download disk example This patch adds an example of how to download a disk to a local file. Change-Id: I4cb1a596f419e3a4efe8b28eb7f15c9fbe4fcba8 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit ac1d8c5e0d7d75da8170d6095809711e99b7b95c) --- A sdk/examples/download_disk.py 1 file changed, 143 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cb1a596f419e3a4efe8b28eb7f15c9fbe4fcba8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: added default_route column to network_cluster table
by Code Review 28 Feb '17

28 Feb '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: core: added default_route column to network_cluster table ...................................................................... core: added default_route column to network_cluster table Bug-Url: https://bugzilla.redhat.com/1200963 Change-Id: I29acb69df1743223cc96a2cf53cbf0ce836280c4 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkClusterDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/04_02_0170_add_default_route_network_role_to_network_cluster.sql 5 files changed, 45 insertions(+), 16 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70768 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29acb69df1743223cc96a2cf53cbf0ce836280c4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add download disk example
by Code Review 28 Feb '17

28 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add download disk example ...................................................................... Add download disk example This patch adds an example of how to download a disk to a local file. Change-Id: I4cb1a596f419e3a4efe8b28eb7f15c9fbe4fcba8 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A sdk/examples/download_disk.py 1 file changed, 143 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/73152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cb1a596f419e3a4efe8b28eb7f15c9fbe4fcba8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Use 'initial_size' when creating disk for upload
by Code Review 28 Feb '17

28 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Use 'initial_size' when creating disk for upload ...................................................................... Use 'initial_size' when creating disk for upload This patch changes the example that shows how to upload a disk so that it uses explicitly uses the 'initial_size' attribute, as otherwise the upload will eventually fail. Change-Id: Iae939ab1c4fcafed358b7be535b477b36f5bd5a7 Related-To: https://bugzilla.redhat.com/1425572 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 3f9c8e9f827f9fc79d0397b1532f500762fe090f) --- M sdk/examples/upload_disk.py 1 file changed, 22 insertions(+), 10 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73199 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae939ab1c4fcafed358b7be535b477b36f5bd5a7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: added defaultRoute field to NetworkCluster
by Code Review 28 Feb '17

28 Feb '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: core: added defaultRoute field to NetworkCluster ...................................................................... core: added defaultRoute field to NetworkCluster Change-Id: I85959ef9387a81e513c6af6060d3bd1da5d503c3 Bug-Url: https://bugzilla.redhat.com/1200963 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToClusterInternalCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToClusterParameter.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkCluster.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonImmutableSerializeDeserializeTest.java 6 files changed, 28 insertions(+), 7 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85959ef9387a81e513c6af6060d3bd1da5d503c3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageHandlingCommandBase - getEntitiesFromStorageOvf...
by Code Review 28 Feb '17

28 Feb '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: StorageHandlingCommandBase - getEntitiesFromStorageOvfDisk() loop ...................................................................... core: StorageHandlingCommandBase - getEntitiesFromStorageOvfDisk() loop getEntitiesFromStorageOvfDisk() will enter infinte loop if the ovfStoreDiskImages list contains only not updated ovf store disks. This patch changes it to break in that case, avoiding the inifinte loop. The issue existed since the relevant code was introduced, it was exposed by https://bugzilla.redhat.com/1412547 which made it occur frequently. This patch makes the minimal change to solve the issue as it's going to be backported to the stable branch, more refactors will be made on the master branch. Change-Id: I8669fc6a14879456116fb95ea23737f1ff6672a3 Bug-Url: https://bugzilla.redhat.com/1424755 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/72996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8669fc6a14879456116fb95ea23737f1ff6672a3 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: simplified NetworkCluster creation.
by Code Review 28 Feb '17

28 Feb '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: core: simplified NetworkCluster creation. ...................................................................... core: simplified NetworkCluster creation. original code was not that readable and contained a lots of duplicates Change-Id: Ic3eb1ae0e95e2cdbbbb45db9768ff969fc7f3f74 Bug-Url: https://bugzilla.redhat.com/1200963 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToClusterParameter.java 1 file changed, 29 insertions(+), 8 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3eb1ae0e95e2cdbbbb45db9768ff969fc7f3f74 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Use 'initial_size' when creating disk for upload
by Code Review 28 Feb '17

28 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Use 'initial_size' when creating disk for upload ...................................................................... Use 'initial_size' when creating disk for upload This patch changes the example that shows how to upload a disk so that it uses explicitly uses the 'initial_size' attribute, as otherwise the upload will eventually fail. Change-Id: Iae939ab1c4fcafed358b7be535b477b36f5bd5a7 Related-To: https://bugzilla.redhat.com/1425572 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/examples/upload_disk.py 1 file changed, 22 insertions(+), 10 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae939ab1c4fcafed358b7be535b477b36f5bd5a7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove unused template information from vm view
by Code Review 28 Feb '17

28 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: remove unused template information from vm view ...................................................................... core: remove unused template information from vm view The motivation is to minimize the size of the VM object. Change-Id: I03e9f7ba99fc095755d8eac505df1f803dd4e9dd Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java M packaging/dbscripts/create_views.sql 3 files changed, 0 insertions(+), 127 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/73101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03e9f7ba99fc095755d8eac505df1f803dd4e9dd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0