Change in ovirt-engine[master]: userportal: IconUtils.extractIconIds null resistant
by Code Review
>From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal: IconUtils.extractIconIds null resistant
......................................................................
userportal: IconUtils.extractIconIds null resistant
It failed on NPE when it tried to extract icon id of a pool without any
VM.
Change-Id: Id5bdf9357d581b203065d63b7c82bef5e07691a0
Bug-Url: https://bugzilla.redhat.com/1378331
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/IconUtils.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71735
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5bdf9357d581b203065d63b7c82bef5e07691a0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0]: vdsbroker: Update ssl protocol version
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: vdsbroker: Update ssl protocol version
......................................................................
vdsbroker: Update ssl protocol version
We need to update http client used by commands like
UploadStreamVDSCommand. We need to make sure not to narrow enabled
protocol to only one.
Bug-Url: https://bugzilla.redhat.com/1419540
Change-Id: I25983c1fdc748f088a6e1528ef1b2df8d63f4f79
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/AuthSSLProtocolSocketFactory.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
3 files changed, 14 insertions(+), 23 deletions(-)
Approvals:
Ondra Machacek: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71722
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25983c1fdc748f088a6e1528ef1b2df8d63f4f79
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.1]: webadmin: update actions availability of VMs list with "excl...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: update actions availability of VMs list with "exclusive" lock
......................................................................
webadmin: update actions availability of VMs list with "exclusive" lock
Updating webAdmin actions availability of VMs in VmListModel to treat a VM
in an "exclusive" memory lock and in "Down" status as if it
is in an "ImageLocked" DB status and therefore block relevant actions for it.
This is implemented by adding a new entity for overriding the getStatus()
method of the VM entity, used only by VmListModel.
This fix the problem that till now VMs in an "ImageLocked" status were checked
and relevant actions were blocked for them in Webadmin as required, but VMs in
an "exclusive" memory lock status were treated as if they are in
"Down"/"Up"/Maintenance" etc status so evethough they were in the middle of
a process like importing, relevant actions were not blocked for them as required.
Change-Id: I51776fba35828589604ca44374a7574e91b4a20c
Bug-Url: https://bugzilla.redhat.com/1364137
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmWithStatusForExclusiveLock.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
5 files changed, 57 insertions(+), 17 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/71750
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51776fba35828589604ca44374a7574e91b4a20c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: webadmin: v2v- remove "VirtIO Drivers" drop down for KVM
by Code Review
>From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: v2v- remove "VirtIO Drivers" drop down for KVM
......................................................................
webadmin: v2v- remove "VirtIO Drivers" drop down for KVM
Since You can't inject virtio WIN drivers to VMs with WIN OS imported from KVM (not
supported), then we remove the "virtio drivers" drop down menu from v2v
import dialog (2nd dialog).
We also avoid displaying the following warning message in v2v dialog for KVM import:
"You have selected windows OS and have not selected VirtIO
drivers. This may cause the system not to boot up".
Change-Id: Ia9d4c46d27691f5e3fef3259529f80d9de86a8aa
Bug-Url: https://bugzilla.redhat.com/1374589
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java
1 file changed, 32 insertions(+), 17 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/71666
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9d4c46d27691f5e3fef3259529f80d9de86a8aa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: DetachNetworkToClusterCommand type inference
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DetachNetworkToClusterCommand type inference
......................................................................
core: DetachNetworkToClusterCommand type inference
Change-Id: Iabf1337a9f3fe698345a5133b2ca2916126f3358
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToClusterCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/71754
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabf1337a9f3fe698345a5133b2ca2916126f3358
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: write iotune to the domxml
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: write iotune to the domxml
......................................................................
core: write iotune to the domxml
And some cleanup in the domxml builder.
Change-Id: Iab7f67cbb11c72e60d36c841323f5a43a197cab1
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IoTuneUtils.java
2 files changed, 65 insertions(+), 24 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/71681
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab7f67cbb11c72e60d36c841323f5a43a197cab1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in jenkins[master]: ovirt-vmconsole: drop fc23
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-vmconsole: drop fc23
......................................................................
ovirt-vmconsole: drop fc23
fc23 is EOL
Change-Id: I46e20b289181a8641594511fb5cc0fb4b47233bc
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-vmconsole/ovirt-vmconsole_create-rpms.yaml
M jobs/confs/projects/ovirt-vmconsole/ovirt-vmconsole_standard.yaml
2 files changed, 0 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71727
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46e20b289181a8641594511fb5cc0fb4b47233bc
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in jenkins[master]: ovirt-iso-uploader: drop fc23
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-iso-uploader: drop fc23
......................................................................
ovirt-iso-uploader: drop fc23
fc23 is EOL
Change-Id: I1b99ee9c771489a2b091e6ee4d81b9ebb821eb85
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-iso-uploader/ovirt-iso-uploader_create-rpms.yaml
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71728
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b99ee9c771489a2b091e6ee4d81b9ebb821eb85
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in jenkins[master]: py2exe-py2.7: drop fc23
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: py2exe-py2.7: drop fc23
......................................................................
py2exe-py2.7: drop fc23
fc23 is EOL
Change-Id: I6650aeb3ef257e6ec93417fee11a7f385421c379
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/py2exe-py2.7/py2exe-py2.7.yaml
1 file changed, 0 insertions(+), 28 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71726
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6650aeb3ef257e6ec93417fee11a7f385421c379
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in jenkins[master]: python-windows: drop fc23
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: python-windows: drop fc23
......................................................................
python-windows: drop fc23
fc23 is EOL
Change-Id: I20fb1daca69751f905e6a37f953b357223d3f254
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/python-windows/python-windows.yaml
1 file changed, 2 insertions(+), 29 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71724
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20fb1daca69751f905e6a37f953b357223d3f254
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months