Change in ovirt-engine[ovirt-engine-4.1]: setup: let vmconsole proxy be stopped on cleanup
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: setup: let vmconsole proxy be stopped on cleanup
......................................................................
setup: let vmconsole proxy be stopped on cleanup
We must make sure that engine-cleanup actually
cleans up the ovirt-vmconsole-proxy.
This means stopping the service, if running.
Change-Id: I5910b214470a69ffd3d2fc5fdc546ec6de32e402
Bug-Url: https://bugzilla.redhat.com/1276670
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/constants.py
M packaging/setup/plugins/ovirt-engine-common/vmconsole_proxy_helper/core.py
A packaging/setup/plugins/ovirt-engine-remove/vmconsole_proxy_helper/__init__.py
A packaging/setup/plugins/ovirt-engine-remove/vmconsole_proxy_helper/misc.py
M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py
5 files changed, 141 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/71365
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5910b214470a69ffd3d2fc5fdc546ec6de32e402
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: VmTemplate.actualDiskSize property not cached
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: VmTemplate.actualDiskSize property not cached
......................................................................
core: VmTemplate.actualDiskSize property not cached
The problem with #actualDiskSize field was that it needed to be marked
as @EditableVmTemplateField to allow UpdateVmTemplateCommand to be
called with new template both with and without `diskImageMap` property
set. This annotation was required even-though no disk related changes
were actually performed by the UpdateVmTemplateCommand.
Related bugs:
https://bugzilla.redhat.com/1417597
https://bugzilla.redhat.com/1409579
>From now on VmTemplate.actualDiskSize is a computed property based on
`diskImageMap` property.
The only code that calls getActualDiskSize() repeatedly is
VmTemplateComparerByDiskSize. Cache of `actualDiskSize` values was
introduced in this class.
Change-Id: Ie2011fa8a63c304c220be7a326c4142d81f7cd34
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmTemplateComparerByDiskSize.java
2 files changed, 20 insertions(+), 17 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/71572
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2011fa8a63c304c220be7a326c4142d81f7cd34
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: catch exception coming from the OpenStack client
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: catch exception coming from the OpenStack client
......................................................................
core: catch exception coming from the OpenStack client
Uncaught OpenStack client exception led to a 500 error when
attempting to retrieve images list from Glance (with a bad URL).
Since the exception is unchecked we need to make sure we catch
it ourselves and provide a proper message.
Change-Id: Icbeb669135dfa51333cc1c3874bb387f6812feab
Bug-Url: https://bugzilla.redhat.com/1379130
Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/GetImagesListQueryBase.java
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Benny Zlotnik: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70969
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbeb669135dfa51333cc1c3874bb387f6812feab
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: remove redundant legacy check in create vm
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: remove redundant legacy check in create vm
......................................................................
core: remove redundant legacy check in create vm
Generally, we do not have validations in VDS command. That is because the bll
command validates that the operation can be executed and the locks it takes
ensures that this 'valid' state is preserved.
However, we have these annoying checks in create vm. Not only that these
checks are unexpected, but they also interact with the database - and this
has a performance penalty.
One of these checks that the status of the VM is different than ImageLocked.
In RunVm we validate that the VM is not in this status and then exclusively
lock the VM. So this check is relevant only if there is a flow in which the
VM is switched to ImageLocked without being locked by (in-memory) engine
lock. But now that we lock the VM before switching it to ImageLocked in
AddVmTemplate (see If4822f), there is no such flow so this check is
redundant and therefore removed.
Change-Id: I98d9ff00ec182b742f5a04c2866b7852f74c3e92
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVDSCommand.java
1 file changed, 0 insertions(+), 12 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/71446
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I98d9ff00ec182b742f5a04c2866b7852f74c3e92
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-hosted-engine-ha[v2.1.z]: Always add console device
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: Always add console device
......................................................................
Always add console device
When reading the vm ovf the console device was ignored.
This patch adds the console device if it exists in the ovf and
creates a stubbed device in case the ovf is missing it.
That way the console commands will not fail.
Change-Id: Id860888421097336a41b5a4612e58668de20c917
Bug-Url:https://bugzilla.redhat.com/1364132
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
(cherry picked from commit 93fc9a0)
---
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py
2 files changed, 17 insertions(+), 3 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/71472
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id860888421097336a41b5a4612e58668de20c917
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: v2.1.z
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: Remove unused resources from BLL tests
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused resources from BLL tests
......................................................................
core: Remove unused resources from BLL tests
Change-Id: I8cb2e6a1767960b5a9bb0322ec191a863d30a4da
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/bll/src/test/resources/engine.p12
D backend/manager/modules/bll/src/test/resources/ovirt-isos/rhevh-5.8-20111010.0.el6.iso
D backend/manager/modules/bll/src/test/resources/ovirt-isos/rhevh-7.0-20111010.0.el6.iso
D backend/manager/modules/bll/src/test/resources/ovirt-isos/vdsm-compatibility-7.0-20111010.0.el6.txt
D backend/manager/modules/bll/src/test/resources/ovirt-isos/version-5.8-20111010.0.el6.txt
D backend/manager/modules/bll/src/test/resources/ovirt-isos/version-6.2-20111010.0.el6.txt
D backend/manager/modules/bll/src/test/resources/ovirt-isos/version-7.0-20111010.0.el6.txt
D backend/manager/modules/bll/src/test/resources/stylesheets/NoJRMPConnectionFactoryTemplate.xsl
8 files changed, 0 insertions(+), 794 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/71687
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8cb2e6a1767960b5a9bb0322ec191a863d30a4da
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core, webadmin: Imported VMs have default maxMemory
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core, webadmin: Imported VMs have default maxMemory
......................................................................
core, webadmin: Imported VMs have default maxMemory
... instead of maximum of allowed value as defined in *MaxMemorySizeInMB
configuration values. The default is 4x value of memory size and it is
maximum suggested value of maxMemory.
Default value of ConfigValues.VM64BitMaxMemorySizeInMB was changed to
4194304 to match the current value in vdc_options table. After this
change default values of all *MaxMemorySizeInMB options should match
values in vdc_options.
Reasons for not exceeding suggested value:
* QEMU goes through nested loop of size of the maxMemory at its start.
Large value of maxMemory can make QEMU to start for a longer time.
* We want hot plugged memory to be also hot unpluggable. This requires
guest kernel to consider hotplugged memory to be 'movable'. Kernel
may be unstable if movable part of memory is significantly larger than
non-movable part of the memory.
* On PowerPC platform continuous block of non-movable memory of size
1/64 of the max memory needs to be allocated for each VM.
Bug-Url: https://bugzilla.redhat.com/1411844
Change-Id: I025a322573915ee90a5a24be61a12fb433f3bb44
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmCommonUtils.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
4 files changed, 16 insertions(+), 10 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Sharon Gratch: Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69941
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I025a322573915ee90a5a24be61a12fb433f3bb44
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[ovirt-engine-4.1]: packaging: Add a tool to perform vacuum on engine db
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: Add a tool to perform vacuum on engine db
......................................................................
packaging: Add a tool to perform vacuum on engine db
This tool can perform various vacuum operations without specifying the
engine db credentials.
>From the tool usage:
-a - analyze
-A - analyze only
-f - full vacuum
-t - table(s) to vacuum. Use multi -t table for multi tables
-v - verbose
Change-Id: Iff791f6fddaf729b99bbfea8292a734c6df7e719
Bug-Url: https://bugzilla.redhat.com/1388430
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M Makefile
M ovirt-engine.spec.in
A packaging/bin/engine-vacuum.sh
A packaging/bin/generate-pgpass.sh
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/vacuum.py
7 files changed, 226 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
Roy Golan: Verified
--
To view, visit https://gerrit.ovirt.org/71372
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff791f6fddaf729b99bbfea8292a734c6df7e719
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[ovirt-engine-4.1]: packaging: Don't run vacuum tool by default
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: Don't run vacuum tool by default
......................................................................
packaging: Don't run vacuum tool by default
Motivation
Full vacuum might take time so we leave users to device if to run it or
not. The tool could always be invoked separately after the installation.
Change-Id: Idc55639089f18fa23cc613c2540741801736af73
Bug-Url: https://bugzilla.redhat.com/1388430
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/vacuum.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Tal Nisan: Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
Roy Golan: Verified
--
To view, visit https://gerrit.ovirt.org/71373
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc55639089f18fa23cc613c2540741801736af73
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: restapi: Null-safe handling of incorrect disks in Sparsify
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: restapi: Null-safe handling of incorrect disks in Sparsify
......................................................................
restapi: Null-safe handling of incorrect disks in Sparsify
Passing incorrect disk IDs or IDs of direct LUNs or Cinder disks to
SparsifyImageCommand via REST API causes NullPointerException. This
patch adds safety checks to avoid this situation.
Change-Id: Ie2b6b7f29a866f1e5f140754f73a04a20bfaad45
Bug-Url: https://bugzilla.redhat.com/1415759
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/SparsifyImageCommand.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/71543
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2b6b7f29a866f1e5f140754f73a04a20bfaad45
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months