Change in ovirt-engine[master]: webadmin: change the way of displaying username
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: webadmin: change the way of displaying username
......................................................................
webadmin: change the way of displaying username
This patch changes the way the name of the user is displayed in
webadmin.
Now the username is displayed as 'First Last (username)'. Previously
it was 'First Last (username@authz-name)'. This is valid for permissions
tabs.
For the 'Users' tab we now display in username column just the username
without the authorization provider, because authorization provider
column is just next to username column, so it's redudant information.
Change-Id: I24e6e78b9478e23db088f65d529f5f6e60704bee
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1425323
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
M packaging/dbscripts/create_functions.sql
2 files changed, 2 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Verified; Looks good to me, approved
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73608
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24e6e78b9478e23db088f65d529f5f6e60704bee
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[master]: webadmin: remove stray quote from migrationBandwidthLimit me...
by Code Review
>From Greg Sheremeta <gshereme(a)redhat.com>:
Greg Sheremeta has submitted this change and it was merged.
Change subject: webadmin: remove stray quote from migrationBandwidthLimit message
......................................................................
webadmin: remove stray quote from migrationBandwidthLimit message
Change-Id: I21234b0d92d8698d900e24e4796f0b4773317eae
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74640
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21234b0d92d8698d900e24e4796f0b4773317eae
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[ovirt-engine-4.1]: engine: Hide tracebacks in engine.log for non responsive host
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Hide tracebacks in engine.log for non responsive host
......................................................................
engine: Hide tracebacks in engine.log for non responsive host
When host is unreachable there are
exceptions in the engine log.
Change-Id: If78f69334f5a94fd0f2a9c26aa30581d99fab5f9
Bug-Url: https://bugzilla.redhat.com/1414787
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployBase.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/HostMonitoring.java
2 files changed, 7 insertions(+), 13 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74601
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If78f69334f5a94fd0f2a9c26aa30581d99fab5f9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Use %i for arrays of symbols
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Use %i for arrays of symbols
......................................................................
Use %i for arrays of symbols
To make Rubocop happy.
Change-Id: Ib37d02f4cb4e0c03a5b12764c0b1483cc7fa9b6f
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 7753a4a97b0dd2143fa9735e1d07ab619392c77b)
---
M sdk/Rakefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74695
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib37d02f4cb4e0c03a5b12764c0b1483cc7fa9b6f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Use 'reject' instead of 'select' and negation
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Use 'reject' instead of 'select' and negation
......................................................................
Use 'reject' instead of 'select' and negation
To make Rubucop happy.
Change-Id: I0c59a3b26a48e7d07a3e870c6eafa2f2b67e40d5
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 698cca031d75d9ac592ca7e993ac85ccc051322b)
---
M sdk/examples/update_fencing_options.rb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74696
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c59a3b26a48e7d07a3e870c6eafa2f2b67e40d5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine-sdk-ruby[master]: Use 'reject' instead of 'select' and negation
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Use 'reject' instead of 'select' and negation
......................................................................
Use 'reject' instead of 'select' and negation
To make Rubucop happy.
Change-Id: I0c59a3b26a48e7d07a3e870c6eafa2f2b67e40d5
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/examples/update_fencing_options.rb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74676
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c59a3b26a48e7d07a3e870c6eafa2f2b67e40d5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine-sdk-ruby[master]: Use %i for arrays of symbols
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Use %i for arrays of symbols
......................................................................
Use %i for arrays of symbols
To make Rubocop happy.
Change-Id: Ib37d02f4cb4e0c03a5b12764c0b1483cc7fa9b6f
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/Rakefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74675
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib37d02f4cb4e0c03a5b12764c0b1483cc7fa9b6f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: prevent restoring memory from unsupported version
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: prevent restoring memory from unsupported version
......................................................................
core: prevent restoring memory from unsupported version
Add a validation to the preview-snapshot flow that prevents the user from
restoring a snapshot with memory that was taken in a version that is no
longer supported.
While it may be debatable, we choose to block the user from trying to
restore the memory of such a snapshot in order to prevent major problems
in the front-end that are caused by that operation.
Change-Id: Ic6a7507e9a266efe8881b2b048795de1c01cf23d
Bug-Url: https://bugzilla.redhat.com/1434941
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 36 insertions(+), 3 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/74685
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6a7507e9a266efe8881b2b048795de1c01cf23d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in jenkins[master]: adding hyper converged storage system tests jobs
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: adding hyper converged storage system tests jobs
......................................................................
adding hyper converged storage system tests jobs
added master & 4.1
Change-Id: I8b5f9114700406d136c6f65d7d9493d599a352ad
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/projects/ovirt/system-tests.yaml
M jobs/confs/yaml/templates/system_tests_templates.yaml
2 files changed, 28 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72119
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b5f9114700406d136c6f65d7d9493d599a352ad
Gerrit-PatchSet: 5
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in ovirt-engine[ovirt-engine-4.1]: core: Change the limit of LVs per VG to 1000
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Change the limit of LVs per VG to 1000
......................................................................
core: Change the limit of LVs per VG to 1000
Change-Id: Ie192c8ec7619fb33156992b01bc03ada958ac640
Bug-Url: https://bugzilla.redhat.com/1436161
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74682
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie192c8ec7619fb33156992b01bc03ada958ac640
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month