Change in ovirt-engine[master]: core: Change the limit of LVs per VG to 1000
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Change the limit of LVs per VG to 1000
......................................................................
core: Change the limit of LVs per VG to 1000
Change-Id: Ie192c8ec7619fb33156992b01bc03ada958ac640
Bug-Url: https://bugzilla.redhat.com/1436161
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74671
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie192c8ec7619fb33156992b01bc03ada958ac640
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in jenkins[master]: Revert "Use webhooks instead of polling"
by Code Review
>From Pavel Zhukov <pzhukov(a)redhat.com>:
Pavel Zhukov has submitted this change and it was merged.
Change subject: Revert "Use webhooks instead of polling"
......................................................................
Revert "Use webhooks instead of polling"
For some reasons webhooks doesn't work for lago project even if user
seems to be properly configured. Has to be investigated
more. Reverting the patch for make lago working
This reverts commit fc8cd028054ad88b626234c37a5d823f6b8c6227.
Change-Id: I45d2cbfc23f65ddb8056ee23799185dedaedd8fb
---
M jobs/confs/yaml/triggers/github.yaml
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Pavel Zhukov: Verified; Looks good to me, approved; Ready for merge
--
To view, visit https://gerrit.ovirt.org/74680
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45d2cbfc23f65ddb8056ee23799185dedaedd8fb
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhukov(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Pavel Zhukov <pzhukov(a)redhat.com>
7 years, 9 months
Change in ovirt-engine[master]: bll: refactoring: Use Java 8 streams in ImportUtils
by Code Review
>From Martin Betak <mbetak(a)redhat.com>:
Martin Betak has submitted this change and it was merged.
Change subject: bll: refactoring: Use Java 8 streams in ImportUtils
......................................................................
bll: refactoring: Use Java 8 streams in ImportUtils
Replaced manual filtering in a loop with stream & filter.
Change-Id: Iaf56e77b931ec74f1bd77ab921a7c2d2cb73a0f8
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportUtils.java
1 file changed, 3 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74558
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf56e77b931ec74f1bd77ab921a7c2d2cb73a0f8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Fix update of video devices in UpdateVmTemplateCommand
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix update of video devices in UpdateVmTemplateCommand
......................................................................
core: Fix update of video devices in UpdateVmTemplateCommand
The proper VmDeviceUtils#updateVideoDevices was only called from
UpdateVmCommand and UpdateVmTemplateCommand contained only a snippet of code
that covered just a small fraction of all the possible flows. Replaced this
handling in UpdateVmTemplateCommand with proper call to
VmDeviceUtils#updateVideoDevices.
Change-Id: Id4c139248fdfa0774f883d9737bcbc2c627d2cff
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1434161
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
2 files changed, 2 insertions(+), 4 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/74580
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id4c139248fdfa0774f883d9737bcbc2c627d2cff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[ovirt-engine-4.1]: he: Notify user to redeploy HE hosts after recovery.
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: he: Notify user to redeploy HE hosts after recovery.
......................................................................
he: Notify user to redeploy HE hosts after recovery.
As after disaster recovery we could have old HE
hosts still running, having duplicate SPM_IDs
and claiming to be an SPM, we need to tell
user to immediately redeploy those hosts
right after recovery.
Change-Id: I89e7fa4eb6f0097bbe4c0f46d06dd4880aa7f77d
Bug-Url: https://bugzilla.redhat.com/1417518
Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com>
---
M packaging/bin/engine-backup.sh.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Denis Chaplygin: Verified
Martin Peřina: Looks good to me, approved
Martin Sivák: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/73996
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I89e7fa4eb6f0097bbe4c0f46d06dd4880aa7f77d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: build: Don't run checkstyle on generated-sources
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: build: Don't run checkstyle on generated-sources
......................................................................
build: Don't run checkstyle on generated-sources
Suppressing the checks on generated-sources is the wrong approach, as
it still runs all the checks, and then just suppresses their outcome.
This patch takes a more efficient approach, and just excludes them
a priori.
Change-Id: I42943047ce69ed7b505ac1656c42a8acef95dce8
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml
M build-tools-root/checkstyles/src/main/resources/checkstyle.xml
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Freddy Rolland: Looks good to me, but someone else must approve
Greg Sheremeta: Looks good to me, but someone else must approve
Vojtech Szocs: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74619
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42943047ce69ed7b505ac1656c42a8acef95dce8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Fix two small typos in the comments of the example
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Fix two small typos in the comments of the example
......................................................................
Fix two small typos in the comments of the example
Change-Id: I2be686e05be8bccf7308768a3cd2f5c288bec16c
Signed-off-by: Yaniv Kaul <ykaul(a)redhat.com>
(cherry picked from commit a04f36419e3e47c30eaaf111972f852dfba75e58)
---
M sdk/examples/asynchronous_inventory.rb
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74667
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2be686e05be8bccf7308768a3cd2f5c288bec16c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine-sdk-ruby[master]: Fix two small typos in the comments of the example
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Fix two small typos in the comments of the example
......................................................................
Fix two small typos in the comments of the example
Change-Id: I2be686e05be8bccf7308768a3cd2f5c288bec16c
Signed-off-by: Yaniv Kaul <ykaul(a)redhat.com>
---
M sdk/examples/asynchronous_inventory.rb
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74665
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2be686e05be8bccf7308768a3cd2f5c288bec16c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in jenkins[master]: ovirt-guest-agent: drop fc24 on master
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-guest-agent: drop fc24 on master
......................................................................
ovirt-guest-agent: drop fc24 on master
fc24 will be EOL by 4.2 GA
Change-Id: If527e281670f15541e7f04c8829f21129fed6697
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-guest-agent/ovirt-guest-agent_standard.yaml
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74597
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If527e281670f15541e7f04c8829f21129fed6697
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
7 years, 9 months
Change in jenkins[master]: ovirt-engine-sdk: drop fc24 on master
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-engine-sdk: drop fc24 on master
......................................................................
ovirt-engine-sdk: drop fc24 on master
fc24 will be EOL by 4.2 GA
Change-Id: If9580bec9b27fef3f59a5867df4f9cd84ce3b907
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine-sdk/ovirt-engine-sdk_build-artifacts.yaml
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74596
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9580bec9b27fef3f59a5867df4f9cd84ce3b907
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
7 years, 9 months